View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
05352Bug reportsComfortUpdatepublic2011-07-19 15:342011-08-02 17:18
Reportermot Assigned Tomot  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.91+ 
Summary05352: Probably Regression on output logic ref 05217
Description

While I updated my SVN stable to HEAD, limesurvey asked me to run the database upgrade.

I run the database upgrade but then was seeing a duplicated header.

This might be related to 05217.

TagsNo tags attached.
Attached Files
Selection_011.png (28,838 bytes)   
Selection_011.png (28,838 bytes)   
05352-00-double-admin-header.diff (796 bytes)    
### Eclipse Workspace Patch 1.0
#P Limesurvey 1.x trunk stable
Index: admin/update/updater.php
===================================================================
--- admin/update/updater.php	(revision 10602)
+++ admin/update/updater.php	(working copy)
@@ -627,7 +627,7 @@
     {
         if(isset($_GET['continue']) && $_GET['continue']==1)
         {
-            echo getAdminHeader()."<div style='width:90%; padding:1% 10%;background-color:#eee;'>";
+            echo "<div style='width:90%; padding:1% 10%;background-color:#eee;'>";
             $upgradedbtype=$databasetype;
             if ($upgradedbtype=='mssql_n' || $upgradedbtype=='odbc_mssql' || $upgradedbtype=='odbtp') $upgradedbtype='mssql';
             if ($upgradedbtype=='mssqlnative') $upgradedbtype = 'mssqlnative';
05352-00-double-admin-header.diff (796 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)10545
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionMysql 5 Family
Server OS (if known)Linux (Fedora 14)
Webserver software & version (if known)Apache 2.2
PHP Version5.3.6

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2011-07-21 18:15

administrator   ~15819

Yes, I can see that too. Can you have another look and check what's wrong, please?
mot

mot

2011-07-22 01:01

reporter   ~15824

Will do.
mot

mot

2011-07-28 19:10

reporter   ~15876

Found the culprit, will commit it. There is only one place left where that function was invoked /admin/install/index.php#65 and it looks like it's mislplaced there as well.

In case not, add the admin header again, but there.
c_schmitz

c_schmitz

2011-08-02 17:18

administrator   ~15935

1.91+ version released.

Issue History

Date Modified Username Field Change
2011-07-19 15:34 mot New Issue
2011-07-19 15:34 mot Status new => assigned
2011-07-19 15:34 mot Assigned To => c_schmitz
2011-07-19 15:34 mot File Added: Selection_011.png
2011-07-21 18:15 c_schmitz Assigned To c_schmitz => mot
2011-07-21 18:15 c_schmitz Note Added: 15819
2011-07-22 01:01 mot Note Added: 15824
2011-07-28 19:09 mot File Added: 05352-00-double-admin-header.diff
2011-07-28 19:10 mot Note Added: 15876
2011-07-28 19:15 mot Status assigned => resolved
2011-07-28 19:15 mot Resolution open => fixed
2011-08-02 17:18 c_schmitz Note Added: 15935
2011-08-02 17:18 c_schmitz Status resolved => closed