View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
04422Bug reportsSurvey takingpublic2010-06-15 14:582010-10-07 22:17
Reporterjdalegonzalez Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionwon't fix 
Product Version1.87+ 
Fixed in Version1.90RC2 
Summary04422: navigator code fails to call any onsubmit function when previous is pressed
Description

The onclick code attached to the "previous" button for the survey form directly calls document.limesurvey.submit, which bypasses any onsubmit handler that's been attached to the form. This isn't a big deal because the default form doesn't have an onsubmit handler, but if one is added via a modification or code added using template.js, it won't get called. In my copy, I changed line 2603 in index.php adding "if (!document.limesurvey.onsubmit || document.limesurvey.onsubmit())" before the call to document.limesurvey.submit().

Steps To Reproduce

1) change template.js to attach an onsubmit handler to the limesurvey form.
2) Click next on the survey to verify that it fires
3) Click prev on the survey and notice that it doesn't fire.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)8488
I will donate to the project if issue is resolved
Browserall
Database type & versionall
Server OS (if known)all
Webserver software & version (if known)all
PHP Versionall

Relationships

Relationship GraphDependency Graph
related to 04645 closedc_schmitz Return-Key returns user to previous page 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2010-10-07 22:17

administrator   ~13037

Please not that in rev 9184 this has changed again. If you want to bind an onsubmit event to the #limesurvey form do it using jQuery to make it consistently working with 'previous page' and 'next page' button.

Issue History

Date Modified Username Field Change
2010-06-15 14:58 jdalegonzalez New Issue
2010-06-15 14:58 jdalegonzalez Status new => assigned
2010-06-15 14:58 jdalegonzalez Assigned To => user372
2010-06-17 00:55 c_schmitz Assigned To user372 => c_schmitz
2010-07-01 16:16 c_schmitz Status assigned => resolved
2010-07-01 16:16 c_schmitz Fixed in Version => 1.90RC2
2010-07-01 16:16 c_schmitz Resolution open => won't fix
2010-07-06 11:22 c_schmitz Status resolved => closed
2010-10-07 22:17 c_schmitz Note Added: 13037
2010-10-07 22:17 c_schmitz Relationship added related to 04645
2010-10-25 00:18 c_schmitz Category Survey at Runtime => Survey taking