View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
04245Bug reportsTheme editorpublic2010-03-25 20:162010-05-05 10:28
Reporteruser659Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.87+ 
Summary04245: CSS class "questionhelp" used for two different elements
Description

The class "questionhelp" is used for two different parts of a question, namely for the {QUESTION_HELP} -with underscore- content, the built-in hint/instructions how to answer the question type; and also for the custom {QUESTIONHELP} -no underscore- content inserted by users as part of creating a question, normally shown at bottom with ?-icon.

This makes it difficult to style the two different components properly, particularly the {QUESTION_HELP} content. Some templates have hardcoded styling and in the "default" template the {QUESTION_HELP} content looks identical to the actual question text.

Additional Information

A quick and dirty fix would be to add more complex CSS selectors (child/descendant) in template.css to select {QUESTION_HELP}, eg. see attached patch against v1.87, build 8498 for the default template.

A good fix should provide a unique class for {QUESTION_HELP}, but even better also distinguish the two parts more clearly in both placeholder and class - perhaps Q_INSTRUCTIONS.

TagsNo tags attached.
Attached Files
template_css.diff (779 bytes)    
--- Y:/Inetpub/wwwroot/software/limesurveymods/sr/templates/default/template.css	Wed Feb 24 03:26:10 2010
+++ Y:/Inetpub/wwwroot/software/limesurveymods/sr/templates/NuUKZNdefault/template.css	Thu Mar 25 20:41:10 2010
@@ -180,7 +180,14 @@
     padding:0.5em 1.5em;          
 }
 
+td.questiontext > .questionhelp {
+/* Selector may vary by template - to format the {QUESTION_HELP} -with underscore- content, the built-in hint/instructions how to answer the question type */
+	color: grey;
+	font-weight: normal;
+}
+
 td.questionhelp {
+/* Format the custom {QUESTIONHELP} -no underscore- content inserted by users as part of creating a question, normally shown at bottom with ?-icon */
     font-size:10px;
     background-color:#eef6ff;
     padding-left:1em;
template_css.diff (779 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)8498
I will donate to the project if issue is resolved
Browser
Database type & versionany
Server OS (if known)any
Webserver software & version (if known)any
PHP Versionany

Users monitoring this issue

There are no users monitoring this issue.

Activities

user659

2010-03-25 22:40

  ~11512

Ermm, the child selector which I used in the diff might be overkill. span.questionhelp might work just as well as a selector ...
tpartner

tpartner

2010-04-16 21:38

partner   ~11622

Fixed in revision 8603

I changed the class for the {QUESTIONHELP} element to "survey-question-help" in all templates. This differentiates it from the {QUESTION_HELP} element.

ITEd, although I agree it may be confusing, I didn't muck around with the {QUESTIONHELP} keyword as I thought that may be too disruptive to existing custom templates.

Issue History

Date Modified Username Field Change
2010-03-25 20:16 user659 New Issue
2010-03-25 20:16 user659 File Added: template_css.diff
2010-03-25 22:40 user659 Note Added: 11512
2010-03-26 07:22 user372 Status new => assigned
2010-03-26 07:22 user372 Assigned To => tpartner
2010-04-16 21:38 tpartner Note Added: 11622
2010-04-16 21:38 tpartner Status assigned => resolved
2010-04-16 21:38 tpartner Resolution open => fixed
2010-05-05 10:28 c_schmitz Status resolved => closed
2015-12-11 14:40 c_schmitz Category Templates => Theme editor