View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
03896Bug reportsTheme editorpublic2009-11-24 22:162009-12-11 12:17
Reporteruser372Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version1.87RC5 
Summary03896: Evaluation of migrating to jQuery progressbar
Description

The current progressbar in LimeSurvey looks a little bit dowdy, it would be nice if we could switch to jQuery progressbar:
http://jqueryui.com/demos/progressbar/#default

Additional Information

22:00:24) El-Matador-69: Yesterday I had a look at the jquery progress bar plugin ==> Is it possible to use it for LimeSurvey?
(22:00:45) c_schmitz: I looked at it too
(22:00:47) El-Matador-69: On my knowledge that would make our templates look more professional
(22:00:57) c_schmitz: funny :-)
(22:01:11) c_schmitz: but I found it to be to limiting
(22:01:35) jasebo|away heißt jetzt jasebo
(22:01:45) c_schmitz: I didn't think that a good progressbar would be so hard
(22:01:45) c_schmitz: but it is
(22:03:57) El-Matador-69: that's what we are talking about: http://jqueryui.com/demos/progressbar/#animated
(22:04:23) c_schmitz: yeah I know
(22:05:43) El-Matador-69: but even the default one is nicer than our current solution - more roundly: http://jqueryui.com/demos/progressbar/#default
(22:06:03) c_schmitz: the problem with this progressbar is that you cant place labels beside it
(22:07:21) c_schmitz: at least I did not manage to
(22:07:38) c_schmitz: (we need a solution that works in all browsers)
(22:07:43) c_schmitz: maybe tpartner can help?
(22:08:33) tpartner: Why can't you put labels beside it?
(22:08:53) c_schmitz: its a div
(22:09:02) c_schmitz: you can place anything in it
(22:09:22) c_schmitz: that would destroy the layout of the jQuery progress bar
(22:10:56) c_schmitz: tpartner, maybe you can have a look at it
(22:11:24) tpartner: What wrapping it in another div and then prepend and append that div with the labels?
(22:12:19) tpartner: *What about
(22:13:05) c_schmitz: sure, if that works for all browsers including IE6
(22:13:09) c_schmitz: I am fine with it
(22:13:36) tpartner: Sure, I'll have a look tonight or tomorrow
(22:14:22) c_schmitz: tpartner: function makegraph in index.php
(22:14:45) tpartner: Thanks, saved a search

TagsNo tags attached.
Attached Files
progress_v1.gif (4,707 bytes)   
progress_v1.gif (4,707 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)
I will donate to the project if issue is resolved
Browser
Database type & version
Server OS (if known)
Webserver software & version (if known)
PHP Version

Users monitoring this issue

There are no users monitoring this issue.

Activities

tpartner

tpartner

2009-11-27 14:11

partner   ~10288

This is possible but it should be noted that the corners are not rounded in IE - see the attached image.

user372

2009-11-27 15:13

  ~10290

How much work is it to rework all existing templates shipped with the LimeSurvey package?
tpartner

tpartner

2009-11-27 15:36

partner   ~10291

Not too much. Probably a couple of hours to Q/A all templates in all browsers. I could do it over the weekend.

There may be an impact on custom templates though - I've wrapped all of the progress elements in a new division to align them correctly.
c_schmitz

c_schmitz

2009-11-27 19:12

administrator   ~10293

Tony, looks great.
Do you think the template have to be changed?

It would be great if all changes are in makegraph only so users don't have to edit their templates on upgrade (except if they made some special changes to the progressbar)
tpartner

tpartner

2009-11-27 19:47

partner   ~10294

The styles in the templates now position the progress elements with negative margins which, in my opinion is sub-optimal. But I'll look into it on the weekend.
tpartner

tpartner

2009-11-29 19:51

partner   ~10309

I think the trick would be to create a small default stylesheet for the new progress bar elements - /scripts/jquery/css/start/lime-progress.css - and have it loaded by index.php. That way the new progress bar would appear with default styles in all templates and if folks want to change the styles, they can in their template.css files.

Thoughts?
c_schmitz

c_schmitz

2009-11-30 01:28

administrator   ~10318

Hi Tony, sounds fine to me. Please go ahead.
tpartner

tpartner

2009-11-30 13:19

partner   ~10348

I've checked in the changes to index.php and the default style sheet in revision 8017.

The default styles are basic grey tones to work in any template but I'd like to spice them up a bit in the shipped template.css files.

user372

2009-12-04 00:15

  ~10437

@ tpartner: what I have seen so far looks great! Before closing that ticket please integrate the jquery progressbar into the preview of the template editor too - THX!

Btw. I noticed a bug with the "normal" progress bar at the preview in the template editor - but only at the default template - might you have a look at that issue too?
tpartner

tpartner

2009-12-04 22:28

partner   ~10467

ElMatador69, I have added the new progress bar to the template previews. It also fixed the bug in the default template preview.
tpartner

tpartner

2009-12-05 00:08

partner   ~10469

Okay, I've tweaked all of the shipped template styles for the new progress bar. Have a look (probably the template editor is the easiest way) and if you have any comments/suggestions/criticisms I'd be happy to re-visit them before I mark this bug resolved.

Issue History

Date Modified Username Field Change
2009-11-24 22:16 user372 New Issue
2009-11-24 22:16 user372 Status new => assigned
2009-11-24 22:16 user372 Assigned To => tpartner
2009-11-24 22:17 user372 Description Updated
2009-11-27 14:05 tpartner File Added: progress_v1.gif
2009-11-27 14:11 tpartner Note Added: 10288
2009-11-27 15:13 user372 Note Added: 10290
2009-11-27 15:36 tpartner Note Added: 10291
2009-11-27 19:12 c_schmitz Note Added: 10293
2009-11-27 19:47 tpartner Note Added: 10294
2009-11-29 19:51 tpartner Note Added: 10309
2009-11-30 00:01 user372 Target Version 1.87RC3 => 1.87RC5
2009-11-30 01:28 c_schmitz Note Added: 10318
2009-11-30 13:19 tpartner Note Added: 10348
2009-12-04 00:15 user372 Note Added: 10437
2009-12-04 22:28 tpartner Note Added: 10467
2009-12-05 00:08 tpartner Note Added: 10469
2009-12-07 22:40 tpartner Status assigned => resolved
2009-12-07 22:40 tpartner Resolution open => fixed
2009-12-11 12:17 c_schmitz Status resolved => closed
2015-12-11 14:40 c_schmitz Category Templates => Theme editor