View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 03687 | Bug reports | Survey participants (Tokens) | public | 2009-09-15 22:12 | 2009-09-22 00:58 |
| Reporter | Assigned To | lemeur | |||
| Priority | normal | Severity | partial_block | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 1.85+ | ||||
| Fixed in Version | 1.85+ | ||||
| Summary | 03687: LDAP import of names with apostrophes fails | ||||
| Description | The import of tokens from an LDAP server fails silently when the result set contains a name with an apostrophe (like O'Reilly). | ||||
| Additional Information | The code in tokens.php does not properly quote firstname, lastname and email address when assembling the MySQL query to check for duplicates. | ||||
| Tags | No tags attached. | ||||
| Attached Files | tokens.patch.txt (1,089 bytes)
--- admin/tokens.php.old 2009-09-15 16:39:25.000000000 +0200
+++ admin/tokens.php 2009-09-15 16:43:43.000000000 +0200
@@ -2457,7 +2457,7 @@
$invalidemail=false;
if ($filterduplicatetoken)
{
- $dupquery = "SELECT firstname, lastname from ".db_table_name("tokens_$surveyid")." where email='$myemail' and firstname='$myfirstname' and lastname='$mylastname'";
+ $dupquery = "SELECT firstname, lastname from ".db_table_name("tokens_$surveyid")." where email=".db_quoteall($myemail)." and firstname=".db_quoteall($myfirstname)." and lastname=".db_quoteall($mylastname)."";
$dupresult = $connect->Execute($dupquery);
if ( $dupresult->RecordCount() > 0)
{
| ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 7460 | ||||
| I will donate to the project if issue is resolved | |||||
| Browser | Mozilla | ||||
| Database type & version | MySQL | ||||
| Server OS (if known) | Linux FC4 | ||||
| Webserver software & version (if known) | Apache 2.0 | ||||
| PHP Version | 5.0.4 | ||||
| Git branch / Pull Request URL | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-09-15 22:12 |
|
New Issue | |
| 2009-09-15 22:12 |
|
Status | new => assigned |
| 2009-09-15 22:12 |
|
Assigned To | => user372 |
| 2009-09-15 22:12 |
|
File Added: tokens.patch.txt | |
| 2009-09-15 22:12 |
|
Build Number | => 7460 |
| 2009-09-15 22:12 |
|
Browser | => Mozilla |
| 2009-09-15 22:12 |
|
Database & DB-Version | => MySQL |
| 2009-09-15 22:12 |
|
Operating System (Server) | => Linux FC4 |
| 2009-09-15 22:12 |
|
Webserver | => Apache 2.0 |
| 2009-09-15 22:12 |
|
PHP Version | => 5.0.4 |
| 2009-09-15 22:13 |
|
Issue Monitored: user4911 | |
| 2009-09-16 08:47 |
|
Assigned To | user372 => lemeur |
| 2009-09-16 08:48 |
|
Note Added: 09572 | |
| 2009-09-19 17:59 | lemeur | Note Added: 09606 | |
| 2009-09-19 17:59 | lemeur | Status | assigned => resolved |
| 2009-09-19 17:59 | lemeur | Fixed in Version | => 1.85+ |
| 2009-09-19 17:59 | lemeur | Resolution | open => fixed |
| 2009-09-22 00:58 | c_schmitz | Status | resolved => closed |
| 2016-12-08 10:39 | c_schmitz | Category | Tokens => Survey participants (Tokens) |