https://github.com/LimeSurvey/LimeSurvey/pull/4440

Just save emailstatus ?

A comment about the encryption mechanism.

This is what happened here:

• Record was fetched (attributes were encrypted)
• A non-expected-encrypted attribute was correctly set
• Record was attempted to be saved
• Validation failed for the encrypted attributes: As the data to be validated was encrypted, didn't fit the validation rules which expected non-encrypted data.

I think the whole mechanism is a bit fragile.
It is very for a dev to fall into an error and not encrypt/decrypt properly, or save the whole record (insted of just a few fields).
Also, it is very easy to make data corrupt if double encrypting by accident.

So, I would suggest to add some warning validations to flag these kind of situations:

• Add Control Flags to know the current encryption/decryption status (probably per attribute)
• Add a Warning when validating data which is encrypted and shouldn't.
• Add a Warning when saving without encrypting whereas should be encrypted.
• Add a Warning when doing EncryptSave and the data is already encrypted.

@DenisChenu @tibor.pacalat

We already have a PR to move whole save and validation to encrypt system, model care of all of this. I don't do it a second time

https://github.com/LimeSurvey/LimeSurvey/pull/3596

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=39093

Fixed in Release 6.15.17+251013