20117: Better error return in get_site_settings - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

20117	Bug reports	RemoteControl	public	2025-05-22 11:58	2025-06-26 17:45

Reporter	DenisChenu	Assigned To	DenisChenu
Priority	none	Severity	minor
Status	closed	Resolution	fixed

Summary	20117: Better error return in get_site_settings
Description	When user didn't have access to Global settings and ask for a specific setting get `Invalid setting` in status. Must be 'No permisson"
Steps To Reproduce	Steps to reproduce See https://github.com/edgarrmondragon/citric/issues/1377 Expected result return `{"status":"No permission"}` Or `You are not allowed to read the site settings` Actual result return `{"status":"Invalid setting"}`
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	6.14.0
I will donate to the project if issue is resolved	No
Browser	not relevant
Database type & version	not relevant
Server OS (if known)	not relevant
Webserver software & version (if known)	not relevant
PHP Version	not relevant

User List	chimp358

tibor.pacalat 2025-05-23 13:28 administrator ~82741	Confirmed, please fix it :)

DenisChenu 2025-05-23 16:51 developer ~82751	You are not allowed to read the site settings or No permission ? Unsure here

tibor.pacalat 2025-05-26 15:24 administrator ~82763	I think for every situation where user is missing permissions, we should use the same wording. It should be "No permission".

DenisChenu 2025-06-23 17:52 developer ~82932	https://github.com/LimeSurvey/LimeSurvey/pull/4330

DenisChenu 2025-06-26 16:06 developer ~82980	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=38956

LimeBot 2025-06-26 17:45 administrator ~82992	Fixed in Release 6.15.1+250626

Date Modified	Username	Field	Change
2025-05-22 11:58	DenisChenu	New Issue
2025-05-22 17:32	chimp358	Issue Monitored: chimp358
2025-05-22 17:32	chimp358	Bug heat	0 => 2
2025-05-23 13:28	tibor.pacalat	Note Added: 82741
2025-05-23 13:28	tibor.pacalat	Bug heat	2 => 4
2025-05-23 13:29	tibor.pacalat	Assigned To	=> DenisChenu
2025-05-23 13:29	tibor.pacalat	Status	new => assigned
2025-05-23 16:51	DenisChenu	Note Added: 82751
2025-05-23 16:51	DenisChenu	Bug heat	4 => 6
2025-05-26 15:24	tibor.pacalat	Note Added: 82763
2025-06-23 17:51	DenisChenu	Assigned To	DenisChenu => gabrieljenik
2025-06-23 17:51	DenisChenu	Status	assigned => ready for code review
2025-06-23 17:52	DenisChenu	Note Added: 82932
2025-06-23 21:58	gabrieljenik	Assigned To	gabrieljenik => tibor.pacalat
2025-06-23 21:58	gabrieljenik	Status	ready for code review => ready for testing
2025-06-26 16:06	DenisChenu	Changeset attached	=> LimeSurvey master e425d37a
2025-06-26 16:06	DenisChenu	Note Added: 82980
2025-06-26 16:06	DenisChenu	Assigned To	tibor.pacalat => DenisChenu
2025-06-26 16:06	DenisChenu	Status	ready for testing => resolved
2025-06-26 16:06	DenisChenu	Resolution	open => fixed
2025-06-26 17:45	LimeBot	Note Added: 82992
2025-06-26 17:45	LimeBot	Status	resolved => closed
2025-06-26 17:45	LimeBot	Bug heat	6 => 8

LimeSurvey: master e425d37a 2025-06-26 16:06 DenisChenu Committer: GitHub Details Diff	Fixed issue 20117: Better error return in get_site_settings (04330)		Affected Issues 20117
	mod - application/helpers/remotecontrol/remotecontrol_handle.php		Diff File