|
|
Real result
$ php8.2 application/commands/console.php plugin index --target=checkCommandUrl
http://application/commands/console.php?r=survey/index&surveyid=123
http://application/commands/console.php?r=optout/tokens&surveyid=&token=abcd
https://example.org/console.php?r=survey/index&sid=489424&lang=en
$ php8.2 application/commands/console.php plugin index --target=checkCommandUrlSetHost
http://limesurtvey.example.com/subdirectory?r=survey/index&surveyid=123
http://limesurtvey.example.com/subdirectory?r=optout/tokens&surveyid=123&token=abcd
https://example.orghttp://limesurtvey.example.com/subdirectory?r=survey/index&sid=489424&lang=en
I don't have opinion if checkCommandUrlSetHost must use publicurl or not.
For checkCommandUrl : broken without error_reporting(0);
PHP Error[2]: Undefined array key "SERVER_NAME"
Must be avoided too |
|
|
|
We have App()->createPublicUrl() for that. Have you tried it? |
|
|
|
Maybe but createAbsoluteUrl still broken |
|
|
|
createAbsoluteUrl is std for Yii.
I believe it is not aware of publicurl (which is something LS related). |
|
|
|
I believe it is not aware of publicurl (which is something LS related).
It work in 3.X (and in 5.0) |
|
|
|
Was not able to get the expected behaviour neither on 3.x or 5.x
Tried:
5.6.58
5.6.24
3.28.77
3.10.0
I understand you talk about this was working before.
Still, I wasn't able to get those plugins to work as expected in any of those versions.
From what we have analyzed those plugins end up calling the Yii std version of createAbsoluteUrl.
The regular controllers have a method createAbsoluteUrl that end up calling createPublicUrl.
That's the one that I suggest to use.
So far, not sure how else I can help.
Sorry. |
|
|
|
3.27
$ php application/commands/console.php plugin index --target=checkCommandUrlSetHost
http://limesurtvey.example.com/subdirectory/?r=survey/index&surveyid=123
http://limesurtvey.example.com/subdirectory/?r=optout/tokens&surveyid=123&token=abcd
Error: Call to undefined function dateShift() in /media/shnoulle/data/webdev/ls3/application/models/Survey.php:443
Stack trace:
#0 /media/shnoulle/data/webdev/ls3/framework/db/ar/CActiveRecord.php(222): Survey->scopes()
#1 /media/shnoulle/data/webdev/ls3/plugins/checkCommandUrlSetHost/checkCommandUrlSetHost.php(44): CActiveRecord->__call()
#2 [internal function]: checkCommandUrlSetHost->directCli()
#3 /media/shnoulle/data/webdev/ls3/application/libraries/PluginManager/PluginManager.php(185): call_user_func()
#4 /media/shnoulle/data/webdev/ls3/application/commands/PluginCommand.php(45): LimeSurvey\PluginManager\PluginManager->dispatchEvent()
#5 [internal function]: PluginCommand->actionIndex()
#6 /media/shnoulle/data/webdev/ls3/framework/console/CConsoleCommand.php(178): ReflectionMethod->invokeArgs()
#7 /media/shnoulle/data/webdev/ls3/framework/console/CConsoleCommandRunner.php(71): CConsoleCommand->run()
#8 /media/shnoulle/data/webdev/ls3/framework/console/CConsoleApplication.php(92): CConsoleCommandRunner->run()
#9 /media/shnoulle/data/webdev/ls3/framework/base/CApplication.php(185): CConsoleApplication->processRequest()
#10 /media/shnoulle/data/webdev/ls3/application/commands/console.php(70): CApplication->run()
With or without publicurl set
I use since years with https://gitlab.com/SondagesPro/mailing/sendMailCron |
|
|
|
5.6
shnoulle@Belgarion:/media/shnoulle/data/webdev/ls5$ php application/commands/console.php plugin index --target=checkCommandUrlSetHost
http://limesurtvey.example.com/subdirectory?r=survey/index&surveyid=123
http://limesurtvey.example.com/subdirectory?r=optout/tokens&surveyid=123&token=abcd
http://limesurtvey.example.com/subdirectory?r=survey/index&sid=998872&lang=en
With 3 and 5 : checkCommandUrl never work but checkCommandUrlSetHost work.
Now checkCommandUrl and checkCommandUrlSetHost broke.
At minima : checkCommandUrlSetHost must work like it was in 3 and 5. And it's better if checkCommandUrl work. |
|
|
|
The biggest issue are
$ php8.2 application/commands/console.php plugin index --target=checkCommandUrlSetHost
https://example.orghttp://limesurtvey.example.com/subdirectory?r=survey/index&sid=489424&lang=en
|
|
