|
|
This is CKEditor or it should be filtered by the html purifier? |
|
|
|
Both, I think.
Ideally CKEditor would not allow drag'n'drop conversion and on save it also should be filtered. |
|
|
|
https://github.com/LimeSurvey/LimeSurvey/pull/4065
This part is for not allowing saving.
We have tried to use html purifier, but were not able to set it as to "allow all but images with data src".
Hence, sued a reg exp. The approach can be enhanced if needed, but as for starters and solving the current situation, think it is worth it.
The frontend part think is better to tackle it after implementing ckeditor 5. |
|
|
|
About CKEditor : https://stackoverflow.com/a/23101048/2239406
Seems there are only workarounds currently |
|
|
|
https://github.com/LimeSurvey/LimeSurvey/pull/4065
This part is for not allowing saving.
I managed to save it when creating a question, but what this does is filters the content, src attribute it not there.
So this should kind of solve the issue short term, but there is no warning about why this works like that etc. so user can only see that no image has been shown in the survey - bad UX. |
|
|
|
I managed to save it when creating a question, but what this does is filters the content,
Correct. I am sorry. It allows save. It just filters out the data/image source attribute.
FYI. This is already being filtered for non-superadmins.
So the new behavior is just for super-admins.
So this should kind of solve the issue short term, but there is no warning about why this works like that etc. so user can only see that no image has been shown in the survey - bad UX.
Agree. Need to work on the CKEditor. Will include it when upgrading to v5 |
|
|
|
Ok, I have merged the PR in to prevent survey slowness. |
|
|
|
Fixed in Release 6.8.2+241203 |
|
