PS : i really don't understand all this code … https://github.com/LimeSurvey/LimeSurvey/blob/78a2949a70c0f98bb53882ccfd21a7faa27501ca/application/models/SurveysGroupsettings.php#L311

We end by survey : https://github.com/LimeSurvey/LimeSurvey/blob/78a2949a70c0f98bb53882ccfd21a7faa27501ca/application/models/SurveysGroupsettings.php#L362

But we need to start by survey, and not end by …
Why we don't have such issue before ?

@tibor.pacalat : my solution here is a big rewrite of the system.

I'm still unsure on the desired behavior …

Opinion:

Survey->datestamp must return Y/N or I
Survey->otions->datestamp must return only Y/N

?

@gabrieljenik : do you have an opinion here ?

Plugin can need to read if settings are inherited or not

In Survey settings part OK for

• Survey->datestamp must return (Y|N|I)
• Survey->options->datestamp must return only (Y|N) (only get parent if Survey->datestamp == "I")
• Survey->getIsDateStamp must use options->datestamp

In Survey and all other controller : Survey->datestamp = Survey->options->datestamp

Survey->datestamp must return (Y|N|I)

Agree. That is the survey data field.

Survey->options->datestamp must return only (Y|N) (only get parent if Survey->datestamp == "I")

I guess you talk about oOptions.
Agree. This is the value from the survey merged with the one inherited from the survey group hirearchy.
The value inheritance decision is executed here I think (from quick search) SurveysGroupsettings::shouldInherit()

Survey->getIsDateStamp must use options->datestamp

Agree.

In Survey and all other controller : Survey->datestamp = Survey->options->datestamp

Not sure I follow that statement.
datestamp and options->datestamp shouldn't be accessed much from outside Survey model.

Still, if the datestamp is Inherited, could end up Survey->datestamp <> Survey->options->datestamp

In Survey and all other controller : Survey->datestamp = Survey->options->datestamp

Not sure I follow that statement.
datestamp and options->datestamp shouldn't be accessed much from outside Survey model.

It's the current situation : when you check Survey->datestamp in beforeSurveyPage or newExport for example : you get Survey->oOptions->datestamp . Updating this : we broke a lot of plugins !
Then : i's for don't update this situation.

Only update for beforeSurveySettings and newSurveySettings (seems the only situation where we have this issue) or when controller are SurveyAdministrationController

The upadte was here : https://github.com/LimeSurvey/LimeSurvey/blob/ec5825c1ce2c5d953b1f634e2e57e837c9df2c12/application/controllers/SurveyAdministrationController.php#L1923

From what I read, I think the issue could be in 2 places maybe:

1) Inheritance Mechanism in SurveysGroupsettings::getInstance

2) The line you commented (https://github.com/LimeSurvey/LimeSurvey/blob/ec5825c1ce2c5d953b1f634e2e57e837c9df2c12/application/controllers/SurveyAdministrationController.php#L1923) maybe fecthing the instance from the cache and then setting the options for the instance in the cache, whereas in other places options should be set from inheritance.

Will debug and be back

Inheritance Mechanism in SurveysGroupsettings::getInstance

This one is very strange ....