View Issue Details

This issue affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
19747Bug reportsSurvey takingpublic2026-09-22 18:33
Reportergabrieljenik Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Product Version6.6.x 
Summary19747: Sometimes the theme configuration hirearchy loading is not correct
Description

Sometimes when loading the the theme configuration hirearchy, if a theme configuration is missing for the surveyGroup, the woraround creates chaos.

I understand that getInstanceFromSurveyGroup should return an instance of the configuration associated with a survey group, while getInstanceFromTemplateName should return a “generic” instance.

When there is no specific configuration for a surveygroup, the code takes what getInstanceFromTemplateName returns (a general instance for the template) and modifies the instance, which is cached.

By not making a clone, what it ends up doing is modifying the cached instance, modifying not only for the surveygroup (as intended) but for the instance for the template.

So, when you call getInstanceFromTemplateName again, it returns something that is not what is supposed to be returned.

Steps To Reproduce

Steps to reproduce

Hard to reproduce. Need to keep on working on it.

Expected result

Get a specifc instance for the survey group.

Actual result

Update the instance used for the base template configuracion

TagsNo tags attached.
Attached Files
image.png (122,113 bytes)
Bug heat6
Complete LimeSurvey version number (& build)6.x
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version8

Relationships

related to 19685 closedgabrieljenik php8.3 compatibility - LS Core 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2024-09-12 15:44

manager   ~80997

Found when reviewing 19685

DenisChenu

DenisChenu

2024-09-12 16:30

developer   ~81002

Yep, all this code are really complex…
Same for all inheritance …

c_schmitz

c_schmitz

2026-09-15 17:54

administrator   ~85763

https://github.com/LimeSurvey/LimeSurvey/pull/5308

c_schmitz

c_schmitz

2026-09-22 18:33

administrator   ~85935

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=40523

Related Changesets

LimeSurvey: master 0bad9822

2026-09-22 18:33

c_schmitz

Committer: GitHub


Details Diff
Fixed issue 19747: Theme configuration hierarchy loading is not correct (05308) Affected Issues
19747
mod - application/models/TemplateConfiguration.php Diff File

Issue History

Date Modified Username Field Change
2024-09-12 15:43 gabrieljenik New Issue
2024-09-12 15:43 gabrieljenik File Added: image.png
2024-09-12 15:44 gabrieljenik Relationship added related to 19685
2024-09-12 15:44 gabrieljenik Note Added: 80997
2024-09-12 15:44 gabrieljenik Bug heat 0 => 2
2024-09-12 16:29 DenisChenu Relationship added child of 19632
2024-09-12 16:29 DenisChenu Relationship deleted child of 19632
2024-09-12 16:30 DenisChenu Note Added: 81002
2024-09-12 16:30 DenisChenu Bug heat 2 => 4
2026-09-15 17:53 c_schmitz Assigned To => c_schmitz
2026-09-15 17:53 c_schmitz Status new => assigned
2026-09-15 17:54 c_schmitz Note Added: 85763
2026-09-15 17:54 c_schmitz Bug heat 4 => 6
2026-09-15 17:54 c_schmitz Status assigned => ready for code review
2026-09-18 00:59 gabrieljenik Assigned To c_schmitz => TonisOrmisson
2026-09-18 00:59 gabrieljenik Status ready for code review => ready for testing
2026-09-18 01:00 gabrieljenik Assigned To TonisOrmisson => tibor.pacalat
2026-09-22 18:33 c_schmitz Changeset attached => LimeSurvey master 0bad9822
2026-09-22 18:33 c_schmitz Note Added: 85935
2026-09-22 18:33 c_schmitz Assigned To tibor.pacalat => c_schmitz
2026-09-22 18:33 c_schmitz Status ready for testing => resolved
2026-09-22 18:33 c_schmitz Resolution open => fixed