https://github.com/LimeSurvey/LimeSurvey/pull/3942

Update broken theme

I believe the theme should be updated, but not on this ticket but on a DEV environment.

• Avoid backward incompatibility with question themes already developed
• Avoid unexpected situations from a structural change in the question theme

Avoid backward incompatibility with question themes already developed

I don't understand ? You mean someone who copy this theme to create another one ? What backwrd compatibility ?

The theme is broken then, fix the theme !

Avoid unexpected situations from a structural change in the question theme

But you update core to avoid update a single theme ???

You mean someone who copy this theme to create another one ? What backwrd compatibility ?

Yes... Maybe "backward incompatibility" is not the best term :) But, yes, pointing to that situation.

But you update core to avoid update a single theme ???

From my perspective, the impact and risk of the current patch is smaller than updating the theme.

If you prefer, we can ask someone (as to have a third opinion) or if you feel like, do you want to grab this ticket...?

Yes, third opinion.

With a good reason because we don't want input.my_item, .mybroken-theme-item .tag finally.

@c_schmitz thoughts?

With a good reason because we don't want input.my_item, .mybroken-theme-item .tag finally.

This is for the bootstrap buttons theme.
The current fix is not expected to grow with every custom theme.

The current fix is not expected to grow with every custom theme.

Why ? You update core because THIS theme is broken. Then why not another fix after ?

See : https://manual.limesurvey.org/Theme_editor#Global_classes_for_question_part

The current fix is not expected to grow with every custom theme.

Why ?

Becaise we don't support custom themes.

Becaise we don't support custom themes.

OK, then we don't care with

Avoid backward incompatibility with question themes already developed
Avoid unexpected situations from a structural change in the question theme

The button theme is broken : fix the theme.

Avoid backward incompatibility with question themes already developed

One thing is not provide support for custom themes... another one is don't consider them :)

Avoid unexpected situations from a structural change in the question theme

This is in relation to the Bootstrap Buttons theme.

I will wait for Carsten to reply back.

@c_schmitz

Remind : https://www.limesurvey.org/manual/Theme_editor#Global_classes_for_question_part

.answer-item : The answer part: one answer
.question-item : The question part: one question

It can be (and must be) .answer-item .text-item or .answer-item .button-item or .answer-item .myowntype-item

I understand that the theme is wrong. I agree.
Still, if we update it and someone has extended the theme, we wouldn´t be helping that person.

Is that ok?

This has already been fixed.