View Issue Details

This bug affects 2 person(s).
 12
IDProjectCategoryView StatusLast Update
19692Bug reportsOtherpublic2024-09-18 17:04
Reportertibor.pacalat Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionwon't fix 
Product Version6.6.x 
Summary19692: php8.3 compatibility - Pear
Description

Main ticket https://bugs.limesurvey.org/view.php?id=19632

Pear
FILE: /var/www/html/limesurvey/vendor/pear/pear-core-minimal/src/PEAR.php

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)6.6.1+240806
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Relationships

child of 19632 closedgabrieljenik Make Limesurvey compatible with php8.3 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-09-11 12:54

developer   ~80957

@tibor.pacalat , seem @gabrieljenik already start to work on this. Why not assign it to Gabriel ?

tibor.pacalat

tibor.pacalat

2024-09-12 10:21

administrator   ~80977

Where do you see this? If you mean general ticket, then the answer is, I tried to split the sub-tickets between you two.

DenisChenu

DenisChenu

2024-09-12 10:41

developer   ~80979

Where do you see this? If you mean general ticket, then the answer is, I tried to split the sub-tickets between you two.

Yes, in the general tickets :)

I take some (and if i doin't found way ;: i discuss with Gabriel)

DenisChenu

DenisChenu

2024-09-12 11:08

developer   ~80980

/master/vendor/pear$ find . -name \*.php -exec php8.3 -l {} \;
No syntax errors detected in ./pear-core-minimal/src/System.php
No syntax errors detected in ./pear-core-minimal/src/OS/Guess.php
No syntax errors detected in ./pear-core-minimal/src/PEAR.php
No syntax errors detected in ./pear-core-minimal/src/PEAR/ErrorStack.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer/Validator.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer/Worksheet.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer/Parser.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer/BIFFwriter.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer/Workbook.php
No syntax errors detected in ./spreadsheet_excel_writer/Spreadsheet/Excel/Writer/Format.php
No syntax errors detected in ./spreadsheet_excel_writer/test/Test/Spreadsheet/Excel/Writer/WorkbookTest.php
No syntax errors detected in ./spreadsheet_excel_writer/test/Test/Spreadsheet/Excel/WriterTestCase.php
No syntax errors detected in ./ole/OLE/PPS.php
No syntax errors detected in ./ole/OLE/ChainedBlockStream.php
No syntax errors detected in ./ole/OLE/PPS/File.php
No syntax errors detected in ./ole/OLE/PPS/Root.php
No syntax errors detected in ./ole/OLE.php
No syntax errors detected in ./pear_exception/PEAR/Exception.php
No syntax errors detected in ./console_getopt/Console/Getopt.php

???

DenisChenu

DenisChenu

2024-09-12 11:26

developer   ~80986

See https://github.com/PHPCompatibility/PHPCompatibility/issues/796

gabrieljenik

gabrieljenik

2024-09-12 15:28

manager   ~80994

So you mean this has nothing to be updated?

DenisChenu

DenisChenu

2024-09-12 16:39

developer   ~81003

Unsure , …

But i don't see why it can broke something here : https://github.com/LimeSurvey/LimeSurvey/blob/89a3800356a2e94cfb459f0a595cb382f4adb3e8/vendor/pear/pear-core-minimal/src/PEAR.php#L888

See the error log :

898 | ERROR | Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The
| | parameter "$mode" was changed on line 888.

We don't really care of $mode in traceback here.

DenisChenu

DenisChenu

2024-09-12 16:40

developer   ~81004

(I prefer 2 eyes to set it as not needed/false positive)

gabrieljenik

gabrieljenik

2024-09-12 18:23

manager   ~81007

Last edited: 2024-09-12 18:28

I think we can live with the new output backtrace() provides.
So, yes, false postive for me. More like a warning than an error

tibor.pacalat

tibor.pacalat

2024-09-18 15:37

administrator   ~81042

Ok, should I close this one?

gabrieljenik

gabrieljenik

2024-09-18 15:55

manager   ~81047

I think you can close it. If we found an issue when testing, we will re open it.

Issue History

Date Modified Username Field Change
2024-08-08 14:16 tibor.pacalat New Issue
2024-09-11 12:33 tibor.pacalat Assigned To => DenisChenu
2024-09-11 12:33 tibor.pacalat Status new => assigned
2024-09-11 12:54 DenisChenu Note Added: 80957
2024-09-11 12:54 DenisChenu Bug heat 0 => 2
2024-09-12 10:21 tibor.pacalat Note Added: 80977
2024-09-12 10:21 tibor.pacalat Bug heat 2 => 4
2024-09-12 10:41 DenisChenu Note Added: 80979
2024-09-12 11:08 DenisChenu Note Added: 80980
2024-09-12 11:08 DenisChenu Assigned To DenisChenu => gabrieljenik
2024-09-12 11:08 DenisChenu Status assigned => acknowledged
2024-09-12 11:25 DenisChenu Relationship added child of 19632
2024-09-12 11:26 DenisChenu Note Added: 80986
2024-09-12 14:56 guest Bug heat 4 => 10
2024-09-12 15:28 gabrieljenik Note Added: 80994
2024-09-12 15:28 gabrieljenik Bug heat 10 => 12
2024-09-12 16:39 DenisChenu Note Added: 81003
2024-09-12 16:40 DenisChenu Note Added: 81004
2024-09-12 18:23 gabrieljenik Note Added: 81007
2024-09-12 18:28 gabrieljenik Note Edited: 81007
2024-09-18 15:37 tibor.pacalat Note Added: 81042
2024-09-18 15:55 gabrieljenik Note Added: 81047
2024-09-18 17:04 tibor.pacalat Status acknowledged => closed
2024-09-18 17:04 tibor.pacalat Resolution open => won't fix