View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19617 | Bug reports | RemoteControl | public | 2024-06-18 08:25 | 2024-09-23 17:29 |
Reporter | bpresentati | Assigned To | DenisChenu | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 6.5.x | ||||
Summary | 19617: get_question_properties Return Array Doesn't Have "question" field - you can't see what the question is | ||||
Description | Hello, To help visualize what I mean, I'm including screenshots of the return array for "get_question_properties" from LS 3.22 and 6.5.4. I am not attaching an LSS since this is not relegated to a specific survey. | ||||
Steps To Reproduce | Steps to reproducemake call to the Remote Control API get_question_properties Expected resultreturn array has field "question" that contains question text Actual resultreturn array has basically everything but the question field | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 14 | ||||
Complete LimeSurvey version number (& build) | 6.5.4+240422 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Google Chrome Version 126.0.6478.62 (Official Build) (64-bit) | ||||
Database type & version | Note sure | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | Not sure | ||||
3 to 6 : MAJOR version when you make incompatible API changes see https://semver.org/ Then : Not an issue (just to confirm) |
|
I could not find the question text in the attributes_lang. |
|
Then need a solution : i10n/lang array ? |
|
I understand that the API may be broken between versions. But wouldn't it be possible to provide a user friendly and backwards compatible fix by adjusting the 6.x API code so we get the required "question" details from the now different table(s)? |
|
Yes, i start to work on it, i think i just send question, help and script without extra array. |
|
https://github.com/LimeSurvey/LimeSurvey/pull/3949 Doing both |
|
|
|
Looks great! |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36546 |
|
Tested and merged. |
|
Fixed in Release 6.6.4+240923 |
|
LimeSurvey: master c8df4cb3 2024-09-11 12:12 Committer: GitHub Details Diff |
Fixed issue 19617: No way to get question text in get_question_properties (#3949) |
Affected Issues 19617 |
|
mod - application/helpers/remotecontrol/remotecontrol_handle.php | Diff File | ||
add - tests/unit/helpers/remotecontrol/CheckQuestionPropertiesTest.php | Diff File | ||
mod - tests/unit/helpers/remotecontrol/RemoteControlQuestionPropertiesTest.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-06-18 08:25 | bpresentati | New Issue | |
2024-06-18 08:25 | bpresentati | File Added: LS6_get_question_properties.png | |
2024-06-18 08:25 | bpresentati | File Added: LS3_get_question_properties.png | |
2024-06-18 08:44 | DenisChenu | Note Added: 80381 | |
2024-06-18 08:44 | DenisChenu | Bug heat | 0 => 2 |
2024-06-18 08:45 | DenisChenu | Assigned To | => tibor.pacalat |
2024-06-18 08:45 | DenisChenu | Status | new => feedback |
2024-06-18 08:45 | DenisChenu | Note Edited: 80381 | |
2024-06-24 18:12 | tibor.pacalat | Note Added: 80450 | |
2024-06-24 18:12 | tibor.pacalat | File Added: Screenshot 2024-06-24 at 18.10.59.png | |
2024-06-24 18:12 | tibor.pacalat | Bug heat | 2 => 4 |
2024-06-26 15:48 | tibor.pacalat | Assigned To | tibor.pacalat => DenisChenu |
2024-07-24 08:28 | DenisChenu | Status | feedback => assigned |
2024-07-24 08:28 | DenisChenu | Note Added: 80703 | |
2024-08-28 11:52 | Mazi | Note Added: 80843 | |
2024-08-28 11:52 | Mazi | Bug heat | 4 => 12 |
2024-08-28 15:54 | DenisChenu | Note Added: 80848 | |
2024-08-28 17:45 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2024-08-28 17:45 | DenisChenu | Status | assigned => ready for code review |
2024-08-28 17:45 | DenisChenu | Note Added: 80851 | |
2024-08-28 17:46 | DenisChenu | Note Added: 80852 | |
2024-08-28 17:46 | DenisChenu | File Added: Capture d’écran du 2024-08-28 17-45-54.png | |
2024-08-29 08:53 | Mazi | Note Added: 80854 | |
2024-09-03 17:19 | gabrieljenik | Assigned To | gabrieljenik => tibor.pacalat |
2024-09-03 17:19 | gabrieljenik | Status | ready for code review => ready for testing |
2024-09-11 10:13 | DenisChenu | Changeset attached | => LimeSurvey master c8df4cb3 |
2024-09-11 10:13 | DenisChenu | Note Added: 80951 | |
2024-09-11 10:13 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2024-09-11 10:13 | DenisChenu | Resolution | open => fixed |
2024-09-11 10:13 | tibor.pacalat | Status | ready for testing => resolved |
2024-09-11 10:13 | tibor.pacalat | Note Added: 80952 | |
2024-09-23 17:29 | LimeBot | Note Added: 81100 | |
2024-09-23 17:29 | LimeBot | Status | resolved => closed |
2024-09-23 17:29 | LimeBot | Bug heat | 12 => 14 |