View Issue Details

This bug affects 2 person(s).
 14
IDProjectCategoryView StatusLast Update
19617Bug reportsRemoteControlpublic2024-09-23 17:29
Reporterbpresentati Assigned ToDenisChenu  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version6.5.x 
Summary19617: get_question_properties Return Array Doesn't Have "question" field - you can't see what the question is
Description

Hello,
Longtime user of the Remote Control API on Limesurvey 3.22.28+200728 , now we've migrated to 6.5.4+240422 and I've noticed some things do not behave the same. Most importantly, the get_question_properties API call no longer returns a "question" field - with the question text in it. Is there still a way to access the "question" property like in the older LS version? Am I missing something?

To help visualize what I mean, I'm including screenshots of the return array for "get_question_properties" from LS 3.22 and 6.5.4. I am not attaching an LSS since this is not relegated to a specific survey.

Steps To Reproduce

Steps to reproduce

make call to the Remote Control API get_question_properties

Expected result

return array has field "question" that contains question text

Actual result

return array has basically everything but the question field

TagsNo tags attached.
Attached Files
LS6_get_question_properties.png (35,013 bytes)   
LS6_get_question_properties.png (35,013 bytes)   
LS3_get_question_properties.png (36,698 bytes)   
LS3_get_question_properties.png (36,698 bytes)   
Bug heat14
Complete LimeSurvey version number (& build)6.5.4+240422
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome Version 126.0.6478.62 (Official Build) (64-bit)
Database type & versionNote sure
Server OS (if known)
Webserver software & version (if known)
PHP VersionNot sure

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-06-18 08:44

developer   ~80381

Last edited: 2024-06-18 08:45

3 to 6 : MAJOR version when you make incompatible API changes see https://semver.org/
Language part are inside attributs_lang

Then : Not an issue

(just to confirm)

tibor.pacalat

tibor.pacalat

2024-06-24 18:12

administrator   ~80450

I could not find the question text in the attributes_lang.

DenisChenu

DenisChenu

2024-07-24 08:28

developer   ~80703

Then need a solution : i10n/lang array ?

Mazi

Mazi

2024-08-28 11:52

updater   ~80843

I understand that the API may be broken between versions. But wouldn't it be possible to provide a user friendly and backwards compatible fix by adjusting the 6.x API code so we get the required "question" details from the now different table(s)?
That way old API code will still work.

DenisChenu

DenisChenu

2024-08-28 15:54

developer   ~80848

Yes, i start to work on it, i think i just send question, help and script without extra array.

DenisChenu

DenisChenu

2024-08-28 17:45

developer   ~80851

https://github.com/LimeSurvey/LimeSurvey/pull/3949

Doing both

DenisChenu

DenisChenu

2024-08-28 17:46

developer   ~80852

Mazi

Mazi

2024-08-29 08:53

updater   ~80854

Looks great!

DenisChenu

DenisChenu

2024-09-11 10:13

developer   ~80951

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36546

tibor.pacalat

tibor.pacalat

2024-09-11 10:13

administrator   ~80952

Tested and merged.

LimeBot

LimeBot

2024-09-23 17:29

administrator   ~81100

Fixed in Release 6.6.4+240923

Related Changesets

LimeSurvey: master c8df4cb3

2024-09-11 12:12

DenisChenu

Committer: GitHub


Details Diff
Fixed issue 19617: No way to get question text in get_question_properties (#3949) Affected Issues
19617
mod - application/helpers/remotecontrol/remotecontrol_handle.php Diff File
add - tests/unit/helpers/remotecontrol/CheckQuestionPropertiesTest.php Diff File
mod - tests/unit/helpers/remotecontrol/RemoteControlQuestionPropertiesTest.php Diff File

Issue History

Date Modified Username Field Change
2024-06-18 08:25 bpresentati New Issue
2024-06-18 08:25 bpresentati File Added: LS6_get_question_properties.png
2024-06-18 08:25 bpresentati File Added: LS3_get_question_properties.png
2024-06-18 08:44 DenisChenu Note Added: 80381
2024-06-18 08:44 DenisChenu Bug heat 0 => 2
2024-06-18 08:45 DenisChenu Assigned To => tibor.pacalat
2024-06-18 08:45 DenisChenu Status new => feedback
2024-06-18 08:45 DenisChenu Note Edited: 80381
2024-06-24 18:12 tibor.pacalat Note Added: 80450
2024-06-24 18:12 tibor.pacalat File Added: Screenshot 2024-06-24 at 18.10.59.png
2024-06-24 18:12 tibor.pacalat Bug heat 2 => 4
2024-06-26 15:48 tibor.pacalat Assigned To tibor.pacalat => DenisChenu
2024-07-24 08:28 DenisChenu Status feedback => assigned
2024-07-24 08:28 DenisChenu Note Added: 80703
2024-08-28 11:52 Mazi Note Added: 80843
2024-08-28 11:52 Mazi Bug heat 4 => 12
2024-08-28 15:54 DenisChenu Note Added: 80848
2024-08-28 17:45 DenisChenu Assigned To DenisChenu => gabrieljenik
2024-08-28 17:45 DenisChenu Status assigned => ready for code review
2024-08-28 17:45 DenisChenu Note Added: 80851
2024-08-28 17:46 DenisChenu Note Added: 80852
2024-08-28 17:46 DenisChenu File Added: Capture d’écran du 2024-08-28 17-45-54.png
2024-08-29 08:53 Mazi Note Added: 80854
2024-09-03 17:19 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2024-09-03 17:19 gabrieljenik Status ready for code review => ready for testing
2024-09-11 10:13 DenisChenu Changeset attached => LimeSurvey master c8df4cb3
2024-09-11 10:13 DenisChenu Note Added: 80951
2024-09-11 10:13 DenisChenu Assigned To tibor.pacalat => DenisChenu
2024-09-11 10:13 DenisChenu Resolution open => fixed
2024-09-11 10:13 tibor.pacalat Status ready for testing => resolved
2024-09-11 10:13 tibor.pacalat Note Added: 80952
2024-09-23 17:29 LimeBot Note Added: 81100
2024-09-23 17:29 LimeBot Status resolved => closed
2024-09-23 17:29 LimeBot Bug heat 12 => 14