tested :

    public function getRelated($name, $refresh=false, $params=array()) {
        if ($name == 'survey' && !$refresh && empty($params)) {
            return Survey::model()->findByPk($this->sid);
        }
        return parent::getRelated($name, $refresh,$params);
    }

Seems to wok

If you have a chance, it would be interesting to know what would be the query result with my suggested PR to reduce reasonably the calling of survey finds

https://github.com/LimeSurvey/LimeSurvey/pull/3819/files

I tend to be a bit skeptical about overriding the framework logic. If you have a general knowledge about how the framework works and there is one model where you have overridden it, it might cause problems later in other places.

For me it seems more logical to start from fixing bad code and assess the situation after fixing obvious code inefficiency issues. A good example of what I mean is this
https://github.com/LimeSurvey/LimeSurvey/pull/3819/files#diff-af8e690b7162e715acc4d95c2dd74fb97479066cf40a03d33de4c393df0250e3L1563 (image)

having a survey find in such a loops can possibly explode these queries. Maybe fixing inefficient code will cut most of the queries so that it will not be that big of an issue any more to fix?

image.png (81,097 bytes)   

image.png (81,097 bytes)   

I tend to be a bit skeptical about overriding the framework logic. If you have a general knowledge about how the framework works and there is one model where you have overridden it, it might cause problems later in other places.

I check the framework logic before.

Else “ remove duplicate survey-find-by-pk ” is unrelated since Survey::model()->findByPk($surveyId); use static variable , then same number of DB call.

@TonisOrmisson

I confirm Survey::model()->findByPk($this->sid) don't throw again the event : since it use a static variable

Without public function getRelated($name, $refresh=false, $params=array()) { : 63 event
With 2 event

(on public page : demo survey)

This lower the number of event afterFindSurey too : 2 times on public survey, 63 por more time before (using debug and previous plugin)

Let's discuss

afterFindSurey event

questionAdministration/view&surveyid=282267&gid=4&qid=22

without the fix : 6 times
with the fix : 3 times

Logixc file

without the fix : 4 times
with the fix : 3 times

Really better on public part (happen for each question multiple times)

3 times for admin part seems a constant

I traced this event being mostly triggered from here:
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/QuestionAttribute.php#L258

Maybe inject languages as a dependency here, the db queries will be gone then, most of them

Both can be interesting : https://github.com/LimeSurvey/LimeSurvey/pull/3871

(I test it with one of my client)

I assign to Carsten maybe ?

2 solution currently :

1. Review to use findByPkCache fpr question (like 3.X) : 1 (or 2/3) calls by page
2. Improve other part to minimize request (maybe 10 by page, but need to improve Events too in my opinion)

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36510

Fixed in Release 6.6.1+240806