View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19584 | Bug reports | Other | public | 2024-06-05 23:57 | 2025-03-27 09:40 |
Reporter | mfavetti | Assigned To | p_teichmann | ||
Priority | none | Severity | minor | ||
Status | ready for code review | Resolution | open | ||
Product Version | 6.5.x | ||||
Summary | 19584: .gitignore file incorrectly includes node_modules/jquery/dist | ||||
Description |
This line attempts to include node_modules/jquery/dist, but node_modules itself is excluded. So, node_modules/jquery must be included as well from the gitignore docs at https://git-scm.com/docs/gitignore "It is not possible to re-include a file if a parent directory of that file is excluded." | ||||
Steps To Reproduce | unzip limesurvey6.5.11+240605.zip examine added files, jquery/dist is missing | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 6.5.11 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | N/A | ||||
Database type & version | N/A | ||||
Server OS (if known) | N/A | ||||
Webserver software & version (if known) | N/A | ||||
PHP Version | N/A | ||||
Hey, you are right, in general we want to get away from committing node_module folders into the repository. |
|
Yes, it can be interesting |
|
" we want to get away from committing node_module folders into the repository." Then how do you deploy files that are needed for the repository? |
|
FYI: the reason this is a huge problem is for when one wants to build containers direclty from a specific source. At any rate, the fix is simply removing the errant .gitignore line. [code]
diff --git a/limesurvey/.gitignore b/limesurvey/.gitignore #ignore most of the js-build stuff |
|
OK, the above patch left out details due to magical formatting of this platform. But it should be clear that the fix is simple |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2024-06-05 23:57 | mfavetti | New Issue | |
2024-06-06 00:02 | mfavetti | Steps to Reproduce Updated | |
2024-06-06 00:06 | mfavetti | Steps to Reproduce Updated | |
2024-06-06 00:55 | mfavetti | Assigned To | => mfavetti |
2024-06-06 00:55 | mfavetti | Status | new => assigned |
2024-06-06 00:55 | mfavetti | Assigned To | mfavetti => DenisChenu |
2024-06-06 00:55 | mfavetti | Status | assigned => ready for code review |
2024-06-06 10:56 | p_teichmann | Note Added: 80224 | |
2024-06-06 10:56 | p_teichmann | Bug heat | 0 => 2 |
2024-06-06 11:00 | DenisChenu | Note Added: 80225 | |
2024-06-06 11:00 | DenisChenu | Bug heat | 2 => 4 |
2024-06-06 11:31 | DenisChenu | Assigned To | DenisChenu => p_teichmann |
2025-03-27 09:30 | uibklime1 | Note Added: 82332 | |
2025-03-27 09:30 | uibklime1 | Bug heat | 4 => 6 |
2025-03-27 09:39 | uibklime1 | Note Added: 82333 | |
2025-03-27 09:40 | uibklime1 | Note Added: 82334 |