View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
19584Bug reportsOtherpublic2024-06-05 23:572024-06-06 11:31
Reportermfavetti Assigned Top_teichmann  
PrioritynoneSeverityminor 
Status ready for code reviewResolutionopen 
Product Version6.5.x 
Summary19584: .gitignore file incorrectly includes node_modules/jquery/dist
Description

https://github.com/LimeSurvey/LimeSurvey/blob/a681a80e8036fe18d79731b5fbded44a77edaf66/.gitignore#L88

This line attempts to include node_modules/jquery/dist, but node_modules itself is excluded.

So, node_modules/jquery must be included as well

from the gitignore docs at https://git-scm.com/docs/gitignore

"It is not possible to re-include a file if a parent directory of that file is excluded."

Steps To Reproduce

unzip limesurvey6.5.11+240605.zip
cd limesurvey
git init .
curl https://raw.githubusercontent.com/LimeSurvey/LimeSurvey/master/.gitignore > .gitignore
git add .
git status node_modules/jquery*

examine added files, jquery/dist is missing

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)6.5.11
I will donate to the project if issue is resolvedNo
BrowserN/A
Database type & versionN/A
Server OS (if known)N/A
Webserver software & version (if known)N/A
PHP VersionN/A

Users monitoring this issue

There are no users monitoring this issue.

Activities

p_teichmann

p_teichmann

2024-06-06 10:56

administrator   ~80224

Hey, you are right, in general we want to get away from committing node_module folders into the repository.
Please let me know where the file was needed to be included and was causing an issue.
Maybe it can be removed as well from git inclusion.
DenisChenu

DenisChenu

2024-06-06 11:00

developer   ~80225

Maybe it can be removed as well from git inclusion.

Yes, it can be interesting

Issue History

Date Modified Username Field Change
2024-06-05 23:57 mfavetti New Issue
2024-06-06 00:02 mfavetti Steps to Reproduce Updated
2024-06-06 00:06 mfavetti Steps to Reproduce Updated
2024-06-06 00:55 mfavetti Assigned To => mfavetti
2024-06-06 00:55 mfavetti Status new => assigned
2024-06-06 00:55 mfavetti Assigned To mfavetti => DenisChenu
2024-06-06 00:55 mfavetti Status assigned => ready for code review
2024-06-06 10:56 p_teichmann Note Added: 80224
2024-06-06 10:56 p_teichmann Bug heat 0 => 2
2024-06-06 11:00 DenisChenu Note Added: 80225
2024-06-06 11:00 DenisChenu Bug heat 2 => 4
2024-06-06 11:31 DenisChenu Assigned To DenisChenu => p_teichmann