View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19580 | Bug reports | Data Entry (non public) | public | 2024-06-04 15:48 | 2024-06-11 16:41 |
Reporter | Mazi | Assigned To | DenisChenu | ||
Priority | none | Severity | crash | ||
Status | closed | Resolution | fixed | ||
Product Version | 6.5.x | ||||
Summary | 19580: Data entry at anonymous survey with tokens crashed on save | ||||
Description | When using the data entry at latest 5.x and 6.x version at an anonymous survey using tokens the action crashes on save. Error: | ||||
Steps To Reproduce | Steps to reproduce
Expected resultData should get saved. Actual resultCrash on save | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 6.5.10 and 5.6.65 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL | ||||
Server OS (if known) | Ubuntu 20 | ||||
Webserver software & version (if known) | Apache 2.0 | ||||
PHP Version | 8.0 | ||||
@tibor.pacalat: This is a blocker for one of our customers. Can you look into this and assign it? Should be easy to reproduce. |
|
@Mazi, I am sorry, but yesterday was the last release of LS5. |
|
@tibor.pacalat: We also have https://bugs.limesurvey.org/view.php?id=19527 pending to be integrated at a follow up 5.x release. Fixing this one doesn't seem too difficult... Please bear in mind that many, many customers are still at 5.x e.g. it takes them a few more months to set up a new machine with latest PHP 8.x to switch to version 6. Furthermore, many of them need to adjust custom themes for the switch. |
|
@DenisChenu can you fix this real quick please? |
|
Friday maybe ? |
|
Merci beaucoup, @DenisChenu! |
|
I say Friday ! (tomorrow ;)) |
|
@Mazi : i think we can allow invalid token here too ? Doing both : set completed if exist, no update if not exist. |
|
I really don't understand the logic of this code … It sounds awfully complicated for a simple thing. Currently it seems all edit/update action is disable with anonymous surey … |
|
@DenisChenu RE "i think we can allow invalid token here too ?" -> I agree, since not token is written into the response table. We just need to make sure the token status (completed) gets updated correctly if the token exists. |
|
Yes about the token status PS : you can do anything importing VV file ;) |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36392 |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36391 |
|
Tested and merged. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36393 |
|
Fixed in Release 5.6.67+240612 |
|
LimeSurvey: 5.x 28544585 2024-06-07 14:52 Committer: GitHub Details Diff |
Fixed issue 19580: Data entry at anonymous survey with tokens crashed on save (#3872) |
Affected Issues 19580 |
|
mod - application/controllers/admin/DataEntry.php | Diff File | ||
LimeSurvey: 5.x 28544585 2024-06-07 14:52 Committer: GitHub Details Diff |
Fixed issue 19580: Data entry at anonymous survey with tokens crashed on save (#3872) |
Affected Issues 19580 |
|
mod - application/controllers/admin/DataEntry.php | Diff File | ||
LimeSurvey: master b5b02246 2024-06-07 14:53 Committer: GitHub Details Diff |
Fixed issue 19580: Data entry at anonymous survey with tokens crashed on save (03873) |
Affected Issues 19580 |
|
mod - application/controllers/admin/DataEntry.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-06-04 15:48 | Mazi | New Issue | |
2024-06-04 15:48 | Mazi | File Added: survey_archive_678121-Anonymous data entry.lsa | |
2024-06-05 10:18 | Mazi | Note Added: 80210 | |
2024-06-05 10:18 | Mazi | Bug heat | 0 => 2 |
2024-06-05 11:40 | tibor.pacalat | Note Added: 80211 | |
2024-06-05 11:40 | tibor.pacalat | Bug heat | 2 => 4 |
2024-06-05 11:57 | Mazi | Note Added: 80212 | |
2024-06-05 13:38 | tibor.pacalat | Note Added: 80213 | |
2024-06-05 15:32 | DenisChenu | Note Added: 80214 | |
2024-06-05 15:32 | DenisChenu | Bug heat | 4 => 6 |
2024-06-06 10:23 | Mazi | Note Added: 80222 | |
2024-06-06 11:58 | DenisChenu | Note Added: 80228 | |
2024-06-07 10:06 | DenisChenu | Assigned To | => DenisChenu |
2024-06-07 10:06 | DenisChenu | Status | new => assigned |
2024-06-07 10:12 | DenisChenu | Note Added: 80247 | |
2024-06-07 10:24 | DenisChenu | Note Added: 80248 | |
2024-06-07 10:33 | Mazi | Note Added: 80249 | |
2024-06-07 10:41 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2024-06-07 10:41 | DenisChenu | Status | assigned => ready for code review |
2024-06-07 10:41 | DenisChenu | Note Added: 80250 | |
2024-06-07 11:26 | DenisChenu | Note Added: 80251 | |
2024-06-07 11:30 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2024-06-07 11:34 | DenisChenu | Note Added: 80252 | |
2024-06-07 11:34 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2024-06-07 12:52 | DenisChenu | Changeset attached | => LimeSurvey 5.x 28544585 |
2024-06-07 12:52 | DenisChenu | Changeset attached | => LimeSurvey 5.x 28544585 |
2024-06-07 12:52 | DenisChenu | Note Added: 80257 | |
2024-06-07 12:52 | DenisChenu | Note Added: 80258 | |
2024-06-07 12:52 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2024-06-07 12:52 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2024-06-07 12:52 | DenisChenu | Resolution | open => fixed |
2024-06-07 12:52 | DenisChenu | Resolution | open => fixed |
2024-06-07 12:53 | tibor.pacalat | Status | ready for code review => resolved |
2024-06-07 12:53 | tibor.pacalat | Note Added: 80259 | |
2024-06-07 13:06 | DenisChenu | Changeset attached | => LimeSurvey master b5b02246 |
2024-06-07 13:06 | DenisChenu | Note Added: 80260 | |
2024-06-11 16:41 | LimeBot | Note Added: 80272 | |
2024-06-11 16:41 | LimeBot | Status | resolved => closed |
2024-06-11 16:41 | LimeBot | Bug heat | 6 => 8 |