View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19519 | Bug reports | Survey participants (Tokens) | public | 2024-04-16 11:41 | 2024-09-23 17:29 |
Reporter | Mazi | Assigned To | gabrieljenik | ||
Priority | none | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 6.5.x | ||||
Summary | 19519: When re-activating a token based survey the user is not asked to re-active the token table | ||||
Description | Previously, when re-activating a survey which had tokens assigned, you were asked if the token table should be re-activated as well. At the current 6.x version this check seems to be missing so you can accidentally run a closed survey as an open survey. | ||||
Steps To Reproduce | Steps to reproduceSet up a survey with tokens. Expected resultOn re-activation one was previously asked if the old token table should be restored. This is missing, you now only deactivate and there is no hint about the token table. Actual resultAsk the user to also re-activate the token table. | ||||
Tags | No tags attached. | ||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | 6.4.11 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MySQL | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 8.1 | ||||
@DenisChenu, do you know if this is the new expected behavior or do you consider this to be a regression? |
|
No strong opinion on this one. |
|
It works differently at LS3 and LS5 so I consider this a regression. |
|
Maybe best solutuion :
|
|
@DenisChenu: Makes sense |
|
In previous versions, after activating the survey, it took you to a screen that said the survey had been activated, and asked if you wanted to keep it open or closed. If you clicked “closed,” it suggested you restore the old table. Now it asks you the question BEFORE activating. How should the behavior be? On the other hand, it is difficult to test the operation properly because the restore of the token tables does not work. And it does not work because the archiving is wrong. Should we create a new ticket for this? |
|
@gabrieljenik, thanks a lot for thiss helpful summary. To my knowledge it was possible at the old versions to select from a list of previously deactivated token tables. Are you saying that due to the bug, only the latest one is now available? Then that surely is another issue. |
|
No, I am saying there are 2 issues. Screenflow has changedAs the screenflow has changed, probably it the reativate screen got missed. BugThere is a bug when deactivating that will probably end up in only allowing the most recent version to be restored. |
|
https://github.com/LimeSurvey/LimeSurvey/pull/3943 Not to much inlove with the way DI is being used here, actually, we may get rid of it. |
|
Same ! :+1: |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36547 |
|
Tested and merged. |
|
Reopening this as it is failing for 8.3. https://github.com/LimeSurvey/LimeSurvey/pull/3963 Also fixed a wrong "tbl_name" value. |
|
Fixed in Release 6.6.4+240923 |
|
LimeSurvey: master 17e2265e 2024-09-11 14:21:58 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 19519: When re-activating a token based survey the user is not asked to re-active the token table (03943) * Fixed issue 19519: When re-activating a token based survey the user is not asked to re-active the token table - Fix creation of archived table settings records * Fixed issue 19519: When re-activating a token based survey the user is not asked to re-active the token table - Fix token table restore when there are no attributes * Fixed issue 19519: When re-activating a token based survey the user is not asked to re-active the token table - Fix creation of token archive table settings when there are custom attributes --------- Co-authored-by: lapiudevgit <devgit@lapiu.biz> |
Affected Issues 19519 |
|
mod - application/controllers/admin/Tokens.php | Diff File | ||
mod - application/libraries/DI.php | Diff File | ||
mod - application/models/services/SurveyDeactivate.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-04-16 11:41 | Mazi | New Issue | |
2024-04-16 11:41 | Mazi | Note Added: 79923 | |
2024-04-16 11:41 | Mazi | Bug heat | 0 => 2 |
2024-04-16 14:44 | DenisChenu | Note Added: 79934 | |
2024-04-16 14:44 | DenisChenu | Bug heat | 2 => 4 |
2024-04-16 16:30 | Mazi | Note Added: 79935 | |
2024-07-16 16:43 | tibor.pacalat | Assigned To | => gabrieljenik |
2024-07-16 16:43 | tibor.pacalat | Status | new => assigned |
2024-07-16 17:09 | DenisChenu | Note Added: 80634 | |
2024-07-17 19:35 | Mazi | Note Added: 80652 | |
2024-08-14 20:46 | gabrieljenik | Note Added: 80765 | |
2024-08-14 20:46 | gabrieljenik | Bug heat | 4 => 6 |
2024-08-15 08:59 | Mazi | Note Added: 80766 | |
2024-08-17 15:52 | gabrieljenik | Note Added: 80773 | |
2024-08-28 15:49 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2024-08-28 15:49 | gabrieljenik | Status | assigned => ready for code review |
2024-08-28 15:49 | gabrieljenik | Note Added: 80846 | |
2024-08-28 15:56 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2024-08-28 15:56 | DenisChenu | Status | ready for code review => ready for testing |
2024-08-28 15:57 | DenisChenu | Note Added: 80849 | |
2024-09-11 14:22 | Changeset attached | => LimeSurvey master 17e2265e | |
2024-09-11 14:22 | guest | Note Added: 80958 | |
2024-09-11 14:22 | guest | Bug heat | 6 => 8 |
2024-09-11 14:22 | tibor.pacalat | Status | ready for testing => resolved |
2024-09-11 14:22 | tibor.pacalat | Resolution | open => fixed |
2024-09-11 14:22 | tibor.pacalat | Note Added: 80959 | |
2024-09-11 14:22 | tibor.pacalat | Bug heat | 8 => 10 |
2024-09-13 22:28 | gabrieljenik | Assigned To | tibor.pacalat => gabrieljenik |
2024-09-13 22:28 | gabrieljenik | Status | resolved => assigned |
2024-09-13 22:28 | gabrieljenik | Note Added: 81024 | |
2024-09-23 17:29 | LimeBot | Note Added: 81102 | |
2024-09-23 17:29 | LimeBot | Status | assigned => closed |
2024-09-23 17:29 | LimeBot | Bug heat | 10 => 12 |