@DenisChenu, do you know if this is the new expected behavior or do you consider this to be a regression?

No strong opinion on this one.

It works differently at LS3 and LS5 so I consider this a regression.

Maybe best solutuion :

• No old token table : do like current 6.X
• Old token table exist : redirect to token activation showing old token table

@DenisChenu: Makes sense

In previous versions, after activating the survey, it took you to a screen that said the survey had been activated, and asked if you wanted to keep it open or closed. If you clicked “closed,” it suggested you restore the old table.

Now it asks you the question BEFORE activating.

How should the behavior be?

On the other hand, it is difficult to test the operation properly because the restore of the token tables does not work. And it does not work because the archiving is wrong.
The problem is that when deactivating a survey, some tables are archived (token, responses and timings). For each table that is archived, an ArchivedTableSettings record must be saved, but it does it 3 times by overriding the record, instead of inserting new records.

Should we create a new ticket for this?

@gabrieljenik, thanks a lot for thiss helpful summary. To my knowledge it was possible at the old versions to select from a list of previously deactivated token tables. Are you saying that due to the bug, only the latest one is now available? Then that surely is another issue.

No, I am saying there are 2 issues.

Screenflow has changed

As the screenflow has changed, probably it the reativate screen got missed.

Bug

There is a bug when deactivating that will probably end up in only allowing the most recent version to be restored.

https://github.com/LimeSurvey/LimeSurvey/pull/3943

Not to much inlove with the way DI is being used here, actually, we may get rid of it.
But as it was already being used, preferred to keep consistency

Not to much inlove with the way DI is being used here, actually, we may get rid of it.
But as it was already being used, preferred to keep consistency

Same ! :+1:

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36547

Tested and merged.

Reopening this as it is failing for 8.3.
I know (8.3 is not being tested here), but still, that made us think we needed a better solution as now probably something is off but unseen.

https://github.com/LimeSurvey/LimeSurvey/pull/3963

Also fixed a wrong "tbl_name" value.
(see attach)

Fixed in Release 6.6.4+240923