View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
19501Bug reportsComfortUpdatepublic2024-05-15 08:54
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status feedbackResolutionopen 
Summary19501: Upgrade broke at 430 with ComfortUpdateChecker
Description

When update from 3 to 5 : it broke at 430 step due to ComfortUpdateChecker key

Steps To Reproduce

Steps to reproduce

Upgrade from 3 to 5

Expected result

Upgrade without error

Actual result

Break at step 430

Additional Information

master : https://github.com/LimeSurvey/LimeSurvey/pull/3804
5X : https://github.com/LimeSurvey/LimeSurvey/pull/3803

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)5.6.57
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2024-03-27 16:42

developer   ~79841

Plugin was already added at 424 : https://github.com/LimeSurvey/LimeSurvey/blob/c16d1df55a68853c3c9c4f15d9640d6799b050b0/application/helpers/update/updates/Update_424.php#L45

tibor.pacalat

tibor.pacalat

2024-05-14 16:41

administrator   ~80104

Hey @DenisChenu, I tried t reproduce the issue and tried to make Comfort Update from 3.28.77+231213 to 5.6.63+240508 and didn't encounter any issues.
At that point db version was 499. Am I trying to reproduce this issue in a wrong way?

DenisChenu

DenisChenu

2024-05-14 17:14

developer   ~80106

I have the issue when updating from 3.28.56

Maybe something related to mariaDB ?

If you look at code

My test was on MSSQL, but it muts happen too for mariadb,
EXCEPT it don't break because plugins ->name are not uinique in database …

Seems worst : can you check if you have it 2 times in the database ?

DenisChenu

DenisChenu

2024-05-14 17:19

developer   ~80107

Seems it was added too on 3.X
https://github.com/LimeSurvey/LimeSurvey/blob/18bac625f52375f33dff8376e4254e9dff6781bd/application/helpers/update/updatedb_helper.php#L2533

We add it 3 times ?

DenisChenu

DenisChenu

2024-05-14 17:21

developer   ~80108

OK, i understand why i have the error : SQL team advised me to add an index on the name. I added it as a unique …

Then : we have ComfortUpdateChecker plugins 2 times without this index

DenisChenu

DenisChenu

2024-05-14 17:24

developer   ~80109

https://gitlab.com/SondagesPro/coreAndTools/DbIndexManage

@tibor.pacalat did i move it to new again about multiple ComfortUpdateChecker plugin, and create a DEV report about indexing (as unique or not) plugins->name ?

tibor.pacalat

tibor.pacalat

2024-05-14 17:40

administrator   ~80110

Yeah, if the summary of this ticket is not describing the issue correctly, please close it and create a new one, or just change the summary and description of the ticket.

DenisChenu

DenisChenu

2024-05-15 08:54

developer   ~80111

OK :)

I close it after and create a new one.

Sorry …

Issue History

Date Modified Username Field Change
2024-03-27 16:41 DenisChenu New Issue
2024-03-27 16:42 DenisChenu Note Added: 79841
2024-03-27 16:42 DenisChenu Bug heat 0 => 2
2024-04-01 11:00 DenisChenu Assigned To => DenisChenu
2024-04-01 11:00 DenisChenu Status new => assigned
2024-04-02 16:53 DenisChenu Additional Information Updated
2024-04-02 16:53 DenisChenu Assigned To DenisChenu =>
2024-04-02 16:53 DenisChenu Status assigned => ready for code review
2024-05-08 15:30 tibor.pacalat Assigned To => tibor.pacalat
2024-05-08 15:30 tibor.pacalat Status ready for code review => ready for testing
2024-05-14 16:41 tibor.pacalat Note Added: 80104
2024-05-14 16:41 tibor.pacalat Bug heat 2 => 4
2024-05-14 17:14 DenisChenu Note Added: 80106
2024-05-14 17:19 DenisChenu Note Added: 80107
2024-05-14 17:21 DenisChenu Note Added: 80108
2024-05-14 17:24 DenisChenu Note Added: 80109
2024-05-14 17:40 tibor.pacalat Note Added: 80110
2024-05-15 08:54 DenisChenu Note Added: 80111
2024-05-15 08:54 DenisChenu Status ready for testing => feedback
2024-05-15 08:54 DenisChenu Assigned To tibor.pacalat => DenisChenu