View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19501 | Bug reports | ComfortUpdate | public | 2024-03-27 16:41 | 2024-06-10 14:43 |
Reporter | DenisChenu | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Summary | 19501: Upgrade broke at 430 with ComfortUpdateChecker | ||||
Description | When update from 3 to 5 : it broke at 430 step due to ComfortUpdateChecker key | ||||
Steps To Reproduce | Steps to reproduceUpgrade from 3 to 5 Expected resultUpgrade without error Actual resultBreak at step 430 | ||||
Additional Information | master : https://github.com/LimeSurvey/LimeSurvey/pull/3804 | ||||
Tags | No tags attached. | ||||
Bug heat | 4 | ||||
Complete LimeSurvey version number (& build) | 5.6.57 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 19596 | new | When upgrade from 3.X with ComfortUpdateChecker disable : ComfortUpdateChecker reenable |
Plugin was already added at 424 : https://github.com/LimeSurvey/LimeSurvey/blob/c16d1df55a68853c3c9c4f15d9640d6799b050b0/application/helpers/update/updates/Update_424.php#L45 |
|
Hey @DenisChenu, I tried t reproduce the issue and tried to make Comfort Update from 3.28.77+231213 to 5.6.63+240508 and didn't encounter any issues. |
|
I have the issue when updating from 3.28.56 Maybe something related to mariaDB ? If you look at code
My test was on MSSQL, but it muts happen too for mariadb, Seems worst : can you check if you have it 2 times in the database ? |
|
Seems it was added too on 3.X We add it 3 times ? |
|
OK, i understand why i have the error : SQL team advised me to add an index on the name. I added it as a unique … Then : we have ComfortUpdateChecker plugins 2 times without this index |
|
https://gitlab.com/SondagesPro/coreAndTools/DbIndexManage @tibor.pacalat did i move it to new again about multiple ComfortUpdateChecker plugin, and create a DEV report about indexing (as unique or not) plugins->name ? |
|
Yeah, if the summary of this ticket is not describing the issue correctly, please close it and create a new one, or just change the summary and description of the ticket. |
|
OK :) I close it after and create a new one. Sorry … |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36394 |
|
Replaced by https://bugs.limesurvey.org/view.php?id=19596 |
|
No change required, better issue reported |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2024-03-27 16:41 | DenisChenu | New Issue | |
2024-03-27 16:42 | DenisChenu | Note Added: 79841 | |
2024-03-27 16:42 | DenisChenu | Bug heat | 0 => 2 |
2024-04-01 11:00 | DenisChenu | Assigned To | => DenisChenu |
2024-04-01 11:00 | DenisChenu | Status | new => assigned |
2024-04-02 16:53 | DenisChenu | Additional Information Updated | |
2024-04-02 16:53 | DenisChenu | Assigned To | DenisChenu => |
2024-04-02 16:53 | DenisChenu | Status | assigned => ready for code review |
2024-05-08 15:30 | tibor.pacalat | Assigned To | => tibor.pacalat |
2024-05-08 15:30 | tibor.pacalat | Status | ready for code review => ready for testing |
2024-05-14 16:41 | tibor.pacalat | Note Added: 80104 | |
2024-05-14 16:41 | tibor.pacalat | Bug heat | 2 => 4 |
2024-05-14 17:14 | DenisChenu | Note Added: 80106 | |
2024-05-14 17:19 | DenisChenu | Note Added: 80107 | |
2024-05-14 17:21 | DenisChenu | Note Added: 80108 | |
2024-05-14 17:24 | DenisChenu | Note Added: 80109 | |
2024-05-14 17:40 | tibor.pacalat | Note Added: 80110 | |
2024-05-15 08:54 | DenisChenu | Note Added: 80111 | |
2024-05-15 08:54 | DenisChenu | Status | ready for testing => feedback |
2024-05-15 08:54 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2024-06-07 13:26 | DenisChenu | Changeset attached | => LimeSurvey 5.x 21403de8 |
2024-06-07 13:26 | DenisChenu | Note Added: 80262 | |
2024-06-07 13:26 | DenisChenu | Resolution | open => fixed |
2024-06-10 14:42 | DenisChenu | Relationship added | related to 19596 |
2024-06-10 14:43 | DenisChenu | Note Added: 80268 | |
2024-06-10 14:43 | DenisChenu | Status | feedback => closed |
2024-06-10 14:43 | DenisChenu | Note Added: 80269 |