View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
19408Bug reportsSurvey editingpublic2024-02-12 10:282024-04-15 11:16
ReporterMazi Assigned Totibor.pacalat  
PrioritynoneSeverityblock 
Status closedResolutionfixed 
Product Version6.4.x 
Summary19408: Users can activate a survey without grouops and questions
Description

At latest 6.x you can activate a survey which has no groups and questions. When starting the survey there is a note about this. But the core problem is that the button to deactivate the survey is then missing. You can only delete it.

Steps To Reproduce

Steps to reproduce

Create a new, empty survey and activate it.

Expected result

Activation should not be possible if there are no groups/questions.
One should also be able to de-activate.

Actual result

The survey can be activated.
Deactivation button is missing.

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)6.4.5
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMariaDB 10.1.48
Server OS (if known)
Webserver software & version (if known)
PHP Version8.1

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2024-02-27 14:58

updater   ~79662

@galads, can we assign this one?
New users may stumble upon this and there is no way to get back to a deactivated survey, you will lose all your survey details.
gabrieljenik

gabrieljenik

2024-04-09 00:57

manager   ~79885

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3808
gabrieljenik

gabrieljenik

2024-04-09 01:05

manager   ~79886

I would also recommend another ticket to have the survey activator to have its own checking bfore activating.
DenisChenu

DenisChenu

2024-04-09 09:14

developer   ~79887

I would also recommend another ticket to have the survey activator to have its own checking bfore activating.

I think it must be in this ticket, checking is done in 3.X before activate.
DenisChenu

DenisChenu

2024-04-09 09:14

developer   ~79888

New users may stumble upon this and there is no way to get back to a deactivated survey, you will lose all your survey details.

Workaround : export lss, delete, import lss.
guest

guest

2024-04-12 16:18

viewer   ~79910

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36251
guest

guest

2024-04-12 16:18

viewer   ~79911

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36252
tibor.pacalat

tibor.pacalat

2024-04-12 16:18

administrator   ~79912

Tested and merged.
LimeBot

LimeBot

2024-04-15 11:16

administrator   ~79921

Fixed in Release 6.5.3+240415

Related Changesets

LimeSurvey: master a1c67f95

2024-04-12 18:18

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 19408: Users can activate a survey without grouops and questions (03808)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
19408
mod - application/controllers/SurveyAdministrationController.php Diff File
mod - application/core/TopbarConfiguration.php Diff File
mod - application/views/surveyAdministration/partial/topbar/surveyTopbarLeft_view.php Diff File
mod - application/views/surveyAdministration/surveyActivation/_activateSurveyCheckFailed.php Diff File

LimeSurvey: master a1c67f95

2024-04-12 18:18

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 19408: Users can activate a survey without grouops and questions (03808)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
19408
mod - application/controllers/SurveyAdministrationController.php Diff File
mod - application/core/TopbarConfiguration.php Diff File
mod - application/views/surveyAdministration/partial/topbar/surveyTopbarLeft_view.php Diff File
mod - application/views/surveyAdministration/surveyActivation/_activateSurveyCheckFailed.php Diff File

Issue History

Date Modified Username Field Change
2024-02-12 10:28 Mazi New Issue
2024-02-27 14:58 Mazi Note Added: 79662
2024-02-27 14:58 Mazi Bug heat 0 => 2
2024-03-21 15:23 tibor.pacalat Assigned To => gabrieljenik
2024-03-21 15:23 tibor.pacalat Status new => assigned
2024-04-09 00:57 gabrieljenik Assigned To gabrieljenik => DenisChenu
2024-04-09 00:57 gabrieljenik Status assigned => ready for code review
2024-04-09 00:57 gabrieljenik Note Added: 79885
2024-04-09 00:57 gabrieljenik Bug heat 2 => 4
2024-04-09 01:05 gabrieljenik Note Added: 79886
2024-04-09 09:14 DenisChenu Note Added: 79887
2024-04-09 09:14 DenisChenu Bug heat 4 => 6
2024-04-09 09:14 DenisChenu Note Added: 79888
2024-04-12 16:11 gabrieljenik Assigned To DenisChenu => tibor.pacalat
2024-04-12 16:11 gabrieljenik Status ready for code review => ready for testing
2024-04-12 16:18 Changeset attached => LimeSurvey master a1c67f95
2024-04-12 16:18 Changeset attached => LimeSurvey master a1c67f95
2024-04-12 16:18 guest Note Added: 79910
2024-04-12 16:18 guest Note Added: 79911
2024-04-12 16:18 guest Bug heat 6 => 8
2024-04-12 16:18 guest Bug heat 6 => 8
2024-04-12 16:18 tibor.pacalat Status ready for testing => resolved
2024-04-12 16:18 tibor.pacalat Resolution open => fixed
2024-04-12 16:18 tibor.pacalat Note Added: 79912
2024-04-12 16:18 tibor.pacalat Bug heat 8 => 10
2024-04-15 11:16 LimeBot Note Added: 79921
2024-04-15 11:16 LimeBot Status resolved => closed
2024-04-15 11:16 LimeBot Bug heat 10 => 12