View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
19365Bug reportsErgonomypublic2024-01-29 14:15
ReporterDenisChenu Assigned To 
PrioritynoneSeverityminor 
Status assignedResolutionopen 
Product Version6.4.x 
Summary19365: Incomprehensible message when an error occurs in the general parameters.
Description

Incomprehensible message when an error occurs in the general parameters.

In 5.X : we have the error shown, not in 6

Steps To Reproduce

Steps to reproduce

Go to General settings, enter Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed quis velit tincidunt nisi tempor fusce. for admin name
Save

Expected result

Saved or error about size of Admin name shown (check 5.X)

Actual result

Incomprehensible message

TagsNo tags attached.
Attached Files
error-5X.png (12,959 bytes)   
error-5X.png (12,959 bytes)   
error-6X.png (8,029 bytes)   
error-6X.png (8,029 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)6.4.1
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 19364 closedDenisChenu Stored Cross-Site Scripting 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2024-01-19 10:35

administrator   ~79230

test

tibor.pacalat

tibor.pacalat

2024-01-19 10:52

administrator   ~79231

What is incomprehensible here?

I agree that the message should be better worded. For example:

"Admin name is too long (maximum 50 characters are allowed)"

tibor.pacalat

tibor.pacalat

2024-01-19 10:53

administrator   ~79233

@DenisChenu can you clarify how you would change this error notification?

DenisChenu

DenisChenu

2024-01-19 11:07

developer   ~79234

Adding the error return by save()

"Admin name is too long (maximum 50 characters are allowed)" for admin
"Admin email must be a valid email"

etc …

Using https://www.yiiframework.com/doc/api/1.1/CHtml#errorSummary-detail ?

DenisChenu

DenisChenu

2024-01-19 11:11

developer   ~79235

errorSummary use

  1. rules : https://github.com/LimeSurvey/LimeSurvey/blob/6a578fb773c2397aa58e3034f8c0fb6e2bcc5e44/application/models/Survey.php#L480
  2. labels https://github.com/LimeSurvey/LimeSurvey/blob/5.X/application/models/Survey.php#L220 (or name of attribute)
DenisChenu

DenisChenu

2024-01-19 11:18

developer   ~79237

What is incomprehensible here?

What error we have : in 6.X : we check email too : you can have error on admin name AND./OR admin email.

Ergonomy :

  1. Be clear on error when an error happen (explain)
  2. Shown a lot of error with a link to the error (i don't ask it …)
  3. If possible don't validate a form i there are error (Yii can do it with activeField (or we can add it manually here))

I juts ask 1 : no less ergonomie than 5.X : be better, but not worse

tibor.pacalat

tibor.pacalat

2024-01-19 12:25

administrator   ~79242

I read it wrong from your description "In 5.X : we have the issue, not in 6".

So I thought the issue/bug is in 5.x. All good, I understand now.

DenisChenu

DenisChenu

2024-01-19 14:55

developer   ~79246

Oh roght !

I mean
In 5.X : we have the error shown, not in 6

saimson1

saimson1

2024-01-22 05:25

reporter   ~79255

It's not just an error message guy's it's proper Stored XSS, if you think it is not make the original reported issue as public.
Instead of fixing the issue you're just playing around, Let me know if i can share poc's to prevent the user's from this bug.

saimson1

saimson1

2024-01-22 05:29

reporter   ~79256

Kindly mark this issue as public please.

https://bugs.limesurvey.org/view.php?id=19364

DenisChenu

DenisChenu

2024-01-22 08:32

developer   ~79258

Kindly mark this issue as public please.

No problem : IT'S ALREADY FIXED

Issue History

Date Modified Username Field Change
2024-01-19 10:26 DenisChenu New Issue
2024-01-19 10:26 DenisChenu File Added: error-5X.png
2024-01-19 10:26 DenisChenu File Added: error-6X.png
2024-01-19 10:27 DenisChenu Relationship added related to 19364
2024-01-19 10:35 c_schmitz Note Added: 79230
2024-01-19 10:35 c_schmitz Bug heat 0 => 2
2024-01-19 10:52 tibor.pacalat Note Added: 79231
2024-01-19 10:52 tibor.pacalat Bug heat 2 => 4
2024-01-19 10:53 tibor.pacalat Assigned To => tibor.pacalat
2024-01-19 10:53 tibor.pacalat Status new => feedback
2024-01-19 10:53 tibor.pacalat Note Added: 79233
2024-01-19 11:07 DenisChenu Note Added: 79234
2024-01-19 11:07 DenisChenu Bug heat 4 => 6
2024-01-19 11:07 DenisChenu Status feedback => assigned
2024-01-19 11:11 DenisChenu Note Added: 79235
2024-01-19 11:18 DenisChenu Note Added: 79237
2024-01-19 12:25 tibor.pacalat Note Added: 79242
2024-01-19 14:55 DenisChenu Description Updated
2024-01-19 14:55 DenisChenu Note Added: 79246
2024-01-22 05:25 saimson1 Note Added: 79255
2024-01-22 05:25 saimson1 Bug heat 6 => 8
2024-01-22 05:29 saimson1 Note Added: 79256
2024-01-22 08:32 DenisChenu Note Added: 79258
2024-01-29 14:15 tibor.pacalat Assigned To tibor.pacalat =>