View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
19302Bug reportsSurvey takingpublic2024-04-22 11:50
Reporterbismark Assigned Totibor.pacalat  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version5.6.x 
Summary19302: directLogin = true with wrong redirect
Description

https://manual.limesurvey.org/BeforeRegister

Line 137 `$redirectUrl = Yii::app()->getController()->createUrl('/survey/', array('sid' => $iSurveyId,'token' => $oToken->token, 'lang' => $sLanguage));

must be

$redirectUrl = Yii::app()->getController()->createUrl('/survey/index', array('sid' => $iSurveyId,'token' => $oToken->token, 'lang' => $sLanguage));
`

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)6.X
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version8.0

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2023-12-07 11:32

developer   ~78909

The sample plugin do redirect itself …
https://gitlab.com/SondagesPro/SurveyAccess/registerQuick/-/blob/master/registerQuick.php?ref_type=heads#L391

bismark

bismark

2023-12-07 11:40

reporter   ~78910

@DenisChenu nevertheless, this is a LimeSurvey Bug

Mazi

Mazi

2023-12-07 13:38

updater   ~78912

Last edited: 2023-12-07 14:05

@DenisChenu, we faced this issue after upding from LS3.x to latest 5.x. Can you take this one?

DenisChenu

DenisChenu

2023-12-07 15:37

developer   ~78914

@bismark can not do the PR ?

Mazi

Mazi

2023-12-07 15:57

updater   ~78916

@DenisChenu, if you consider the fix valid and no unit test or the like is needed for fixing this, we can send a pull request. Please let me know.
Do we need this for 5.x and 6.x?

DenisChenu

DenisChenu

2023-12-07 16:00

developer   ~78917

Both,
And i review.

You have a test method for Tibor ?
A micro plugin ?

bismark

bismark

2023-12-11 09:42

reporter   ~78931

https://github.com/LimeSurvey/LimeSurvey/pull/3660

Mazi

Mazi

2023-12-11 09:53

updater   ~78932

@denisChenu, please review and pull the request if everything is fine.

DenisChenu

DenisChenu

2023-12-11 09:57

developer   ~78933

Need master version too :)

guest

guest

2023-12-11 13:15

viewer   ~78938

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35831

LimeBot

LimeBot

2023-12-11 13:18

administrator   ~78939

Fixed in Release 5.6.49+231212

DenisChenu

DenisChenu

2023-12-11 14:23

developer   ~78940

@bismark : can you do it for 6.X/master too please ?

Mazi

Mazi

2023-12-11 15:49

updater   ~78941

We would appreciate if you could do that or someone from the Limesurvey development team. We already pay Limesurvey partner fees, we cannot also do the bug fixing or fixes for different releases :-)
Should be a piece of cake for this little issue.

Mazi

Mazi

2024-01-11 14:05

updater   ~79150

@tibor.pacalat, can your team please merge this into LS 6.x as well?

Mazi

Mazi

2024-04-09 17:11

updater   ~79896

@tibor.pacalat: Since this alos affects Limesurvey 6.x, can you please make sure the fix gets added there as well?!
Thanks!

tibor.pacalat

tibor.pacalat

2024-04-09 17:58

administrator   ~79897

@gabrieljenik or @DenisChenu, can you take care of this, to port this fix to 6.x? Whenever is good for you. Thank you

gabrieljenik

gabrieljenik

2024-04-11 15:06

manager   ~79903

I will

gabrieljenik

gabrieljenik

2024-04-18 23:24

manager   ~79951

Master PR: https://github.com/LimeSurvey/LimeSurvey/pull/3822
Just ported the previous commit.

guest

guest

2024-04-19 11:57

viewer   ~79954

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36275

LimeBot

LimeBot

2024-04-22 11:50

administrator   ~79958

Fixed in Release 6.5.4+240422

Related Changesets

LimeSurvey: 5.x 23795ae7

2023-12-11 13:03:39

bismark


Committer: GitHub Details Diff
Fixed issue 19302: Wrong redirect when directLogin is true (03660) Affected Issues
19302
mod - application/controllers/RegisterController.php Diff File

LimeSurvey: master 60d827a6

2024-04-19 11:57:26

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 19302: Wrong redirect when directLogin is true (#3822)

Co-authored-by: Marko Bischof <marko.bischof@gmail.com>
Affected Issues
19302
mod - application/controllers/RegisterController.php Diff File

Issue History

Date Modified Username Field Change
2023-12-07 11:30 bismark New Issue
2023-12-07 11:32 DenisChenu Note Added: 78909
2023-12-07 11:32 DenisChenu Bug heat 0 => 2
2023-12-07 11:40 bismark Note Added: 78910
2023-12-07 11:40 bismark Bug heat 2 => 4
2023-12-07 11:40 guest Bug heat 4 => 2
2023-12-07 11:40 bismark Bug heat 2 => 4
2023-12-07 13:38 Mazi Note Added: 78912
2023-12-07 13:38 Mazi Bug heat 4 => 6
2023-12-07 14:05 Mazi Note Edited: 78912
2023-12-07 15:37 DenisChenu Note Added: 78914
2023-12-07 15:57 Mazi Note Added: 78916
2023-12-07 16:00 DenisChenu Note Added: 78917
2023-12-11 09:42 bismark Note Added: 78931
2023-12-11 09:52 Mazi Assigned To => DenisChenu
2023-12-11 09:52 Mazi Status new => assigned
2023-12-11 09:53 Mazi Note Added: 78932
2023-12-11 09:57 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-12-11 09:57 DenisChenu Status assigned => ready for testing
2023-12-11 09:57 DenisChenu Note Added: 78933
2023-12-11 13:15 bismark Changeset attached => LimeSurvey 5.x 23795ae7
2023-12-11 13:15 guest Note Added: 78938
2023-12-11 13:15 guest Bug heat 6 => 8
2023-12-11 13:18 LimeBot Note Added: 78939
2023-12-11 13:18 LimeBot Status ready for testing => closed
2023-12-11 13:18 LimeBot Resolution open => fixed
2023-12-11 13:18 LimeBot Bug heat 8 => 10
2023-12-11 14:23 DenisChenu Assigned To tibor.pacalat =>
2023-12-11 14:23 DenisChenu Status closed => feedback
2023-12-11 14:23 DenisChenu Resolution fixed => reopened
2023-12-11 14:23 DenisChenu Note Added: 78940
2023-12-11 14:23 DenisChenu Status feedback => confirmed
2023-12-11 14:23 DenisChenu Complete LimeSurvey version number (& build) 5.6.36 => 6.X
2023-12-11 15:49 Mazi Note Added: 78941
2024-01-11 14:05 Mazi Note Added: 79150
2024-01-11 14:05 Mazi Assigned To => tibor.pacalat
2024-01-11 14:05 Mazi Status confirmed => assigned
2024-04-09 17:11 Mazi Note Added: 79896
2024-04-09 17:58 tibor.pacalat Note Added: 79897
2024-04-09 17:58 tibor.pacalat Bug heat 10 => 12
2024-04-11 15:06 gabrieljenik Note Added: 79903
2024-04-11 15:06 gabrieljenik Bug heat 12 => 14
2024-04-11 15:06 gabrieljenik Assigned To tibor.pacalat => gabrieljenik
2024-04-18 23:24 gabrieljenik Status assigned => ready for code review
2024-04-18 23:24 gabrieljenik Note Added: 79951
2024-04-18 23:24 gabrieljenik Assigned To gabrieljenik => DenisChenu
2024-04-19 08:20 DenisChenu Assigned To DenisChenu => tibor.pacalat
2024-04-19 08:20 DenisChenu Status ready for code review => ready for testing
2024-04-19 11:57 tibor.pacalat Status ready for testing => resolved
2024-04-19 11:57 Changeset attached => LimeSurvey master 60d827a6
2024-04-19 11:57 guest Note Added: 79954
2024-04-22 11:50 LimeBot Note Added: 79958
2024-04-22 11:50 LimeBot Status resolved => closed
2024-04-22 11:50 LimeBot Resolution reopened => fixed