19214: JSON RPC response content type should be application/json

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

19214	Bug reports	RemoteControl	public	2023-10-30 22:59	2023-11-21 10:54

Reporter	mfavetti	Assigned To	mfavetti
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	6.3.x

Summary	19214: JSON RPC response content type should be application/json
Description	Simple change, just need to return application/json instead of text/javascript. text/javascript was originally used in the json rpc server library limesurvey chose. I cannot find the original repository anymore, but there are some forks on github and they also make this change. From some googling, I think application/json is the correct type. A user brought it up in forums: https://forums.limesurvey.org/forum/development/142875-the-response-header-of-a-json-rpc-response-is-text-javascript-why I can make pr easily. Just want to know if anyone is opposed to this change.
Steps To Reproduce	Steps to reproduce (Replace this text with detailed step-by-step instructions on how to reproduce the issue) Expected result (Write here what you expected to happen) Actual result (Write here what happened instead)
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	6.3.2
I will donate to the project if issue is resolved	No
Browser
Database type & version	N/A
Server OS (if known)
Webserver software & version (if known)
PHP Version	N/A

User List	There are no users monitoring this issue.

tibor.pacalat 2023-10-31 10:29 administrator ~78180	@mfavetti please make a PR, makes sense!

mfavetti 2023-11-09 08:31 developer ~78346	master: https://github.com/LimeSurvey/LimeSurvey/pull/3610 5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3611

DenisChenu 2023-11-09 09:03 developer ~78348	Unsure need testing

tibor.pacalat 2023-11-09 18:58 administrator ~78360	Tested and merged.

mfavetti 2023-11-09 19:02 developer ~78361	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35734

mfavetti 2023-11-09 19:15 developer ~78362	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35735

LimeBot 2023-11-13 15:43 administrator ~78425	Fixed in Release 6.3.5+231113

DenisChenu 2023-11-21 08:13 developer ~78554	This broke limer https://forums.limesurvey.org/forum/installation-a-update-issues/127953-remotecontrol-doesn-t-work-after-update-to-5-3?start=12#252433

LimeSurvey: 5.x 4cca25e1 2023-11-09 18:58:13 mfavetti Committer: GitHub Details Diff	Fixed issue 19214: JSON RPC response content type should be application/json (03611)	Affected Issues 19214
	mod - application/libraries/LSjsonRPCServer.php	Diff File
LimeSurvey: master 98fc47b6 2023-11-09 18:58:38 mfavetti Committer: GitHub Details Diff	Fixed issue 19214: JSON RPC response content type should be application/json (03610)	Affected Issues 19214
	mod - application/libraries/LSjsonRPCServer.php	Diff File

Date Modified	Username	Field	Change
2023-10-30 22:59	mfavetti	New Issue
2023-10-31 10:29	tibor.pacalat	Note Added: 78180
2023-10-31 10:29	tibor.pacalat	Bug heat	0 => 2
2023-11-09 08:31	mfavetti	Note Added: 78346
2023-11-09 08:31	mfavetti	Bug heat	2 => 4
2023-11-09 08:31	mfavetti	Assigned To	=> DenisChenu
2023-11-09 08:31	mfavetti	Status	new => ready for code review
2023-11-09 09:03	DenisChenu	Assigned To	DenisChenu => tibor.pacalat
2023-11-09 09:03	DenisChenu	Status	ready for code review => ready for testing
2023-11-09 09:03	DenisChenu	Note Added: 78348
2023-11-09 09:03	DenisChenu	Bug heat	4 => 6
2023-11-09 18:58	tibor.pacalat	Status	ready for testing => resolved
2023-11-09 18:58	tibor.pacalat	Resolution	open => fixed
2023-11-09 18:58	tibor.pacalat	Note Added: 78360
2023-11-09 19:02	mfavetti	Changeset attached	=> LimeSurvey 5.x 4cca25e1
2023-11-09 19:02	mfavetti	Note Added: 78361
2023-11-09 19:02	mfavetti	Assigned To	tibor.pacalat => mfavetti
2023-11-09 19:15	mfavetti	Changeset attached	=> LimeSurvey master 98fc47b6
2023-11-09 19:15	mfavetti	Note Added: 78362
2023-11-13 15:43	LimeBot	Note Added: 78425
2023-11-13 15:43	LimeBot	Status	resolved => closed
2023-11-13 15:43	LimeBot	Bug heat	6 => 8
2023-11-21 08:13	DenisChenu	Note Added: 78554
2023-11-21 10:54	DenisChenu	Relationship added	related to 19258