View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19108 | Bug reports | Question editor | public | 2023-09-22 08:46 | 2023-10-23 20:08 |
Reporter | esadergin | Assigned To | ollehar | ||
Priority | none | Severity | crash | ||
Status | assigned | Resolution | open | ||
Product Version | 6.2.x | ||||
Summary | 19108: Error: Subquestion codes should be unique. Cannot save the subquestions even their codes are unique. | ||||
Description | Hello everyone, | ||||
Steps To Reproduce | Steps to reproduce(Replace this text with detailed step-by-step instructions on how to reproduce the issue) Expected result(Write here what you expected to happen) Actual result(Write here what happened instead) | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 18 | ||||
Complete LimeSurvey version number (& build) | 6.2.7 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | Personal data | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | LimeSurvey Cloud Version 6.2.7 | ||||
related to | 19088 | closed | tibor.pacalat | Question Array(Text) codes must be unique (but they are) |
related to | 19160 | confirmed | kfoster | Unable to save subquestions |
Confirm the issue with Array text BUT strangely it disappear … after some time … I try to create a clean way to reproduce (arg , no way … but i see it … doing exactly same action : still no way …) Before fixing : can you just save (and closeà without any action ? And try again ? |
|
I tried so many things but they made no sense. Sometimes it saves and closes, sometimes it does not. I created a new survey and tried to create Array, however it acts the same. Once, i only added questions without any change, it didnt save and close. Actually, in the question page, i save it and it saves. Then I can preview the question and it is ok. However, when I click on "save and close" button, it errors. As a result of this, I cannot step further. |
|
OK, seems related to Close button See screencast Please try with never use the Close action button. |
|
Save + Save and close : broke Not related to @kfoster : maybe related to https://github.com/LimeSurvey/LimeSurvey/pull/3357 ? |
|
Whoever fixes this, please write an automated test to make sure it doesn't happen again. |
|
Yes it is what you created in screencast. |
|
What's the result returned from server in the network tab? Also check console. |
|
I don't check exactly … i confirm and find way to reproduce. |
|
kk. did you check on latest master too? Kevin did a fix yesterday, I think. |
|
Please update to the latest version and check if the bug can still be reproduced. Thank you. |
|
I have just checked and it still gives the same error. After adding sub-questions with unique names, and click "save" and then if we click on "save and close", it gives error. But if we do not click on "save and close" it does not give error. I stick to Denis' way for now. Thanks. |
|
I check on GIT version … Yes , i think it's related to https://github.com/LimeSurvey/LimeSurvey/pull/3357 |
|
PS : I ALWAYS check on last GIT version … |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35544 |
|
I have just pushed a fix to master. The problem is when a subquestion code is moved by typing the codes instead and dragging the codes. This caused a duplication error because the code attempts update a subquestion with a code that sill exists in the database. To get around this I modified the logic so that we check for a matching code/scale-id combination first and if it exists we update. Can @esadergin or @DenisChenu test against master and confirm the issue is resolved before we close this report? Thanks |
|
@kfoster : then, for example if :
User update and put B on subquestion code A and C on subquestion B : default answer are lost … and we have the issue 19108 If you look at screencast : there are no «typing» seems the save action don't put the code at good place |
|
If you look at the screen cast, the same sub question codes are being used for both the X and Y scale. So in this case its not a bug the error message is correct. Regardless, this bug report has helped us identify and fix a related issue. @esadergin can you confirm you dont have any problem when you use different code on both the X and Y scale. |
|
And again : the new fix introduce issue for Default answer moving from one question to another one … |
|
@DenisChenu thanks for testing again and pointing this out. I will try to push a fix this morning. Hopefully this one is final. |
|
I didn't test again, i just show the issue are not related to your fix : it's a HTML issue in my opinion. I make a screencast with the nezw GIT version where you LOOSE subquestion, this commit seems broken https://github.com/LimeSurvey/LimeSurvey/commit/dc083bd9e3280fbe58da885f157c6e48707cae2f |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35552 |
|
A new fix has been pushed. Please test again. Thank you. |
|
Hi, I just want to report the same or a very similar problem. I am using LimeSurvey Cloud Version 5.6.41 Simple array question with SQs that I added via "Quick add" + "Replace". It happens when I press "Save" and also when I press "Save and close" |
|
Hi, Exactly the same thing not only happens with array questions, but with Multiple Choice questions, too. |
|
LimeSurvey: master dc083bd9 2023-09-23 16:54 Kevin Foster Details Diff |
fixed issue 19108 - move subquestion code by typing instead of dragging |
Affected Issues 19108 |
|
mod - application/controllers/QuestionAdministrationController.php | Diff File | ||
LimeSurvey: master d20c9a91 2023-09-26 15:20 Kevin Foster Details Diff |
fixed issue 19108 - avoid duplicate code error with temp code prefix |
Affected Issues 19108 |
|
mod - application/controllers/QuestionAdministrationController.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-09-22 08:46 | esadergin | New Issue | |
2023-09-22 08:46 | esadergin | File Added: 1.jpg | |
2023-09-22 08:46 | esadergin | File Added: 2.jpg | |
2023-09-22 09:26 | DenisChenu | Note Added: 77245 | |
2023-09-22 09:26 | DenisChenu | Bug heat | 0 => 2 |
2023-09-22 09:29 | DenisChenu | Note Edited: 77245 | |
2023-09-22 10:07 | esadergin | Note Added: 77247 | |
2023-09-22 10:07 | esadergin | Bug heat | 2 => 4 |
2023-09-22 10:14 | DenisChenu | Note Added: 77248 | |
2023-09-22 10:14 | DenisChenu | File Added: Peek 22-09-2023 10-13.gif | |
2023-09-22 10:20 | DenisChenu | Note Added: 77249 | |
2023-09-22 10:20 | DenisChenu | File Added: Peek 22-09-2023 10-16.gif | |
2023-09-22 10:48 | ollehar | Note Added: 77250 | |
2023-09-22 10:48 | ollehar | Bug heat | 4 => 6 |
2023-09-22 10:48 | esadergin | Note Added: 77251 | |
2023-09-22 10:49 | ollehar | Note Added: 77252 | |
2023-09-22 10:50 | DenisChenu | Note Added: 77253 | |
2023-09-22 10:50 | DenisChenu | Status | new => confirmed |
2023-09-22 11:30 | ollehar | Note Added: 77255 | |
2023-09-22 11:36 | c_schmitz | Bug heat | 6 => 8 |
2023-09-22 11:36 | ollehar | Assigned To | => ollehar |
2023-09-22 11:36 | ollehar | Status | confirmed => feedback |
2023-09-22 11:36 | ollehar | Note Added: 77257 | |
2023-09-22 11:36 | c_schmitz | Bug heat | 8 => 6 |
2023-09-22 11:43 | esadergin | Note Added: 77258 | |
2023-09-22 11:43 | esadergin | Status | feedback => assigned |
2023-09-22 14:26 | DenisChenu | Note Added: 77266 | |
2023-09-22 14:26 | DenisChenu | Note Added: 77267 | |
2023-09-22 15:09 | gabrieljenik | Relationship added | related to 19088 |
2023-09-23 14:56 | Changeset attached | => LimeSurvey master dc083bd9 | |
2023-09-23 14:56 | guest | Note Added: 77294 | |
2023-09-23 14:56 | guest | Bug heat | 6 => 8 |
2023-09-23 15:03 | kfoster | Note Added: 77295 | |
2023-09-23 15:03 | kfoster | Bug heat | 8 => 10 |
2023-09-25 10:20 | DenisChenu | Note Added: 77296 | |
2023-09-25 16:50 | kfoster | Note Added: 77314 | |
2023-09-26 08:33 | DenisChenu | Note Added: 77320 | |
2023-09-26 08:55 | kfoster | Note Added: 77322 | |
2023-09-26 13:04 | DenisChenu | Note Added: 77326 | |
2023-09-26 13:04 | DenisChenu | File Added: Peek 26-09-2023 13-01.gif | |
2023-09-26 13:20 | Changeset attached | => LimeSurvey master d20c9a91 | |
2023-09-26 13:20 | guest | Note Added: 77329 | |
2023-09-26 13:28 | kfoster | Note Added: 77330 | |
2023-10-23 16:31 | BIFI_research | Note Added: 77877 | |
2023-10-23 16:31 | BIFI_research | File Added: array_bug.png | |
2023-10-23 16:31 | BIFI_research | Bug heat | 10 => 12 |
2023-10-23 17:05 | BIFI_research | Note Added: 77880 | |
2023-10-23 20:08 | mfavetti | Relationship added | related to 19160 |
2023-10-29 21:08 | guest | Bug heat | 12 => 18 |