View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
19025Bug reportsTheme editorpublic2023-08-15 16:382023-09-21 14:28
Reportergabrieljenik Assigned Totibor.pacalat  
PrioritynoneSeverityblock 
Status closedResolutionfixed 
Product Version6.2.x 
Summary19025: When there are question themes installed, can't upload survey themes
Description

Caught while reviewing #19019.
This is due to a malformed HTML.

Steps To Reproduce

Steps to reproduce

  • Make sure you have question themes installed
  • Try to upload a survey theme

Expected result

You get to upload

Actual result

Backdrop is shown. No control for uploading.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)6.2.1
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-08-15 17:44

manager   ~76605

PR https://github.com/LimeSurvey/LimeSurvey/pull/3358/
tibor.pacalat

tibor.pacalat

2023-09-15 12:15

administrator   ~77067

@gabrieljenik I can not reproduce the issue on master.

How I tried:

  1. I extended the theme fruity and exported it
  2. Deleted it from the app after export
  3. Installed question theme Card-Sort
  4. Installed the extended fruity theme - Successfully

What am I missing?
gabrieljenik

gabrieljenik

2023-09-18 16:40

manager   ~77142

Complex steps:

You must have a Question theme available (without installing) in the “Available question themes:” list (the list below in the Question Themes tab).
When this is the case, if you press the “Upload & Install” button while in the “Survey Themes” tab, only the backdrop appears.

image.png (93,093 bytes)   
image.png (93,093 bytes)   
guest

guest

2023-09-19 12:17

viewer   ~77157

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35510
guest

guest

2023-09-19 12:17

viewer   ~77158

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35509
tibor.pacalat

tibor.pacalat

2023-09-19 12:18

administrator   ~77159

Tested and merged. Thanks for additional testing instructions Gabriel.
LimeBot

LimeBot

2023-09-21 14:28

administrator   ~77214

Fixed in Release 6.2.8+230921

Related Changesets

LimeSurvey: master 11051a93

2023-09-19 14:17

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 19025: When there are question themes installed, can't upload survey themes (#3358)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
19025
mod - application/views/themeOptions/availablethemelist.php Diff File
mod - application/views/themeOptions/index.php Diff File

LimeSurvey: master 11051a93

2023-09-19 14:17

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 19025: When there are question themes installed, can't upload survey themes (#3358)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
19025
mod - application/views/themeOptions/availablethemelist.php Diff File
mod - application/views/themeOptions/index.php Diff File

Issue History

Date Modified Username Field Change
2023-08-15 16:38 gabrieljenik New Issue
2023-08-15 16:38 gabrieljenik Issue generated from: 19019
2023-08-15 16:42 gabrieljenik Assigned To => gabrieljenik
2023-08-15 16:42 gabrieljenik Status new => assigned
2023-08-15 17:44 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-08-15 17:44 gabrieljenik Status assigned => ready for code review
2023-08-15 17:44 gabrieljenik Note Added: 76605
2023-08-15 17:44 gabrieljenik Bug heat 6 => 8
2023-08-15 17:46 gabrieljenik View Status private => public
2023-08-15 17:46 gabrieljenik Bug heat 8 => 2
2023-09-07 18:22 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-09-07 18:22 DenisChenu Status ready for code review => ready for testing
2023-09-13 16:52 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-09-15 12:15 tibor.pacalat Note Added: 77067
2023-09-15 12:15 tibor.pacalat Bug heat 2 => 4
2023-09-18 16:40 gabrieljenik Note Added: 77142
2023-09-18 16:40 gabrieljenik File Added: image.png
2023-09-19 12:17 Changeset attached => LimeSurvey master 11051a93
2023-09-19 12:17 Changeset attached => LimeSurvey master 11051a93
2023-09-19 12:17 guest Note Added: 77157
2023-09-19 12:17 guest Note Added: 77158
2023-09-19 12:17 guest Bug heat 4 => 6
2023-09-19 12:17 guest Bug heat 4 => 6
2023-09-19 12:18 tibor.pacalat Status ready for testing => resolved
2023-09-19 12:18 tibor.pacalat Resolution open => fixed
2023-09-19 12:18 tibor.pacalat Note Added: 77159
2023-09-21 14:28 LimeBot Note Added: 77214
2023-09-21 14:28 LimeBot Status resolved => closed
2023-09-21 14:28 LimeBot Bug heat 6 => 8