View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19015 | Bug reports | User / Groups / Roles | public | 2023-08-07 07:05 | 2024-10-28 17:41 |
Reporter | adamzammit | Assigned To | DenisChenu | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 6.2.0-dev | ||||
Summary | 19015: User with superadmin role does not get superadmin privileges | ||||
Description | When a role is created and assigned as "superadmin", then a user is assigned to that role, the superadmin privileges do not carry over | ||||
Steps To Reproduce | Steps to reproduceCreate a new role (called "SUPER") Expected result"testuser" has superadmin privileges Actual result"testuser" has no privileges | ||||
Tags | No tags attached. | ||||
Bug heat | 16 | ||||
Complete LimeSurvey version number (& build) | 6.2.0 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | Mariadb 10.5 | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 8.1 | ||||
has duplicate | 19789 | closed | DenisChenu | User role with superadmin / read didn't give superadmin permission |
Appears to be due to: superadmin only being checked if assigned directly to user - not if it falls within a role. I've written a hacky workaround for this but I'll wait and see if there is a proposed solution before submitting a PR |
|
I hate role … i really think it's muts be done in plugin and ONLY in plugin …$ @gabrieljenik : interested ? |
|
Does this only happens with superadmin? |
|
It's totally related to superadmin
I say a +33 except some user want this … then : must keep the possibility. I have idea here , i keep it. |
|
@adamzammit maybe ypou can test (and make some proposition about the code) |
|
@DenisChenu I see I am not requested reviewer on Github. Just let me know if you want me to review or Adam. Thanks |
|
Oups … Sorry |
|
Have review by Adam + unit test |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36580 |
|
Tested and merged. |
|
Fixed in Release 6.6.7+241028 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2023-08-07 07:05 | adamzammit | New Issue | |
2023-08-07 07:07 | adamzammit | Note Added: 76443 | |
2023-08-07 07:07 | adamzammit | Bug heat | 0 => 2 |
2023-08-07 12:21 | ollehar | Assigned To | => DenisChenu |
2023-08-07 12:21 | ollehar | Status | new => assigned |
2023-09-07 18:35 | DenisChenu | Note Added: 76907 | |
2023-09-07 18:35 | DenisChenu | Bug heat | 2 => 4 |
2023-09-07 18:38 | gabrieljenik | Note Added: 76909 | |
2023-09-07 18:38 | gabrieljenik | Bug heat | 4 => 6 |
2023-09-08 16:04 | DenisChenu | Note Added: 76923 | |
2023-09-11 17:19 | DenisChenu | Status | assigned => ready for code review |
2023-09-11 17:19 | DenisChenu | Note Added: 76942 | |
2023-09-11 17:21 | DenisChenu | Note Added: 76943 | |
2023-09-11 17:21 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2023-09-13 16:35 | gabrieljenik | Note Added: 77009 | |
2023-09-13 16:55 | DenisChenu | Note Added: 77010 | |
2024-10-04 10:39 | DenisChenu | Relationship added | has duplicate 19789 |
2024-10-04 10:39 | DenisChenu | Bug heat | 6 => 12 |
2024-10-04 10:41 | DenisChenu | Assigned To | gabrieljenik => tibor.pacalat |
2024-10-04 10:41 | DenisChenu | Status | ready for code review => ready for testing |
2024-10-04 10:41 | DenisChenu | Note Added: 81163 | |
2024-10-04 17:16 | DenisChenu | Changeset attached | => LimeSurvey master fe120607 |
2024-10-04 17:16 | DenisChenu | Note Added: 81166 | |
2024-10-04 17:16 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2024-10-04 17:16 | DenisChenu | Resolution | open => fixed |
2024-10-04 17:16 | tibor.pacalat | Status | ready for testing => resolved |
2024-10-04 17:16 | tibor.pacalat | Note Added: 81167 | |
2024-10-04 17:16 | tibor.pacalat | Bug heat | 12 => 14 |
2024-10-28 17:41 | LimeBot | Note Added: 81311 | |
2024-10-28 17:41 | LimeBot | Status | resolved => closed |
2024-10-28 17:41 | LimeBot | Bug heat | 14 => 16 |