Email Placeholders

Application Models Survey

    //$url = App()->createUrl('survey/index', $urlParams);
    $url = App()->createPublicUrl('survey/index', $urlParams);

Can you tell us which file and line you're suggesting a change?

Oh, the Survey model. Will check.

Hello juliodiz,
This should already be fixed in recent versions.
Can you please check if this issue still exists in the latest version of LimeSurvey and let us know?
Thank you!

Thanks!
Same problem here
I am using last version Confort Update and still having this issue.

[2023-07-21T22:44:11-03:00] [INFO] Start sendMailByCron for 455337
CException: ConsoleApplication and its behaviors do not have a method or closure named "createPublicUrl". in /var/www/public/vendor/yiisoft/yii/framework/base/CComponent.php:266
Stack trace:
#0 /var/www/public/application/models/Survey.php(2355): CComponent->__call('createPublicUrl', Array)

Problem when using

/usr/bin/php /var/www/public/application/commands/console.php plugin cron --interval=1

Its not working using the php script console to run and send the email.

Need to change
$url = App()->createUrl('survey/index', $urlParams);
to
$url = App()->createAbsoluteUrl('survey/index', $urlParams);

We are facing the same "CException: ConsoleApplication and its behaviors do not have a method or closure named "createPublicUrl"" problem. Our inviter and reminder cronjob scripts (https://survey-consulting.com/product-category/limesurvey-plugins/limesurvey-cronjob-scripts) are showing an error when being run on console.
This problem showed up just recently at the latest 5.6.33 version.

please also fix the 5.x branch

What is the timeframe for fixing this issue ?
Currently : all console plugin sending mail are broken.

I'd also like to second that this issue breaks many of our plugins, so a fast fix would be much appreciated.

When applying similar changes in the future, please keep such console things in mind. This was broken several times in the past.

The bug exist in version 5.6.34, but not in 5.6.16!

Was related to new feature «Survey alias»

@ollehar : if you don't have time : i need it before try fixing sendMailCron,
Then : you can assign it to me.

I was just asking this morning about this ticket.
We can take it.
Let me know if you want me to take it or you prefer to do it.

Thanks

If you think you can fix before end of week : feel free to take it.

@gabrieljenik : remind the publicurl config settings :)

Sure... Let me work a bit on it and push something...

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3454

Please consider the following when reviewing:
Had to add these to the config:

• Config section ('publicurl'=>'https://limesurvey.example.org:8000/limesurvey')
• Components section ('request ' => ['baseUrl' => '/limesurvey'])

As this is only required when running ConsoleApplication, maybe there is the need of having specific config for console?

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3454

1. This issue is ONLY for V6 , and are not related to console
2. No new issue with console and createPublicUrl if i don't make error.

As this is only required when running ConsoleApplication, maybe there is the need of having specific config for console?

This is a new feature and must be reported separatly.

@juliodiz : i check on last git version : seems OK (via web)

Except it don't use publicurl of config.

@gabrieljenick :

Config section ('publicurl'=>'https://limesurvey.example.org:8000/limesurvey')

You can set whole baseUrl in publicurl : 'publicurl' => 'https://www.example.org/example/' work (in current master too).

@DenisChenu

re: https://github.com/LimeSurvey/LimeSurvey/pull/3454#pullrequestreview-1632679815
The issue is said to be in console application, so we ported the URL methods to ConsoleApplication.
Why you say is not related?

Was related to new feature «Survey alias»

I am no that sure.
Issue seems to have started here when model got dependen on the application.
https://github.com/LimeSurvey/LimeSurvey/commit/3c7045423a5918987840f2723d7ca2e7f4097823

@mazi @francois-charles.hebert @juliodiz
Maybe you can help testing the PR?

@bismark, please have a look and check to what extend this affects our Inviter and Reminder cronjobs.

The issue is said to be in console application, so we ported the URL methods to ConsoleApplication.

Look at the issue

Summary 18961: {SURVEYURL} not complete URL
Description

{SURVEYURL} don't show complete URL

/index.php/215424?token=test1&lang=en-US
Steps To Reproduce
Steps to reproduce

Use {SURVEYURL}
Expected result

https://survey.com/index.php/215424?token=test1&lang=en-US
Actual result

/index.php/215424?token=test1&lang=en-US

Where did you see console application here ?

Issue seems to have started here when model got dependen on the application.

Yes, but why fix it in 5.X then ?
There are another issue to report for console here https://bugs.limesurvey.org/view.php?id=18961#c76235

But only for 6.X

Yes, but why fix it in 5.X then ?

It is blocking. If fixes are similar, we cna port one to the other.

It is blocking. If fixes are similar, we cna port one to the other.

Oh right : the issue wityh console happen too

Just when call Survey->getSurveyUrl()

@juliodiz : can you confirem something : you report the issue only for console or there are another issue ?

{SURVEYURL} i use at email and remember email. When i use sendmailbycron URL was missing. (sendmailcron)

{SURVEYURL} i use at email and remember email. When i use sendmailbycron URL was missing. (sendmailcron)

You deactivate error to have the mail sent ?
Because i have CException: ConsoleApplication and its behaviors do not have a method or closure named "createPublicUrl" and it broke!?

Why you din't report at https://gitlab.com/SondagesPro/mailing/sendMailCron/-/issues ?

Checked with no update on sendMail Cron

• OK with publicurl
• KO with only sendMailCron config : https://gitlab.com/SondagesPro/mailing/sendMailCron/-/blob/master/sendMailCron.php?ref_type=heads#L696-703

With https://github.com/LimeSurvey/LimeSurvey/commit/55d9eda4c9407db6982dfad0ae8355dfc3c0d572 (parent of https://github.com/LimeSurvey/LimeSurvey/commit/3c7045423a5918987840f2723d7ca2e7f4097823 ) :

• OK with only sendMailCron config

@gabrieljenik it looks like there is more work to be done here. Any update on this?

@Mazi and @bismark : did you test with your own plugin ?

sendMailCron didn't work, but create a fix is easy.