View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 14
IDProjectCategoryView StatusDate SubmittedLast Update
18937Bug reportsUser / Groups / Rolespublic2023-07-04 01:192023-07-17 10:07
Reporterrnordavind Assigned Totibor.pacalat  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version6.1.x 
Summary18937: Action menu stop work after any action on any user
Description

Hey guys!
I have a problem saving user permissions. When I click save I get the success message but at the bottom of the page it shows "nullnullnullnullnullnullnull" and the action button doesn't work until I refresh the page. Has anyone ever experienced this?

I upgraded from version 3.27 to version 6.1.6

Steps To Reproduce

Steps to reproduce

Configuration > User Management:
http://.../index.php/userManagement/index

Expected result

After save any changes on any user, be able to click on another action menu of a other user

Actual result

the bottom of the page it shows "nullnullnullnullnullnullnull" and the action button doesn't work until I refresh the page

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build) LimeSurvey Community Edition Version 6.1.6+230703
I will donate to the project if issue is resolvedNo
Browser
Database type & version5.5.5-10.5.19-MariaDB-0+deb11u2
Server OS (if known)
Webserver software & version (if known)
PHP Version 7.4.33

Relationships

Relationship GraphDependency Graph
related to 18939 closedp_teichmann Bug reports Cannot access surveys from survey list after moving to different page of list 
related to 18950 closedgabrieljenik Bug reports User management - broken paging and editing of users 
related to 18943 feedbackgabrieljenik Feature requests While navigating the user management page, we're getting some "null" values on the bottom: 
related to 18951 closedgabrieljenik Bug reports Users - Actions menu items don't work after search 

Users monitoring this issue

mferraz

Activities

gabrieljenik

gabrieljenik

2023-07-12 15:09

manager   ~76058

https://github.com/LimeSurvey/LimeSurvey/pull/3282
p_teichmann

p_teichmann

2023-07-13 11:48

administrator   ~76071

Hey Gabriel i updated the pull request with some changes, i already had this issue marked for me internally so i check your commit and the issue and updated the code accordingly.
DenisChenu

DenisChenu

2023-07-13 11:56

developer   ~76072

code review by ptelu ;)
guest

guest

2023-07-13 12:28

viewer   ~76074

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34962
tibor.pacalat

tibor.pacalat

2023-07-13 12:28

administrator   ~76075

Tested and merged.
gabrieljenik

gabrieljenik

2023-07-13 13:59

manager   ~76077

Last edited: 2023-07-13 14:00

Hey Gabriel i updated the pull request with some changes, i already had this issue marked for me internally so i check your commit and the issue and updated the code accordingly.

To be honest, I can't help feeling a bit frutstrated.
I reached to you before starting on this.
Now I see you just took over, undid most of my commit and got ir merged... all without discussing.
Just make me feel dminished.

May I ask what was wrong about the fix we originally pushed?
Something missing?

I noticed you updated CSS and some stuff about "sticky columns"... is that related to the bug?
p_teichmann

p_teichmann

2023-07-13 14:44

administrator   ~76078

About the issue itself, the problem was that there was no check in javascript if the action had a valid target. I also removed the code which was an earlier attempt to fix the issue with displaying dropdowns which was fixed by this new implementation.
When you reached out to me i had no idea what this question was related to i just saw some code duplication so i didnt make the connection to this.

The only reason i took that over because it was important to have that working before we do some last checks for the release and i already had it planned for this morning.
Hope i didn't upset you to much with editing your PR, i didn't want to create a new one for it.
gabrieljenik

gabrieljenik

2023-07-13 14:59

manager   ~76079

No worries! Thanks!
DenisChenu

DenisChenu

2023-07-14 11:46

developer   ~76086

Currently : seems there are 2 way to report and fix issue. And no relation between internal way and mantis …

I already have some PR closed because it was fixed by internal team on internal project (without the mantis number).

And yes : sometimes feel like working for nothing … even if the issue is reported by internal team … (as urgent …)
LimeBot

LimeBot

2023-07-17 10:07

administrator   ~76102

Fixed in Release 6.1.8+230717

Related Changesets

LimeSurvey: master 34779625

2023-07-13 14:28

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18937: Action menu stop work after any action on any user (#3282)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Co-authored-by: Patrick Teichmann <patrick.teichmann@limesurvey.org>		 Affected Issues
18937
mod - application/extensions/admin/grid/CLSGridView.php Diff File
mod - application/extensions/admin/grid/GridActionsWidget/assets/action_dropdown.js Diff File
mod - assets/admin_themes/Sea_Green/tables/tables.scss Diff File
mod - themes/admin/Sea_Green/css/sea_green-rtl.css Diff File
mod - themes/admin/Sea_Green/css/sea_green-rtl.min.css Diff File
mod - themes/admin/Sea_Green/css/sea_green.css Diff File
mod - themes/admin/Sea_Green/css/sea_green.min.css Diff File

Issue History

Date Modified Username Field Change
2023-07-04 01:19 rnordavind New Issue
2023-07-07 20:08 gabrieljenik Assigned To => gabrieljenik
2023-07-07 20:08 gabrieljenik Status new => assigned
2023-07-12 15:09 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-07-12 15:09 gabrieljenik Status assigned => ready for code review
2023-07-12 15:09 gabrieljenik Note Added: 76058
2023-07-12 15:09 gabrieljenik Bug heat 0 => 2
2023-07-13 11:48 p_teichmann Note Added: 76071
2023-07-13 11:48 p_teichmann Bug heat 2 => 4
2023-07-13 11:56 DenisChenu Note Added: 76072
2023-07-13 11:56 DenisChenu Bug heat 4 => 6
2023-07-13 11:56 DenisChenu Assigned To DenisChenu => p_teichmann
2023-07-13 12:03 p_teichmann Assigned To p_teichmann => twilllig
2023-07-13 12:03 p_teichmann Status ready for code review => in code review
2023-07-13 12:21 p_teichmann Assigned To twilllig => tibor.pacalat
2023-07-13 12:21 p_teichmann Status in code review => ready for testing
2023-07-13 12:28 Changeset attached => LimeSurvey master 34779625
2023-07-13 12:28 guest Note Added: 76074
2023-07-13 12:28 guest Bug heat 6 => 8
2023-07-13 12:28 tibor.pacalat Status ready for testing => resolved
2023-07-13 12:28 tibor.pacalat Resolution open => fixed
2023-07-13 12:28 tibor.pacalat Note Added: 76075
2023-07-13 12:28 tibor.pacalat Bug heat 8 => 10
2023-07-13 13:59 gabrieljenik Note Added: 76077
2023-07-13 13:59 gabrieljenik Note Edited: 76077
2023-07-13 14:00 gabrieljenik Note Edited: 76077
2023-07-13 14:44 p_teichmann Note Added: 76078
2023-07-13 14:59 gabrieljenik Note Added: 76079
2023-07-13 18:16 gabrieljenik Relationship added related to 18939
2023-07-13 18:17 gabrieljenik Relationship added related to 18950
2023-07-13 18:18 gabrieljenik Relationship added related to 18943
2023-07-13 18:39 mferraz Issue Monitored: mferraz
2023-07-13 18:39 mferraz Bug heat 10 => 12
2023-07-13 23:45 gabrieljenik Relationship added related to 18951
2023-07-14 11:46 DenisChenu Note Added: 76086
2023-07-17 10:07 LimeBot Note Added: 76102
2023-07-17 10:07 LimeBot Status resolved => closed
2023-07-17 10:07 LimeBot Bug heat 12 => 14