18771: Superadmin unable to rename theme, - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18771	Bug reports	Theme editor	public	2023-04-20 08:58	2023-04-27 17:43

Reporter	Leithy	Assigned To	DenisChenu
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	6.0.x

Summary	18771: Superadmin unable to rename theme,
Description	Superadmin cannot rename themes. Returns "Template could not be renamed to [insert name]. Maybe you don't have permission." (Addendum: error message should say "Theme" instead of "Template" too)
Steps To Reproduce	Steps to reproduce As superadmin, enter theme editor, click rename theme, enter theme name, click ok Expected result Theme renamed, probably with a check to ensure the name is different to existing themes Actual result Error: ""Template could not be renamed to xxx. Maybe you don't have permission."
Tags	No tags attached.

Bug heat	4
Complete LimeSurvey version number (& build)	6.x
I will donate to the project if issue is resolved	No
Browser
Database type & version	NA
Server OS (if known)
Webserver software & version (if known)
PHP Version	7.4

User List	There are no users monitoring this issue.

DenisChenu 2023-04-25 19:32 developer ~74642	Same in 5.X

DenisChenu 2023-04-25 19:43 developer ~74643	master : https://github.com/LimeSurvey/LimeSurvey/pull/3076 5X : https://github.com/LimeSurvey/LimeSurvey/pull/3077

DenisChenu 2023-04-27 17:27 developer ~74715	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34566

tibor.pacalat 2023-04-27 17:32 administrator ~74716	This has been tested in 5.x and 6.x and now it works!

DenisChenu 2023-04-27 17:43 developer ~74717	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34567

LimeSurvey: master 1337418e 2023-04-27 19:27 DenisChenu Committer: GitHub Details Diff	Fixed issue 18771: Superadmin unable to rename theme (#3076) Dev: remove usage of sanitize_dirname on App()->getConfig('userthemerootdir')	Affected Issues 18771
	mod - application/controllers/admin/Themes.php	Diff File
LimeSurvey: 5.x f18310cf 2023-04-27 19:31 DenisChenu Committer: GitHub Details Diff	Fixed issue 18771: Superadmin unable to rename theme (#3077) Dev: remove usage of sanitize_dirname on App()->getConfig('userthemerootdir')	Affected Issues 18771
	mod - application/controllers/admin/Themes.php	Diff File

Date Modified	Username	Field	Change
2023-04-20 08:58	Leithy	New Issue
2023-04-24 09:56	p_teichmann	Assigned To	=> p_teichmann
2023-04-24 09:56	p_teichmann	Status	new => confirmed
2023-04-24 17:24	DenisChenu	Assigned To	p_teichmann => DenisChenu
2023-04-25 19:32	DenisChenu	Note Added: 74642
2023-04-25 19:32	DenisChenu	Bug heat	0 => 2
2023-04-25 19:36	DenisChenu	Status	confirmed => assigned
2023-04-25 19:43	DenisChenu	Note Added: 74643
2023-04-25 19:43	DenisChenu	Assigned To	DenisChenu => gabrieljenik
2023-04-25 19:43	DenisChenu	Status	assigned => ready for code review
2023-04-25 22:40	gabrieljenik	Assigned To	gabrieljenik =>
2023-04-25 22:40	gabrieljenik	Status	ready for code review => ready for testing
2023-04-27 17:27	DenisChenu	Changeset attached	=> LimeSurvey master 1337418e
2023-04-27 17:27	DenisChenu	Note Added: 74715
2023-04-27 17:27	DenisChenu	Assigned To	=> DenisChenu
2023-04-27 17:27	DenisChenu	Resolution	open => fixed
2023-04-27 17:32	tibor.pacalat	Status	ready for testing => closed
2023-04-27 17:32	tibor.pacalat	Note Added: 74716
2023-04-27 17:32	tibor.pacalat	Bug heat	2 => 4
2023-04-27 17:43	DenisChenu	Changeset attached	=> LimeSurvey 5.x f18310cf
2023-04-27 17:43	DenisChenu	Note Added: 74717