View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
18644Bug reportsSurvey editingpublic2023-02-17 13:442023-03-13 10:39
Reportergabrieljenik Assigned Toollehar  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18644: YII_DEBUG was not used inside KCFinder
Description

Even if no debug is set on the general config, the KCfinder is showing like debug was set.

Caught while reviewing 18453

Steps To Reproduce

Steps to reproduce

Set debug to 0
Use PHP 8.1
Go to Resources "Add/edit resources (files/images) for this survey"

Expected result

No errors

Actual result

Error page

TagsNo tags attached.
Attached Files
image.png (49,756 bytes)   
image.png (49,756 bytes)   
Bug heat12
Complete LimeSurvey version number (& build)5.4.9 / master
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & version10.3.36-MariaDB-0+deb10u2
Server OS (if known)debian
Webserver software & version (if known)apache
PHP Version8.1.12

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-02-17 13:46

manager   ~73874

Already have the solution. Will make the PR
constantinl

constantinl

2023-02-20 18:02

reporter   ~73890

Thanks for creating this ticket @gabrieljenik

I guess you managed to reproduce the problem.
For us it happened just by installing LS5 on a server with PHP 8.1

Any clue when the patch for this issue might be release?
gabrieljenik

gabrieljenik

2023-02-21 00:32

manager   ~73894

https://github.com/LimeSurvey/LimeSurvey/pull/2934
gabrieljenik

gabrieljenik

2023-02-21 00:34

manager   ~73895

@constantinl
Please find above the PR. If you could help testing would be great!
DenisChenu

DenisChenu

2023-02-21 08:33

developer   ~73897

Some comment in GITHUB
constantinl

constantinl

2023-02-21 08:47

reporter   ~73898

@gabrieljenik
The bug is fixed with that patch.
No error message anymore and the upload of files is working.
gabrieljenik

gabrieljenik

2023-02-27 13:29

manager   ~73962

Last edited: 2023-02-27 14:00

@constantinl
Can I please ask you to retest? We have been making some changes after you tested. Thanks
constantinl

constantinl

2023-03-01 17:25

reporter   ~74000

Test successful after changing files index.php and /vendor/kcfinder/core/bootstrap.php, and adding setdebug.php
gabrieljenik

gabrieljenik

2023-03-01 20:32

manager   ~74001

Taking into account the comments and the specifics of this situation.
Can we mark this as tested? @c_schmitz ?
guest

guest

2023-03-07 10:21

viewer   ~74060

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34365
ollehar

ollehar

2023-03-07 10:27

administrator   ~74061

This should have been done in dev branch instead, I think.
DenisChenu

DenisChenu

2023-03-07 14:51

developer   ~74063

Last edited: 2023-03-07 14:52

This should have been done in dev branch instead, I think.

Why? This break system with debug=0
LimeBot

LimeBot

2023-03-13 10:39

administrator   ~74095

Fixed in Release 5.6.10+230313

Related Changesets

LimeSurvey: master 673419f4

2023-03-07 10:21:31

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed issue 18644: YII_DEBUG was not used inside KCFinder (#2934)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
18644
mod - index.php Diff File
add - setdebug.php Diff File
mod - vendor/kcfinder/core/bootstrap.php Diff File

Issue History

Date Modified Username Field Change
2023-02-17 13:44 gabrieljenik New Issue
2023-02-17 13:44 gabrieljenik File Added: image.png
2023-02-17 13:44 gabrieljenik Issue generated from: 18453
2023-02-17 13:45 gabrieljenik Assigned To => gabrieljenik
2023-02-17 13:45 gabrieljenik Status new => assigned
2023-02-17 13:46 gabrieljenik Note Added: 73874
2023-02-17 13:46 gabrieljenik Bug heat 0 => 2
2023-02-20 18:02 constantinl Note Added: 73890
2023-02-20 18:02 constantinl Bug heat 2 => 4
2023-02-21 00:32 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-02-21 00:32 gabrieljenik Status assigned => ready for code review
2023-02-21 00:32 gabrieljenik Note Added: 73894
2023-02-21 00:34 gabrieljenik Note Added: 73895
2023-02-21 08:33 DenisChenu Status ready for code review => in code review
2023-02-21 08:33 DenisChenu Note Added: 73897
2023-02-21 08:33 DenisChenu Bug heat 4 => 6
2023-02-21 08:47 constantinl Note Added: 73898
2023-02-22 14:29 gabrieljenik Issue cloned: 18649
2023-02-27 11:41 DenisChenu Assigned To DenisChenu =>
2023-02-27 11:41 DenisChenu Status in code review => ready for testing
2023-02-27 13:29 gabrieljenik Note Added: 73962
2023-02-27 14:00 c_schmitz Note Edited: 73962
2023-03-01 17:25 constantinl Note Added: 74000
2023-03-01 20:32 gabrieljenik Note Added: 74001
2023-03-02 14:00 gabrieljenik Assigned To => ollehar
2023-03-02 14:00 gabrieljenik Status ready for testing => ready for merge
2023-03-07 10:21 Changeset attached => LimeSurvey master 673419f4
2023-03-07 10:21 guest Note Added: 74060
2023-03-07 10:21 guest Bug heat 6 => 8
2023-03-07 10:26 ollehar Status ready for merge => resolved
2023-03-07 10:26 ollehar Resolution open => fixed
2023-03-07 10:27 ollehar Note Added: 74061
2023-03-07 10:27 ollehar Bug heat 8 => 10
2023-03-07 14:51 DenisChenu Note Added: 74063
2023-03-07 14:52 DenisChenu Note Edited: 74063
2023-03-13 10:39 LimeBot Note Added: 74095
2023-03-13 10:39 LimeBot Status resolved => closed
2023-03-13 10:39 LimeBot Bug heat 10 => 12