PR https://github.com/LimeSurvey/LimeSurvey/pull/2960

The icon was failing only when time adjust was NOT zero, as then sExpired was null and sNow was todays, but adjusted.
When that happened: oStop was set to now and sNow was set to Now but adjusted. That made the bExpired to be true.

Created tests.
Did a small change to fix the situation, and avoid using the "sometimes-wrongly-calculated" value.

These needs to be reviewed a bit more as there is a lot of duplicated code.
Started a reorganization draft but will pick up later: https://github.com/LimeSurvey/LimeSurvey/pull/2957

So far, with this I think is a good starter.

• Fix
• No reorg
• Tests (which will be usefull for making sure future reorg is ok)

I don't really understand the fix ?

I can not reproduce …

Capture d’écran du 2023-03-02 19-21-11.png (21,724 bytes)   

Capture d’écran du 2023-03-02 19-21-11.png (21,724 bytes)   

Capture d’écran du 2023-03-02 19-21-41.png (17,268 bytes)   

Capture d’écran du 2023-03-02 19-21-41.png (17,268 bytes)   

With time adjust 0 or 1 : no change … :(

I will explain in a while... It is tricky and now I got confised myself :)

The icon was failing only when time adjust was NOT zero (and positive), as then sExpired was null and sNow was todays, but adjusted.
When that happened: oStop was set to now and sNow was set to Now but adjusted. That made the bExpired to be true.

That code was kind of fixed on getState(), so a reorganization is needed.
We made the fix on 1 PR and then a reorganization (still need to adjust a bit) on another.

OK : i got it :)

Testing now

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34387

I also managed to reproduce it on develop:

1. create a survey, set start date in the past (timeadjust: 0)
2. activate it
3. change timeadjust to 7
4. It shows as "Expired"

PR for master
https://github.com/LimeSurvey/LimeSurvey/pull/3232

After accepted will do for v5.

Merged 6.x patch

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34906

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34905

Couldn't reproduce it on v5.
I think it is ok to close. @tibor.pascalet ?

Fixed in Release 6.1.6+230703

Yeah, I can't reproduce it in 5.x either, closing this one.