18619: QuestionGroup->getGroupDescription() fails - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18619	Bug reports	Other	public	2023-02-03 12:26	2023-02-27 11:34

Reporter	gabrieljenik	Assigned To	ollehar
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	5.5.x

Summary	18619: QuestionGroup->getGroupDescription() fails
Description	QuestionGroup->getGroupDescription() is not adapted for LS5. Should query QuestionGroupL10n. `public function getGroupDescription($iGroupId, $sLanguage) { return $this->findByPk(array('gid' => $iGroupId, 'language' => $sLanguage))->description; }`
Steps To Reproduce	The method is being used on `getFullResponseTable` which is used on `getResponseTableReplacement()` for creating ANSWERTABLE replacement field content. Still, as the group description is not being used on the ANSWERTABLE, that's why the bug is not noticeable.
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	5.x
I will donate to the project if issue is resolved	No
Browser
Database type & version	Mysql
Server OS (if known)
Webserver software & version (if known)
PHP Version	7

User List	There are no users monitoring this issue.

gabrieljenik 2023-02-06 15:52 manager ~73698	https://github.com/LimeSurvey/LimeSurvey/pull/2890

DenisChenu 2023-02-10 17:49 developer ~73798	Hard to test ?

gabrieljenik 2023-02-10 17:52 manager ~73800	I will add an auto test for this :)

DenisChenu 2023-02-10 17:54 developer ~73801	I have a a plugin replacing {ANSWERTABLE} https://gitlab.com/SondagesPro/mailing/adminNotificationHtmlAnswerTable

gabrieljenik 2023-02-16 16:00 manager ~73864	I think this can be merged now considering the auto tests added.

guest 2023-02-21 14:33 viewer ~73901	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34332

LimeBot 2023-02-27 11:34 administrator ~73955	Fixed in Release 5.6.8+230227

LimeSurvey: master 6135f9e8 2023-02-21 15:33 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18619: QuestionGroup->getGroupDescription() fails (#2890) Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18619
	mod - application/models/QuestionGroup.php	Diff File
	add - tests/data/surveys/limesurvey_survey_594264_getGroupDescription.lss	Diff File
	mod - tests/unit/models/QuestionGroupTest.php	Diff File

Date Modified	Username	Field	Change
2023-02-03 12:26	gabrieljenik	New Issue
2023-02-03 12:26	gabrieljenik	Assigned To	=> gabrieljenik
2023-02-03 12:26	gabrieljenik	Status	new => assigned
2023-02-06 15:52	gabrieljenik	Assigned To	gabrieljenik => DenisChenu
2023-02-06 15:52	gabrieljenik	Status	assigned => ready for code review
2023-02-06 15:52	gabrieljenik	Note Added: 73698
2023-02-06 15:52	gabrieljenik	Bug heat	0 => 2
2023-02-10 17:49	DenisChenu	Assigned To	DenisChenu =>
2023-02-10 17:49	DenisChenu	Status	ready for code review => ready for testing
2023-02-10 17:49	DenisChenu	Note Added: 73798
2023-02-10 17:49	DenisChenu	Bug heat	2 => 4
2023-02-10 17:52	gabrieljenik	Note Added: 73800
2023-02-10 17:54	DenisChenu	Note Added: 73801
2023-02-16 16:00	gabrieljenik	Assigned To	=> ollehar
2023-02-16 16:00	gabrieljenik	Status	ready for testing => ready for merge
2023-02-16 16:00	gabrieljenik	Note Added: 73864
2023-02-21 14:33		Changeset attached	=> LimeSurvey master 6135f9e8
2023-02-21 14:33	guest	Note Added: 73901
2023-02-21 14:33	guest	Bug heat	4 => 6
2023-02-21 14:35	ollehar	Status	ready for merge => resolved
2023-02-21 14:35	ollehar	Resolution	open => fixed
2023-02-27 11:34	LimeBot	Note Added: 73955
2023-02-27 11:34	LimeBot	Status	resolved => closed
2023-02-27 11:34	LimeBot	Bug heat	6 => 8