View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
18605Bug reportsSurvey participants (Tokens)public2023-01-25 12:022023-05-22 11:30
Reporterollehar Assigned Togabrieljenik  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Summary18605: Missing success alerts in participant view
Description

Survey particpants

There are multiple missing alerts, e.g. after edit, after add, etc.

Same issue applies in quota view mass actions.

Same issue for assessments.

Same issue for "Global survey settings"

Same issue in survey theme editor after clicking save, or "copy to local"

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)master
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-01-27 17:45

manager   ~73594

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2876

Changes

Survey Participants

Edit

JS createFlash

Add

flash php

Delete

flash php

Mass Delete

AjaxHelper.

Quotas

Mass Activate, Mass Deactivate and Mass Delete

Use "keepopen" = "yes" as it keeps the modal open and displays the html of the ajax response.
It is the method used for the Mass Change Text.

Assessments

Delete

AjaxHelper

Add and Edit

flash php
Transaction to avoid inconsistencies

Global survey settings

Save

flash php

Theme editor

Save changes and Copy to local

php flash.
It is the same message because the only thing that changes is the text of the button, there is no copy action or anything.

Pendings / Other Enhancements identified

Survey Participants

Mass Delete

The display could probably be improved, showing the individual status of each token in the table.
It would probably be necessary to revise the removal process, since we cant get each token individual status through deleteAllByAttributes().

Other

Tokens::delete()
It is not clear where or how it is used. It has other problems beyond the alert.

Quotas

Mass Activate, Mass Deactivate and Mass Delete

To continue improving it would be necessary to make a refactor of Quotas::massiveAction(), which currently executes all the actions.
gabrieljenik

gabrieljenik

2023-04-21 16:38

manager   ~74575

https://github.com/LimeSurvey/LimeSurvey/pull/2876
tibor.pacalat

tibor.pacalat

2023-04-27 16:47

administrator   ~74709

After I add a participant I get this message:
"The survey participant was successfully updated."
instead of "The survey participant was successfully added."

I don't find this solution good: "Use "keepopen" = "yes" as it keeps the modal open and displays the html of the ajax response.
It is the method used for the Mass Change Text." Look at the screenshot attached: First issue, it says "Activate quotas" instead imo "Quotas have been activated" and secondly, the modal looks like there is some info missing below that text.

Other updates look good.

Screenshot 2023-04-27 at 16.12.13.png (41,822 bytes)   
Screenshot 2023-04-27 at 16.12.13.png (41,822 bytes)   
gabrieljenik

gabrieljenik

2023-04-27 17:16

manager   ~74714

the modal looks like there is some info missing below that text.

Probably this got messed when swithcing from v5 to v6
Will review
gabrieljenik

gabrieljenik

2023-05-05 22:16

manager   ~74879

Fixed that @tibor.pacalat
guest

guest

2023-05-15 20:35

viewer   ~75001

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34668
LimeBot

LimeBot

2023-05-22 11:30

administrator   ~75131

Fixed in Release 6.1.0+230522

Related Changesets

LimeSurvey: master 3ee487ba

2023-05-15 22:24

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18605: Missing success alerts in participant view (#2876) Affected Issues
18605
mod - application/controllers/AssessmentController.php Diff File
mod - application/controllers/QuotasController.php Diff File
mod - application/controllers/admin/Themes.php Diff File
mod - application/controllers/admin/Tokens.php Diff File
mod - application/controllers/admin/globalsettings.php Diff File
mod - application/models/Assessment.php Diff File
mod - application/models/services/Quotas.php Diff File
mod - application/views/quotas/viewquotas_massive_selector.php Diff File
mod - assets/scripts/admin/assessments.js Diff File
mod - assets/scripts/admin/tokens.js Diff File

Issue History

Date Modified Username Field Change
2023-01-25 12:02 ollehar New Issue
2023-01-25 12:02 ollehar Priority none => normal
2023-01-25 12:02 ollehar Description Updated
2023-01-25 12:10 ollehar Assigned To => gabrieljenik
2023-01-25 12:10 ollehar Status new => assigned
2023-01-25 14:08 ollehar Description Updated
2023-01-25 14:20 ollehar Description Updated
2023-01-25 15:00 ollehar Description Updated
2023-01-25 15:43 ollehar Description Updated
2023-01-27 17:45 gabrieljenik Assigned To gabrieljenik => ollehar
2023-01-27 17:45 gabrieljenik Status assigned => ready for code review
2023-01-27 17:45 gabrieljenik Note Added: 73594
2023-01-27 17:45 gabrieljenik Bug heat 0 => 2
2023-04-21 16:38 gabrieljenik Note Added: 74575
2023-04-27 16:47 tibor.pacalat Note Added: 74709
2023-04-27 16:47 tibor.pacalat File Added: Screenshot 2023-04-27 at 16.12.13.png
2023-04-27 16:47 tibor.pacalat Bug heat 2 => 4
2023-04-27 17:16 gabrieljenik Note Added: 74714
2023-05-05 22:16 gabrieljenik Note Added: 74879
2023-05-15 20:26 c_schmitz Assigned To ollehar => gabrieljenik
2023-05-15 20:26 c_schmitz Status ready for code review => resolved
2023-05-15 20:26 c_schmitz Resolution open => fixed
2023-05-15 20:35 Changeset attached => LimeSurvey master 3ee487ba
2023-05-15 20:35 guest Note Added: 75001
2023-05-15 20:35 guest Bug heat 4 => 6
2023-05-22 11:30 LimeBot Note Added: 75131
2023-05-22 11:30 LimeBot Status resolved => closed
2023-05-22 11:30 LimeBot Bug heat 6 => 8