View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
18605Bug reportsSurvey participants (Tokens)public2023-01-25 12:022023-01-27 17:45
Reporterollehar Assigned Toollehar  
PrioritynormalSeverityminor 
Status ready for code reviewResolutionopen 
Summary18605: Missing success alerts in participant view
Description

Survey particpants

There are multiple missing alerts, e.g. after edit, after add, etc.

Same issue applies in quota view mass actions.

Same issue for assessments.

Same issue for "Global survey settings"

Same issue in survey theme editor after clicking save, or "copy to local"

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)master
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-01-27 17:45

manager   ~73594

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2876

Changes

Survey Participants

Edit

JS createFlash

Add

flash php

Delete

flash php

Mass Delete

AjaxHelper.

Quotas

Mass Activate, Mass Deactivate and Mass Delete

Use "keepopen" = "yes" as it keeps the modal open and displays the html of the ajax response.
It is the method used for the Mass Change Text.

Assessments

Delete

AjaxHelper

Add and Edit

flash php
Transaction to avoid inconsistencies

Global survey settings

Save

flash php

Theme editor

Save changes and Copy to local

php flash.
It is the same message because the only thing that changes is the text of the button, there is no copy action or anything.

Pendings / Other Enhancements identified

Survey Participants

Mass Delete

The display could probably be improved, showing the individual status of each token in the table.
It would probably be necessary to revise the removal process, since we cant get each token individual status through deleteAllByAttributes().

Other

Tokens::delete()
It is not clear where or how it is used. It has other problems beyond the alert.

Quotas

Mass Activate, Mass Deactivate and Mass Delete

To continue improving it would be necessary to make a refactor of Quotas::massiveAction(), which currently executes all the actions.

Issue History

Date Modified Username Field Change
2023-01-25 12:02 ollehar New Issue
2023-01-25 12:02 ollehar Priority none => normal
2023-01-25 12:02 ollehar Description Updated
2023-01-25 12:10 ollehar Assigned To => gabrieljenik
2023-01-25 12:10 ollehar Status new => assigned
2023-01-25 14:08 ollehar Description Updated
2023-01-25 14:20 ollehar Description Updated
2023-01-25 15:00 ollehar Description Updated
2023-01-25 15:43 ollehar Description Updated
2023-01-27 17:45 gabrieljenik Assigned To gabrieljenik => ollehar
2023-01-27 17:45 gabrieljenik Status assigned => ready for code review
2023-01-27 17:45 gabrieljenik Note Added: 73594
2023-01-27 17:45 gabrieljenik Bug heat 0 => 2