18585: Click again on link by email submit again the survey

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18585	Bug reports	Survey taking	public	2023-01-10 12:27	2023-06-06 17:45

Reporter	DenisChenu	Assigned To	DenisChenu
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	3.28.x

Summary	18585: Click again on link by email submit again the survey
Description	With some condition : if you click again on link by email : survey is submitted a second time without any action (and all submit actin happen :
Steps To Reproduce	Steps to reproduce Create a survey with token answer persistance (anonymous or not) allow multiple allow print create a token to your email send it click on link Submit survey click on link Expected result Survey start at 1st OR show a warning about survey jut submitted Actual result Survey is submitted without any action
Tags	No tags attached.
Attached Files	Peek 10-01-2023 12-13.gif (2,027,189 bytes) Peek 10-01-2023 12-14.gif (1,057,798 bytes)

Bug heat	8
Complete LimeSurvey version number (& build)	3.28.43 and 5.5.2
I will donate to the project if issue is resolved	No
Browser	not relevant
Database type & version	mariadb
Server OS (if known)	debian
Webserver software & version (if known)	nginx or apache
PHP Version	PHP7.4 and 7.2

User List	There are no users monitoring this issue.

DenisChenu 2023-01-10 12:30 developer ~73414	Survey sample Without print : restart survey Without answer persistence : Previous session is set to be finished screen. Think 2 is best solution survey_archive_725785.lsa (5,128 bytes)

ollehar 2023-01-10 12:52 administrator ~73415	Same in LS5?

DenisChenu 2023-01-10 14:06 developer ~73416	Have to test

DenisChenu 2023-01-10 14:09 developer ~73417	Same with LS5

DenisChenu 2023-01-18 14:24 developer ~73492 Last edited: 2023-01-18 14:32	3X : https://github.com/LimeSurvey/LimeSurvey/pull/2850 master : https://github.com/LimeSurvey/LimeSurvey/pull/2851

DenisChenu 2023-01-18 14:27 developer ~73493	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34226

DenisChenu 2023-01-18 14:29 developer ~73494	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34227

LimeBot 2023-01-23 10:35 administrator ~73525	Fixed in Release 5.6.1+230123

DenisChenu 2023-01-23 10:36 developer ~73526	Ready for code review https://github.com/LimeSurvey/LimeSurvey/pull/2850 https://github.com/LimeSurvey/LimeSurvey/pull/2851

tibor.pacalat 2023-06-06 15:25 administrator ~75431	@DenisChenu can you please resolve my comments on PRs? Thanks in advance :)

DenisChenu 2023-06-06 15:27 developer ~75432	PR need to be redone https://github.com/LimeSurvey/LimeSurvey/pull/2850/commits/3a4e1301fe478bae71b6741ac8517d12c5ea0ded

DenisChenu 2023-06-06 15:42 developer ~75439	Yes, i need to redo it form 0 and for 3, 5 and 6.

DenisChenu 2023-06-06 16:36 developer ~75442	5.X : https://github.com/LimeSurvey/LimeSurvey/commit/b9d27a514b5bd8665603e6522fced67ed54d9c88 master : https://github.com/LimeSurvey/LimeSurvey/commit/b9d27a514b5bd8665603e6522fced67ed54d9c88 Then… it's already fixed … Really happy to work for such situation …

DenisChenu 2023-06-06 16:37 developer ~75443	https://github.com/LimeSurvey/LimeSurvey/pull/3193

DenisChenu 2023-06-06 17:44 developer ~75449	Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34783

tibor.pacalat 2023-06-06 17:45 administrator ~75450	tested and merged

LimeSurvey: master bd86ce3d 2023-01-18 14:27:15 DenisChenu Details Diff	Fixed issue 18585: Click again on link by email submit again the survey Dev: reset session in all condition, reload page or click on link : start again.	Affected Issues 18585
	mod - application/controllers/survey/index.php	Diff File
LimeSurvey: master d5429f45 2023-01-18 14:28:55 DenisChenu Details Diff	Revert "Fixed issue 18585: Click again on link by email submit again the survey" This reverts commit bd86ce3d3ec0d59ab55a11eab8c8ca753b2fd82f.	Affected Issues 18585
	mod - application/controllers/survey/index.php	Diff File
LimeSurvey: 3.x-LTS f3ba48c0 2023-06-06 17:44:30 DenisChenu Committer: GitHub Details Diff	Fixed issue 18585: Click again on link by email submit again the survey (#3193) Dev: reset session in all condition, reload page or click on link : start again.	Affected Issues 18585
	mod - application/controllers/survey/index.php	Diff File

Date Modified	Username	Field	Change
2023-01-10 12:27	DenisChenu	New Issue
2023-01-10 12:27	DenisChenu	File Added: Peek 10-01-2023 12-13.gif
2023-01-10 12:27	DenisChenu	File Added: Peek 10-01-2023 12-14.gif
2023-01-10 12:30	DenisChenu	Note Added: 73414
2023-01-10 12:30	DenisChenu	File Added: survey_archive_725785.lsa
2023-01-10 12:30	DenisChenu	Bug heat	0 => 2
2023-01-10 12:52	ollehar	Note Added: 73415
2023-01-10 12:52	ollehar	Bug heat	2 => 4
2023-01-10 14:06	DenisChenu	Note Added: 73416
2023-01-10 14:09	DenisChenu	Note Added: 73417
2023-01-10 14:10	DenisChenu	Assigned To	=> DenisChenu
2023-01-10 14:10	DenisChenu	Status	new => assigned
2023-01-10 14:10	DenisChenu	Complete LimeSurvey version number (& build)	3.28.43 => 3.28.43 and 5.5.2
2023-01-10 14:53	ollehar	Priority	none => normal
2023-01-18 14:24	DenisChenu	Note Added: 73492
2023-01-18 14:27	DenisChenu	Changeset attached	=> LimeSurvey master bd86ce3d
2023-01-18 14:27	DenisChenu	Note Added: 73493
2023-01-18 14:27	DenisChenu	Resolution	open => fixed
2023-01-18 14:29	DenisChenu	Changeset attached	=> LimeSurvey master d5429f45
2023-01-18 14:29	DenisChenu	Note Added: 73494
2023-01-18 14:32	DenisChenu	Note Edited: 73492
2023-01-18 14:32	DenisChenu	Assigned To	DenisChenu =>
2023-01-18 14:32	DenisChenu	Status	assigned => ready for code review
2023-01-23 10:35	LimeBot	Note Added: 73525
2023-01-23 10:35	LimeBot	Status	ready for code review => closed
2023-01-23 10:35	LimeBot	Bug heat	4 => 6
2023-01-23 10:36	DenisChenu	Status	closed => ready for code review
2023-01-23 10:36	DenisChenu	Note Added: 73526
2023-06-06 15:25	tibor.pacalat	Note Added: 75431
2023-06-06 15:25	tibor.pacalat	Bug heat	6 => 8
2023-06-06 15:27	DenisChenu	Assigned To	=> DenisChenu
2023-06-06 15:27	DenisChenu	Status	ready for code review => new
2023-06-06 15:27	DenisChenu	Status	new => feedback
2023-06-06 15:27	DenisChenu	Note Added: 75432
2023-06-06 15:42	DenisChenu	Note Added: 75439
2023-06-06 16:36	DenisChenu	Note Added: 75442
2023-06-06 16:37	DenisChenu	Note Added: 75443
2023-06-06 16:37	DenisChenu	Assigned To	DenisChenu => tibor.pacalat
2023-06-06 16:37	DenisChenu	Status	feedback => ready for testing
2023-06-06 17:44	DenisChenu	Changeset attached	=> LimeSurvey 3.x-LTS f3ba48c0
2023-06-06 17:44	DenisChenu	Note Added: 75449
2023-06-06 17:44	DenisChenu	Assigned To	tibor.pacalat => DenisChenu
2023-06-06 17:45	tibor.pacalat	Status	ready for testing => closed
2023-06-06 17:45	tibor.pacalat	Note Added: 75450

View Issue Details

Steps to reproduce

Expected result

Actual result

Users monitoring this issue

Activities

Related Changesets

Issue History