View Issue Details

Jump to NotesJump to History
This bug affects 2 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
18574Bug reportsTheme editorpublic2022-12-30 15:592024-06-07 13:11
Reportergabrieljenik Assigned Top_teichmann  
PriorityhighSeveritypartial_block 
Status assignedResolutionopen 
Summary18574: Fruity: If a variation is selected at survey level, custom.css is not loaded as expected
Description

Using an extended version of a fruity theme.
If a variation is selected at survey level, the custom.css from the extended version is not loaded, but the custom.css from the parent one.

Steps To Reproduce

Steps to reproduce

Extend Fruity
Add a rule on custom.css
Use it on a survey.
Set a variation at survey level (Ex: black pearl)

Expected result

rule is loaded and applied.

Actual result

rule is not loaded as the custom.css from the extended theme is not loaded.

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)5.4.15
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Users monitoring this issue

There are no users monitoring this issue.

Activities

p_teichmann

p_teichmann

2023-07-18 14:26

administrator   ~76134

Last edited: 2023-07-18 14:29

This is actually quite important, since it doesn't just produce issues with the custom.css, but every file that is added or removed through the theme config. When selecting a variation on survey level it will completely remove the string and only add the new theme.css file.

The only reason why it is working on the global survey theme level is because the string is prefilled and the javascript only then replaces the themename with the new one, however this is not the case for the local survey theme config. The default there is "inherit" and not the actual config json that is displayed on global level.
gabrieljenik

gabrieljenik

2023-08-18 15:09

manager   ~76645

Last edited: 2023-08-18 15:11

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3374

This should be tested with 2 level themes and maybe 3 levels as well.
Also with the survey theme options.
tibor.pacalat

tibor.pacalat

2023-10-13 15:34

administrator   ~77701

@p_teichmann can you review Gabriel's PR please?
p_teichmann

p_teichmann

2023-11-01 16:18

administrator   ~78201

Last edited: 2023-11-01 16:24

@gabrieljenik added a comment in the PR, when switching back to inherit the values get not correctly set. The fix was originally for master so should also be in ls6.

Issue History

Date Modified Username Field Change
2022-12-30 15:59 gabrieljenik New Issue
2022-12-30 15:59 gabrieljenik Status new => confirmed
2023-02-16 16:41 gabrieljenik Assigned To => gabrieljenik
2023-02-16 16:41 gabrieljenik Status confirmed => assigned
2023-07-18 14:26 p_teichmann Note Added: 76134
2023-07-18 14:26 p_teichmann Bug heat 0 => 2
2023-07-18 14:27 p_teichmann Priority none => high
2023-07-18 14:29 p_teichmann Note Edited: 76134
2023-08-18 15:09 gabrieljenik Status assigned => ready for code review
2023-08-18 15:09 gabrieljenik Note Added: 76645
2023-08-18 15:09 gabrieljenik Bug heat 2 => 4
2023-08-18 15:11 gabrieljenik Note Edited: 76645
2023-09-11 19:41 gabrieljenik Assigned To gabrieljenik => p_teichmann
2023-10-13 15:34 tibor.pacalat Note Added: 77701
2023-10-13 15:34 tibor.pacalat Bug heat 4 => 6
2023-11-01 15:40 p_teichmann Status ready for code review => in code review
2023-11-01 16:18 p_teichmann Note Added: 78201
2023-11-01 16:24 p_teichmann Note Edited: 78201
2023-11-07 13:29 p_teichmann Assigned To p_teichmann => gabrieljenik
2023-11-07 13:29 p_teichmann Status in code review => assigned
2024-06-07 13:11 tibor.pacalat Assigned To gabrieljenik => p_teichmann
2024-08-06 14:39 Dennis Bug heat 6 => 12