View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 12
IDProjectCategoryView StatusDate SubmittedLast Update
18443Bug reportsOtherpublic2022-11-03 10:242024-09-09 18:36
ReporterNickko Assigned ToDenisChenu  
PrioritynormalSeverityblock 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18443: Optional questions not working without "popup"
Description

If I choose something other than "Show popups" in "theme settings", the user can leave "optional question" unanswered.

Steps To Reproduce

Steps to reproduce

Create a survey, add a group and an optional question.
Go to "theme settings" and choose something other than "Show popups".
Activate and run the survey.
Don't answere the optionnal question and click submit button.
The error appears.

Expected result

When I choose "onepage" I expect a popin appear
When I choose "non" I expect a block in the page who ask to anwsere or to continue whitout answering.

Actual result

The user is blocked or has to answer the question he did not want to answer.

TagsNo tags attached.
Bug heat12
Complete LimeSurvey version number (& build)5.4.9+221101
I will donate to the project if issue is resolvedNo
BrowserVivaldi (like Chrome) last version.
Database type & versionMySQL
Server OS (if known)Apache (OVH shared hosting)
Webserver software & version (if known)
PHP VersionPHP 8.1

Relationships

Relationship GraphDependency Graph
related to 18332 closedDenisChenu Feature requests Mandatory soft must be related to Question not Page 
related to 19534 closedDenisChenu Bug reports Survey cannot be submitted if "soft force" options are used and "full index" is active 

Users monitoring this issue

DenisChenu

Activities

ollehar

ollehar

2022-11-03 10:26

administrator   ~72518

Hm, which setting is "Show popups"? Screenshot?
Nickko

Nickko

2022-11-03 10:49

updater   ~72519

I add the requested screenshot.

2022-11-03 10.48.50 survey.usability.fr 8f156f764833.png (90,006 bytes)   
2022-11-03 10.48.50 survey.usability.fr 8f156f764833.png (90,006 bytes)   
ollehar

ollehar

2022-11-03 11:35

administrator   ~72522

Never tested this setting, I'm sorry to say. Would have to ask @gabrieljenik or @DenisChenu to have a look.
DenisChenu

DenisChenu

2022-11-03 11:37

developer   ~72523

Never tested this setting

Tester must really test and use ;)

Before (2.6lts) it was only globally if i remind
Nickko

Nickko

2022-11-03 11:38

updater   ~72524

Denis confirm the problem on the french forum: https://forums.limesurvey.org/forum/french-forum/128526-questions-non-contraignantes-contraignantes
DenisChenu

DenisChenu

2023-03-28 19:25

developer   ~74300

Need https://github.com/LimeSurvey/LimeSurvey/pull/2825 merged before working on this one.
DenisChenu

DenisChenu

2024-09-04 11:46

developer   ~80892

https://github.com/LimeSurvey/LimeSurvey/pull/3950

Did we need a test ?
DenisChenu

DenisChenu

2024-09-05 11:10

developer   ~80911

You must test both issue with same commit :)
DenisChenu

DenisChenu

2024-09-09 14:00

developer   ~80925

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36542
tibor.pacalat

tibor.pacalat

2024-09-09 14:00

administrator   ~80927

Tested and merged!
LimeBot

LimeBot

2024-09-09 18:36

administrator   ~80943

Fixed in Release 6.6.3+240909

Related Changesets

LimeSurvey: master 5d559e19

2024-09-09 14:00:17

DenisChenu


Committer: GitHub Details Diff 		Fixed issue 19534: Survey cannot be submitted if "soft force" options are used and "full index" is active (#3950)

* Fixed issue 18443: Optional questions not working without "popup"
* Fixed issue: Optional questions not working without javascript
* Fixed issue 18332: Mandatory soft must be related to Question not Page		 Affected Issues
18332, 18443, 19534
mod - application/helpers/expressions/em_manager_helper.php Diff File
add - application/views/survey/questions/question_help/softmandatory_input.twig Diff File
mod - themes/survey/fruity_twentythree/scripts/theme.js Diff File
mod - themes/survey/vanilla/views/subviews/messages/bootstrap_alert_modal.twig Diff File
mod - themes/survey/vanilla/views/subviews/navigation/navigator.twig Diff File

Issue History

Date Modified Username Field Change
2022-11-03 10:24 Nickko New Issue
2022-11-03 10:26 ollehar Note Added: 72518
2022-11-03 10:26 ollehar Bug heat 0 => 2
2022-11-03 10:27 ollehar Assigned To => ollehar
2022-11-03 10:27 ollehar Status new => feedback
2022-11-03 10:49 Nickko Note Added: 72519
2022-11-03 10:49 Nickko File Added: 2022-11-03 10.48.50 survey.usability.fr 8f156f764833.png
2022-11-03 10:49 Nickko Bug heat 2 => 4
2022-11-03 10:49 Nickko Status feedback => assigned
2022-11-03 11:35 ollehar Note Added: 72522
2022-11-03 11:35 ollehar Priority none => normal
2022-11-03 11:36 DenisChenu Assigned To ollehar => DenisChenu
2022-11-03 11:37 DenisChenu Note Added: 72523
2022-11-03 11:37 DenisChenu Bug heat 4 => 6
2022-11-03 11:38 Nickko Note Added: 72524
2023-03-28 19:25 DenisChenu Note Added: 74300
2023-05-19 13:43 DenisChenu Relationship added related to 18332
2024-06-13 10:14 DenisChenu Assigned To DenisChenu =>
2024-06-13 10:14 DenisChenu Status assigned => new
2024-06-13 10:14 DenisChenu Issue Monitored: DenisChenu
2024-06-13 10:14 DenisChenu Bug heat 6 => 8
2024-08-29 19:09 DenisChenu Assigned To => DenisChenu
2024-08-29 19:09 DenisChenu Status new => assigned
2024-09-04 11:46 DenisChenu Assigned To DenisChenu => gabrieljenik
2024-09-04 11:46 DenisChenu Status assigned => ready for code review
2024-09-04 11:46 DenisChenu Note Added: 80892
2024-09-04 11:47 DenisChenu Relationship added related to 19534
2024-09-05 11:10 DenisChenu Assigned To gabrieljenik => tibor.pacalat
2024-09-05 11:10 DenisChenu Status ready for code review => ready for testing
2024-09-05 11:10 DenisChenu Note Added: 80911
2024-09-09 14:00 DenisChenu Changeset attached => LimeSurvey master 5d559e19
2024-09-09 14:00 DenisChenu Note Added: 80925
2024-09-09 14:00 DenisChenu Assigned To tibor.pacalat => DenisChenu
2024-09-09 14:00 DenisChenu Resolution open => fixed
2024-09-09 14:00 tibor.pacalat Status ready for testing => resolved
2024-09-09 14:00 tibor.pacalat Note Added: 80927
2024-09-09 14:00 tibor.pacalat Bug heat 8 => 10
2024-09-09 18:36 LimeBot Note Added: 80943
2024-09-09 18:36 LimeBot Status resolved => closed
2024-09-09 18:36 LimeBot Bug heat 10 => 12