View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18414 | Bug reports | Translation | public | 2022-10-13 12:43 | 2022-11-01 10:59 |
Reporter | Mazi | Assigned To | gabrieljenik | ||
Priority | high | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.4.x | ||||
Summary | 18414: "Add line" button label can not be translated | ||||
Description | At the LS 5.x multi short text question type which allows adding new lines using the "Add line" button, the button label does not seem to be available for trasnlation. | ||||
Steps To Reproduce | Steps to reproduceCreate a 1 question survey with multi text dynamic question type in non-English language. Run the survey and check the button label. Expected result"Add line" should be available for translations at https://translate.limesurvey.org/projects/limesurvey-4 Actual resultNo translation available, the label is always shown in English. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 5.4.3 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MariaDB 10.1.48 | ||||
Server OS (if known) | Ubuntu 20 | ||||
Webserver software & version (if known) | Apache | ||||
PHP Version | 7.4 | ||||
related to | 18437 | acknowledged | Untranslatable texts on Fruity settings |
Some information on how to fix it: This is a console command to create/compile temporary .php files from the twig files to the twig_cache directory, where they are then picked up by our translation tools. You can run it this way:
|
|
Gabriel, please extend generateTwigTmpFiles so it properly creates the tmp files for all twig files.. "Add line" was just an example - I bet there are more strings that are currently not picked up and also this will avoid to have all strings duplicated in a normal PHP file. |
|
Got it! Sorry :) |
|
PR 2674 is replaced by PR 2678, which is a broader and more general solution. |
|
On some comments in the code, it is mentioned that some twig files may not be reached by the temp rendering process. An alternative solution for that could be to just scan the twig files and render all of them. |
|
@c_schmitz : maybe you want to review too ? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33997 |
|
I believe this could be a good enhancement for the future: Also, maybe we can parse question themes XML for translating question attributes as well. New ticket? |
|
Fixed in Release 5.4.9+221101 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2022-10-13 12:43 | Mazi | New Issue | |
2022-10-13 14:28 | c_schmitz | Note Added: 72232 | |
2022-10-13 14:28 | c_schmitz | Bug heat | 0 => 2 |
2022-10-13 14:28 | c_schmitz | Note Edited: 72232 | |
2022-10-13 14:29 | c_schmitz | Assigned To | => gabrieljenik |
2022-10-13 14:29 | c_schmitz | Status | new => assigned |
2022-10-13 14:32 | c_schmitz | Priority | none => high |
2022-10-13 14:33 | c_schmitz | Note Edited: 72232 | |
2022-10-13 17:01 | c_schmitz | Note Edited: 72232 | |
2022-10-17 22:14 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2022-10-17 22:14 | gabrieljenik | Status | assigned => ready for code review |
2022-10-17 22:14 | gabrieljenik | Note Added: 72311 | |
2022-10-17 22:14 | gabrieljenik | Bug heat | 2 => 4 |
2022-10-18 08:18 | DenisChenu | Assigned To | DenisChenu => |
2022-10-18 08:18 | DenisChenu | Status | ready for code review => ready for testing |
2022-10-18 16:34 | c_schmitz | Assigned To | => gabrieljenik |
2022-10-18 16:34 | c_schmitz | Note Added: 72338 | |
2022-10-18 16:36 | c_schmitz | Note Edited: 72338 | |
2022-10-18 16:36 | c_schmitz | Status | ready for testing => assigned |
2022-10-18 16:45 | gabrieljenik | Note Added: 72342 | |
2022-10-19 16:23 | gabrieljenik | Note Added: 72365 | |
2022-10-19 16:24 | gabrieljenik | Note Added: 72366 | |
2022-10-19 16:35 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2022-10-19 16:35 | gabrieljenik | Status | assigned => ready for code review |
2022-10-25 09:00 | DenisChenu | Assigned To | DenisChenu => |
2022-10-25 09:00 | DenisChenu | Status | ready for code review => ready for testing |
2022-10-25 09:00 | DenisChenu | Note Added: 72397 | |
2022-10-25 09:00 | DenisChenu | Bug heat | 4 => 6 |
2022-10-26 10:28 | c_schmitz | Assigned To | => gabrieljenik |
2022-10-26 10:52 | gabrieljenik | Changeset attached | => LimeSurvey master c13e1723 |
2022-10-26 10:52 | gabrieljenik | Note Added: 72431 | |
2022-10-26 10:52 | gabrieljenik | Resolution | open => fixed |
2022-10-26 11:06 | c_schmitz | Status | ready for testing => resolved |
2022-10-26 15:36 | gabrieljenik | Note Added: 72434 | |
2022-10-31 14:08 | gabrieljenik | Relationship added | related to 18437 |
2022-11-01 10:59 | LimeBot | Note Added: 72504 | |
2022-11-01 10:59 | LimeBot | Status | resolved => closed |
2022-11-01 10:59 | LimeBot | Bug heat | 6 => 8 |