View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18362 | Bug reports | Other | public | 2022-09-20 11:49 | 2024-09-04 11:59 |
Reporter | DenisChenu | Assigned To | c_schmitz | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | unable to reproduce | ||
Product Version | 5.4.x | ||||
Summary | 18362: Update from 3.X broke with question theme | ||||
Description | When update via console : error throw with some question theme | ||||
Steps To Reproduce | Steps to reproduceHave some old question theme in directory Expected resultUpdate until last DB Actual resultE:\WebSite\limesurvey>php application/commands/console.php updatedb | ||||
Tags | No tags attached. | ||||
Bug heat | 4 | ||||
Complete LimeSurvey version number (& build) | 5.4.1 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | MSSQL | ||||
Server OS (if known) | windows | ||||
Webserver software & version (if known) | IIS | ||||
PHP Version | 7.2.16 | ||||
Fixed with !empty($oThemeConfig->compatibility->version) at https://github.com/LimeSurvey/LimeSurvey/blob/e871bea897585edf28de26d0723bf02d746210f7/application/models/QuestionTheme.php#L893 |
|
After the quick fix : E:\WebSite\limesurvey>php application/commands/console.php updatedb I delete all theme in upload/theme/question and let it go … My opinion : Do not try to update automatically question theme, just check if it's compatible , if not : uninstal. |
|
I just checked with an upgrade from 3 to 6 and could not reproduce anymore, so I guess it is fixed. |
|
yes : seems there are a fix https://github.com/LimeSurvey/LimeSurvey/blob/056ef5fc47c95ee8a06f34c7f7db4fe9d7024b78/application/models/QuestionTheme.php#L901 |
|
PS : still think than updating config.xml file are a bad idea. We know than between 3 and 5 : there are no real Question/ Survey theme compatibility … |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2022-09-20 11:49 | DenisChenu | New Issue | |
2022-09-20 11:50 | DenisChenu | Note Added: 71848 | |
2022-09-20 11:50 | DenisChenu | Bug heat | 0 => 2 |
2022-09-20 11:52 | DenisChenu | Note Added: 71849 | |
2022-09-24 00:00 | gabrieljenik | Status | new => acknowledged |
2024-09-04 10:15 | c_schmitz | Assigned To | => c_schmitz |
2024-09-04 10:15 | c_schmitz | Status | acknowledged => closed |
2024-09-04 10:15 | c_schmitz | Resolution | open => unable to reproduce |
2024-09-04 10:15 | c_schmitz | Note Added: 80891 | |
2024-09-04 10:15 | c_schmitz | Bug heat | 2 => 4 |
2024-09-04 11:58 | DenisChenu | Note Added: 80894 | |
2024-09-04 11:59 | DenisChenu | Note Added: 80895 |