View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
18339Bug reportsRemoteControlpublic2022-09-09 00:352024-11-19 18:14
Reporterjared.kail Assigned Totibor.pacalat  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18339: Need Way to Modify Question Props in question_l10ns
Description

Using the array ["questiongroupl10ns"=>["en" => ["group_name"=>"xyz", "description"=>"abc"]] I can modify a group's entries in the questiongroupl10ns table. This allows me to modify the group's information "on the fly" from remote control's set_group_properties call.

However, set_question_properties does not modify the question_l10ns in a similar manner, leaving me with no choice but to go after the tables manually via SQL [insert shudder here]. set_question_properties needs to be enhanced to support the question_l10ns table attributes.

Steps To Reproduce

Steps to reproduce

call set_question_properties and try to modify the question's "question" or "help" text.

Expected result

set_question_properties should set the text into the question.

Actual result

Text not set.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)Version 5.3.32+220817
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2022-09-15 11:31

administrator   ~71762

Feel free to do a pull request.
tibor.pacalat

tibor.pacalat

2023-10-02 17:27

administrator   ~77473

https://github.com/LimeSurvey/LimeSurvey/pull/3482
tibor.pacalat

tibor.pacalat

2023-10-02 17:29

administrator   ~77474

@gabrieljenik this was submitted for 5.x, do we need to port your fix there as well?
gabrieljenik

gabrieljenik

2023-10-02 21:43

manager   ~77480

No initial done for develop. Not sure if this is a fit for v5. Just let me know.
tibor.pacalat

tibor.pacalat

2023-10-10 12:27

administrator   ~77600

@gabrieljenik I tested your PR, looks good. I don't know if we need to add some documentation for it or not.
Why do you think this is not a fit for 5.x?
gabrieljenik

gabrieljenik

2023-10-10 14:31

manager   ~77606

I don't know if we need to add some documentation for it or not.

We ported the behaviour from set_group_properties.
There is no documentation there related to l10n

Why do you think this is not a fit for 5.x?

Developments and enhancements are not done for 5x usually.
guest

guest

2023-12-18 12:49

viewer   ~79026

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35925

Related Changesets

LimeSurvey: master d0722b31

2023-10-10 14:25

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18339: Need Way to Modify Question Props in question_l10ns (#3482)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18339
mod - application/helpers/remotecontrol/remotecontrol_handle.php Diff File
add - tests/unit/helpers/remotecontrol/QuestionPropertiesTest.php Diff File

Issue History

Date Modified Username Field Change
2022-09-09 00:35 jared.kail New Issue
2022-09-15 11:31 ollehar Note Added: 71762
2022-09-15 11:31 ollehar Bug heat 0 => 2
2022-09-23 23:57 gabrieljenik Severity feature => partial_block
2022-09-23 23:57 gabrieljenik Status new => acknowledged
2023-08-31 19:09 gabrieljenik Assigned To => gabrieljenik
2023-08-31 19:09 gabrieljenik Status acknowledged => assigned
2023-10-02 15:27 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-10-02 17:27 tibor.pacalat Status assigned => in testing
2023-10-02 17:27 tibor.pacalat Note Added: 77473
2023-10-02 17:27 tibor.pacalat Bug heat 2 => 4
2023-10-02 17:29 tibor.pacalat Note Added: 77474
2023-10-02 21:43 gabrieljenik Note Added: 77480
2023-10-02 21:43 gabrieljenik Bug heat 4 => 6
2023-10-10 12:27 tibor.pacalat Note Added: 77600
2023-10-10 14:31 gabrieljenik Note Added: 77606
2023-10-10 14:36 tibor.pacalat Status in testing => resolved
2023-10-10 14:36 tibor.pacalat Resolution open => fixed
2023-12-18 12:49 Changeset attached => LimeSurvey master d0722b31
2023-12-18 12:49 guest Note Added: 79026
2023-12-18 12:49 guest Bug heat 6 => 8
2024-11-19 18:14 c_schmitz Status resolved => closed