View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
18278Bug reportsTranslationpublic2022-07-26 17:402023-07-31 15:02
Reportergabrieljenik Assigned Totibor.pacalat  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18278: Quick translation: "Nothing to Translate" appears wrongly
Description

Technically speaking, right now the message "Nothing to Translate" appears when the items to translate are empty (have no text).

This should/could happen in 2 situations:

  • There are no elements to display in the tab
  • All elements in the tab are empty (have no text)

There is a bug in the implementation of the 2nd case.
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/views/quickTranslation/translatetabs_view.php#L68

This was caught while reviewing 18242

Steps To Reproduce

Steps

Have a surey with 2 question groups
Set text to the second group only. First one should be blank.
Go to quick translate

(Check attachment)

Expected

Should be somethign to translate

Happens

Doens't appears
‌

Note:

  • The same happens with questions.
TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)5.3.23+220705
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5.6.51-log
Server OS (if known)
Webserver software & version (if known)
PHP Version7.2.24-0ubuntu0.18.04.12

Relationships

Relationship GraphDependency Graph
related to 18242 closedgabrieljenik Quick translation: end note not shown 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-07-20 21:11

manager   ~76202

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3296

surveys_archive (7).zip (5,749 bytes)
DenisChenu

DenisChenu

2023-07-21 16:34

developer   ~76229

Checking the survey archives in master : i can not find any tab with «Nothing to Translate»
(i see it on 3.X on another surveys)
tibor.pacalat

tibor.pacalat

2023-07-27 17:45

administrator   ~76313

I confirmed that before the fix "nothing to translate" was visible. After the fix it is only on the pages where there is nothing to translate.

Screenshot 2023-07-27 at 17.42.15.png (64,948 bytes)   
Screenshot 2023-07-27 at 17.42.15.png (64,948 bytes)   
Screenshot 2023-07-27 at 17.42.09.png (50,028 bytes)   
Screenshot 2023-07-27 at 17.42.09.png (50,028 bytes)   
tibor.pacalat

tibor.pacalat

2023-07-27 17:46

administrator   ~76314

Tested and merged.
guest

guest

2023-07-27 18:30

viewer   ~76315

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35278
LimeBot

LimeBot

2023-07-31 15:02

administrator   ~76374

Fixed in Release 6.2.0+230732

Related Changesets

LimeSurvey: master bf81965b

2023-07-27 19:46

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18278: Quick translation - "Nothing to translate" appears wrongly (#3296)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18278
mod - application/views/quickTranslation/translatetabs_view.php Diff File

Issue History

Date Modified Username Field Change
2022-07-26 17:40 gabrieljenik New Issue
2022-07-26 17:40 gabrieljenik Issue generated from: 18242
2022-07-26 17:40 gabrieljenik Status new => confirmed
2022-08-03 18:21 gabrieljenik Relationship added related to 18242
2023-07-20 21:09 gabrieljenik Description Updated
2023-07-20 21:09 gabrieljenik Steps to Reproduce Updated
2023-07-20 21:11 gabrieljenik Note Added: 76202
2023-07-20 21:11 gabrieljenik File Added: surveys_archive (7).zip
2023-07-20 21:11 gabrieljenik Bug heat 0 => 2
2023-07-20 21:11 gabrieljenik Assigned To => DenisChenu
2023-07-20 21:11 gabrieljenik Status confirmed => ready for code review
2023-07-20 21:12 gabrieljenik Steps to Reproduce Updated
2023-07-21 16:34 DenisChenu Note Added: 76229
2023-07-21 16:34 DenisChenu Bug heat 2 => 4
2023-07-24 17:57 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-07-24 17:57 DenisChenu Status ready for code review => ready for testing
2023-07-27 17:45 tibor.pacalat Note Added: 76313
2023-07-27 17:45 tibor.pacalat File Added: Screenshot 2023-07-27 at 17.42.15.png
2023-07-27 17:45 tibor.pacalat File Added: Screenshot 2023-07-27 at 17.42.09.png
2023-07-27 17:45 tibor.pacalat Bug heat 4 => 6
2023-07-27 17:46 tibor.pacalat Status ready for testing => resolved
2023-07-27 17:46 tibor.pacalat Resolution open => fixed
2023-07-27 17:46 tibor.pacalat Note Added: 76314
2023-07-27 18:30 Changeset attached => LimeSurvey master bf81965b
2023-07-27 18:30 guest Note Added: 76315
2023-07-27 18:30 guest Bug heat 6 => 8
2023-07-31 15:02 LimeBot Note Added: 76374
2023-07-31 15:02 LimeBot Status resolved => closed
2023-07-31 15:02 LimeBot Bug heat 8 => 10