View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 2 person(s).
 20
IDProjectCategoryView StatusDate SubmittedLast Update
18276Bug reportsSurvey takingpublic2022-07-26 15:452022-07-28 10:38
Reportertpartner Assigned Toollehar  
PrioritynoneSeveritycrash 
Status closedResolutionreopened 
Product Version5.3.x 
Summary18276: Changed HTML in arrays destroys JavaScript and CSS.
Description

Changing the HTML table header elements in array questions from <th> to <td> renders MANY JavaScript workarounds and custom styles useless. Why was this HTML changed in a minor version update?

This was apparently done to fix issue 18243 but for some reason I am denied access to that issue.

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat20
Complete LimeSurvey version number (& build)5.3.27
I will donate to the project if issue is resolvedNo
Browsern/a
Database type & versionlibmysql - mysqlnd 5.0.12-dev
Server OS (if known)Windows 10
Webserver software & version (if known)Apache/2.4.39 (Win64)
PHP Version7.3.7

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2022-07-26 15:49

administrator   ~71142

Have fun arguing with @DenisChenu about that......
tpartner

tpartner

2022-07-26 15:52

partner   ~71143

HTML cannot be arbitrarily changed in minor version updates. If it's a problem it should have waited until 6.x.
ecoplan

ecoplan

2022-07-26 15:58

reporter   ~71144

Thanks tpartner for bug reporting and thus transferring my forum post to the bug reports.
ollehar

ollehar

2022-07-26 15:59

administrator   ~71145

@tpartner Can't you rely on classes and ids instead of tags?
tpartner

tpartner

2022-07-26 16:04

partner   ~71146

Yes, sure if I re-write everything!
tpartner

tpartner

2022-07-26 16:05

partner   ~71147

Last edited: 2022-07-26 16:07

...and to be clear, this is not about me, it's about anyone who has used the th selector in JS, CSS, custom question themes. The fact that we already have a report in the forum a day after release is telling.
ollehar

ollehar

2022-07-26 16:13

administrator   ~71148

Sure sure. Let's see what Denis says.
jelo

jelo

2022-07-26 16:18

partner   ~71149

Before arguing with anyone, I would like to know the reasoning behind this change.
Is the update stopped and a warning placed?
ollehar

ollehar

2022-07-26 16:20

administrator   ~71150

the reasoning behind this change

Only Denis can answer that.

Is the update stopped and a warning placed?

No.
tpartner

tpartner

2022-07-26 16:21

partner   ~71151

I think it needs to be reverted and then discussed.
DenisChenu

DenisChenu

2022-07-26 16:44

developer   ~71152

Have fun arguing with @DenisChenu about that......

It's to fix «18243: ARIA Attribute role on Array question not correct.»

Yes it broke API for SurveyTheme …
We can not have accessibility (have fieldset replacer (by role="radiogroup") and th at same time …

We have same issue here : https://bugs.limesurvey.org/view.php?id=18211 18211: List (Radio) questions columns not in one (ul) tag.
https://github.com/LimeSurvey/LimeSurvey/pull/2481

Solution ?
I don't have clean one …
ollehar

ollehar

2022-07-26 16:53

administrator   ~71153

Yes it broke API for SurveyTheme …

Ehm, if you knew it, why didn't you put it in dev branch?
DenisChenu

DenisChenu

2022-07-26 16:58

developer   ~71154

Please read https://bugs.limesurvey.org/view.php?id=18243 history …

This one broke HTML validity and was not in dev branch https://github.com/LimeSurvey/LimeSurvey/pull/2504

My fault : don't put the alert sooner or clearer, you're right. Sorry for this.
tpartner

tpartner

2022-07-26 17:12

partner   ~71155

Is it going to be reverted?
DenisChenu

DenisChenu

2022-07-26 17:33

developer   ~71156

Discord :
DenisChenu
—
Aujourd’hui à 14:58
Must check with @Carsten about the fix for table then
I can redo fix for dev : not an issue
Vacation next week
jelo

jelo

2022-07-26 17:45

partner   ~71157

Isn't Carsten on vacation for two weeks?
Stop the update. Release a newer one without that "fix" to prevent real mess in the next days.
ollehar

ollehar

2022-07-26 17:52

administrator   ~71158

Hm, Carsten reported the fixed issue as "blocking", no idea why. Maybe we had a customer with problems. So reverting it would block that person again, I guess.
gabrieljenik

gabrieljenik

2022-07-26 18:03

manager   ~71160

This one broke HTML validity and was not in dev branch https://github.com/LimeSurvey/LimeSurvey/pull/2504

I was just fixing specifically what reported on the issue.
About breaking validity, please see more comments here.
https://github.com/LimeSurvey/LimeSurvey/pull/2504#issuecomment-1195674640

Thanks
ollehar

ollehar

2022-07-26 18:05

administrator   ~71161

I'll have to continue this tomorrow. Let's see then.
ollehar

ollehar

2022-07-27 11:28

administrator   ~71166

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33683
ollehar

ollehar

2022-07-27 11:28

administrator   ~71168

Pushed a revert, will release after github actions is green.
tpartner

tpartner

2022-07-27 11:46

partner   ~71169

Thanks @ollehar.
LimeBot

LimeBot

2022-07-27 11:48

administrator   ~71170

Fixed in Release 5.3.28+220727
ollehar

ollehar

2022-07-27 11:49

administrator   ~71175

Please test the latest release, @tpartner.
tpartner

tpartner

2022-07-27 13:12

partner   ~71177

@ollehar, tested - all good. Thanks.
DenisChenu

DenisChenu

2022-07-28 10:38

developer   ~71218

https://bugs.limesurvey.org/view.php?id=18292

Related Changesets

LimeSurvey: master 167f2d46

2022-07-27 13:27

ollehar


Details Diff		 Fixed issue 18276: Changed HTML in arrays causing issues with JavaScript and CSS.

Revert "Fixed issue 18243: ARIA Attribute role on Array question not correct. (#2512)"

This reverts commit d820a52b72ddbb5abadd7b007ff65ee0e2d0d9d7.		 Affected Issues
18243, 18276
mod - application/views/survey/questions/answer/arrays/10point/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/10point/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/10point/rows/cells/answer_td_input.twig Diff File
mod - application/views/survey/questions/answer/arrays/5point/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/5point/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/5point/rows/cells/answer_td_input.twig Diff File
mod - application/views/survey/questions/answer/arrays/array/dropdown/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/array/dropdown/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/array/no_dropdown/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/array/no_dropdown/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/array/no_dropdown/rows/cells/answer_td.twig Diff File
mod - application/views/survey/questions/answer/arrays/column/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/dualscale/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/dualscale/answer_dropdown.twig Diff File
mod - application/views/survey/questions/answer/arrays/dualscale/answer_header.twig Diff File
mod - application/views/survey/questions/answer/arrays/increasesamedecrease/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/increasesamedecrease/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/increasesamedecrease/rows/cells/thead.twig Diff File
mod - application/views/survey/questions/answer/arrays/multiflexi/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/cells/answer_td.twig Diff File
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/cells/answer_td_checkboxes.twig Diff File
mod - application/views/survey/questions/answer/arrays/multiflexi/rows/repeat_header.twig Diff File
mod - application/views/survey/questions/answer/arrays/texts/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/texts/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/texts/rows/cells/answer_td.twig Diff File
mod - application/views/survey/questions/answer/arrays/texts/rows/cells/thead.twig Diff File
mod - application/views/survey/questions/answer/arrays/texts/rows/repeat_header.twig Diff File
mod - application/views/survey/questions/answer/arrays/yesnouncertain/answer.twig Diff File
mod - application/views/survey/questions/answer/arrays/yesnouncertain/rows/answer_row.twig Diff File
mod - application/views/survey/questions/answer/arrays/yesnouncertain/rows/cells/thead.twig Diff File
mod - application/views/survey/questions/answer/global/table/cell/head_header.twig Diff File
mod - assets/packages/template-core/template-core.css Diff File
mod - themes/survey/fruity/css/noTablesGeneral.css Diff File
mod - themes/survey/vanilla/css/noTablesOnMobile.css Diff File
mod - themes/survey/vanilla/css/theme.css Diff File

Issue History

Date Modified Username Field Change
2022-07-26 15:45 tpartner New Issue
2022-07-26 15:49 ollehar Note Added: 71142
2022-07-26 15:49 ollehar Bug heat 0 => 2
2022-07-26 15:52 tpartner Note Added: 71143
2022-07-26 15:52 tpartner Bug heat 2 => 4
2022-07-26 15:56 guest Bug heat 4 => 10
2022-07-26 15:58 ecoplan Note Added: 71144
2022-07-26 15:58 ecoplan Bug heat 10 => 12
2022-07-26 15:59 ollehar Note Added: 71145
2022-07-26 16:04 tpartner Note Added: 71146
2022-07-26 16:05 tpartner Note Added: 71147
2022-07-26 16:07 tpartner Note Edited: 71147
2022-07-26 16:13 ollehar Note Added: 71148
2022-07-26 16:18 jelo Note Added: 71149
2022-07-26 16:18 jelo Bug heat 12 => 14
2022-07-26 16:20 ollehar Note Added: 71150
2022-07-26 16:21 tpartner Note Added: 71151
2022-07-26 16:44 DenisChenu Note Added: 71152
2022-07-26 16:44 DenisChenu Bug heat 14 => 16
2022-07-26 16:53 ollehar Note Added: 71153
2022-07-26 16:58 DenisChenu Note Added: 71154
2022-07-26 17:12 tpartner Note Added: 71155
2022-07-26 17:33 DenisChenu Note Added: 71156
2022-07-26 17:45 jelo Note Added: 71157
2022-07-26 17:52 ollehar Note Added: 71158
2022-07-26 18:03 gabrieljenik Note Added: 71160
2022-07-26 18:03 gabrieljenik Bug heat 16 => 18
2022-07-26 18:03 gabrieljenik Status new => confirmed
2022-07-26 18:05 ollehar Note Added: 71161
2022-07-27 11:28 ollehar Changeset attached => LimeSurvey master 167f2d46
2022-07-27 11:28 ollehar Note Added: 71166
2022-07-27 11:28 ollehar Assigned To => ollehar
2022-07-27 11:28 ollehar Resolution open => fixed
2022-07-27 11:28 ollehar Note Added: 71168
2022-07-27 11:46 tpartner Note Added: 71169
2022-07-27 11:48 LimeBot Note Added: 71170
2022-07-27 11:48 LimeBot Status confirmed => closed
2022-07-27 11:48 LimeBot Bug heat 18 => 20
2022-07-27 11:49 ollehar Note Added: 71175
2022-07-27 12:53 ollehar Status closed => new
2022-07-27 12:53 ollehar Resolution fixed => reopened
2022-07-27 12:53 ollehar Status new => closed
2022-07-27 13:12 tpartner Note Added: 71177
2022-07-28 10:35 DenisChenu Status closed => feedback
2022-07-28 10:38 DenisChenu Status feedback => closed
2022-07-28 10:38 DenisChenu Note Added: 71218