View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18224 | Bug reports | User / Groups / Roles | public | 2022-06-30 00:32 | 2022-09-27 21:44 |
Reporter | mhladun | Assigned To | DenisChenu | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | reopened | ||
Product Version | 5.3.x | ||||
Fixed in Version | 5.3.x | ||||
Summary | 18224: Can't set Survey Permissions for User Group when usercontrolSameGroupPolicy is false | ||||
Description | Ideally, when usercontrolSameGroupPolicy is set to false/0, a survey owner can:
This isn't the case, but modifying two lines in SurveyPermission.php, by adding the condition,
can fix this. The two lines are, ~ line 435 and ~ 591 | ||||
Steps To Reproduce | Steps to reproduce
Expected result
Actual result
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | 5.3.20 + 220615 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | Postgresql, EnterpriseDB 10.9.17 | ||||
Server OS (if known) | Windows | ||||
Webserver software & version (if known) | Apache/2.4.53 (Win64) OpenSSL/1.1.1n | ||||
PHP Version | PHP/8.0.19 | ||||
parent of | 18297 | closed | DenisChenu | Survey permissions menu does not work |
I think you can create a Pull Request , Maybe something like this
|
|
Alt solution : doing it in https://github.com/LimeSurvey/LimeSurvey/blob/4166d26e155082a42b4476a929086b8fd4abc6fa/application/helpers/common_helper.php#L4135 ? |
|
@DenisChenu sounds good. Should I submit a pull request with the code changes, or does any more discussion need to occur? |
|
Please : submit the pool request , and assign it to me :). |
|
@DenisChenu https://github.com/LimeSurvey/LimeSurvey/pull/2498 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33681 |
|
Fixed in Release 5.3.28+220727 |
|
After updating to version 5.3.30+220808 it seems to work again for now. |
|
LimeSurvey: master 49e2d2fc 2022-07-25 21:30 skwzrd Committer: GitHub Details Diff |
Fixed issue 18224: Can't set Survey Permissions for User Group when usercontrolSameGroupPolicy is false Dev: phpcs |
Affected Issues 18224 |
|
mod - application/controllers/SurveysGroupsPermissionController.php | Diff File | ||
mod - application/controllers/admin/SurveyPermission.php | Diff File | ||
mod - application/helpers/common_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-06-30 00:32 | mhladun | New Issue | |
2022-06-30 00:32 | mhladun | File Added: user_group_survey_permissions.png | |
2022-06-30 09:08 | DenisChenu | Note Added: 70620 | |
2022-06-30 09:08 | DenisChenu | Bug heat | 0 => 2 |
2022-06-30 09:10 | DenisChenu | Note Added: 70621 | |
2022-06-30 20:42 | mhladun | Note Added: 70644 | |
2022-06-30 20:42 | mhladun | Bug heat | 2 => 4 |
2022-07-02 01:38 | gabrieljenik | Assigned To | => DenisChenu |
2022-07-02 01:38 | gabrieljenik | Status | new => assigned |
2022-07-02 09:52 | DenisChenu | Note Added: 70689 | |
2022-07-04 15:18 | DenisChenu | Priority | none => normal |
2022-07-04 20:24 | mhladun | Note Added: 70694 | |
2022-07-25 19:30 | Changeset attached | => LimeSurvey master 49e2d2fc | |
2022-07-25 19:30 | guest | Note Added: 71129 | |
2022-07-25 19:30 | guest | Bug heat | 4 => 6 |
2022-07-27 11:48 | LimeBot | Note Added: 71171 | |
2022-07-27 11:48 | LimeBot | Status | assigned => closed |
2022-07-27 11:48 | LimeBot | Resolution | open => fixed |
2022-07-27 11:48 | LimeBot | Bug heat | 6 => 8 |
2022-08-01 15:51 | ollehar | Status | closed => feedback |
2022-08-01 15:51 | ollehar | Resolution | fixed => reopened |
2022-08-01 15:51 | ollehar | Relationship added | parent of 18297 |
2022-08-01 15:51 | ollehar | Note Added: 71267 | |
2022-08-01 15:51 | ollehar | Bug heat | 8 => 10 |
2022-08-01 18:23 | DenisChenu | Status | feedback => resolved |
2022-08-01 18:23 | DenisChenu | Fixed in Version | => 5.3.x |
2022-08-09 20:17 | adelphisurveys | Note Added: 71392 | |
2022-08-09 20:17 | adelphisurveys | Bug heat | 10 => 12 |
2022-09-27 21:44 | c_schmitz | Status | resolved => closed |