View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18204 | Feature requests | Plugins | public | 2022-06-21 13:10 | 2022-06-22 10:37 |
Reporter | ollehar | Assigned To | ollehar | ||
Priority | none | Severity | feature | ||
Status | assigned | Resolution | open | ||
Summary | 18204: New event: ExtendForm | ||||
Description |
| ||||
Tags | No tags attached. | ||||
Bug heat | 4 | ||||
Ping @DenisChenu and @gabrieljenik if you're interested. We will work on this internally and initially only support global settings form and input checkbox. Added to LS5 LTS, I guess (dev branch). |
|
You mean : for GroupSettings ? UserSettings ? near SurveySettings Something related to an object with an id ? https://manual.limesurvey.org/BeforeSurveySettings |
|
This would be a general event for any form that supports it. So, one form event to rule them all. :) |
|
But : you need to review all existing form then ? Before : need to review core form …
|
|
Yeah, but we're just gonna support global settings for now. Rest are added when needed by a plugin author. |
|
|
|
:( To add 3elements
I never have to update global settings , See how i do to create forum since some years now (and it work without update plugin …) : https://gitlab.com/SondagesPro/mailing/sendMailCron/-/blob/master/sendMailCron.php#L1403 We already hae 2 form constructor : one for Survey and one for QuestionAttribute. |
|
No no. |
|
Let me read those again, then. But I doubt they are really flexible, nor object oriented... |
|
Not really flexible … right. |
|
OK, so how would you add a new select2 or datepicker as a survey setting...? |
|
Ah, it's using the SettingsWidget. Also used by plugin settings, right? I thought about that one... |
|
Like always … «je me débrouille comme je peux» example : https://gitlab.com/SondagesPro/OrcidAuthenticate/-/blob/master/views/admin/IntroductionSetting.php |
|
So you'd prefer |
|
I prefer something easy and stable ;) I think i already create a mantis issue about moving QuestoionAttributes + CoreForms + PluginSettings to same extension . Else : i thionk have a definition array without need to create new object each time still instresting |
|
Arrays require more writing than objects, tho. And they have no validation, or defaults. But a middle-ground is to have objects with $input->toSettingsWidget() function that converts them. Idk. |
|
?
core can offer some … PluginSettings have htmlOptions and current
default saveMethod by core can be great |
|
Idk, the settings widget is doing a lot of shit... Starting form tags, registering css and js files, ... It should have been an object hierarchy rather, SettingsWidgetButton, SettingsWidgetBoolean, etc, instead of a function for every setting type. Then it could have been reused in different contexts. |
|
Yes … |
|
Ya, but not sure how... xD Needs info about database table and column and validation. Basically model data.
?? |
|
Urgh. No. |
|
Why not use PluginSettings table by default ? When i mean default : a default table + way to save. I already use PluginSettings table to save User related data. |
|
Then seem:s best to move (after) PluginSettings to the new ExtendForm system, no ? |
|
We also have AdvancedSettingWidget and GeneralOptionWidget for question editor. Already based on DTOs. |
|
Yes, PS : AdvancedSettingWidget are for QuestionAttribute |
|
Hmmm, yes, this works, true. |
|
Lack of optionnal htmlOptions (html5) and way to extend |
|
What's HTML5 html options? Extend how? Something else than new attributes? |
|
Oups … |
|
Actually, does this even need to be an event? We can have a service provider or module instead, where you can add input elements during system init. So.
And then application code just fetch inputs from that service locator when needed. |
|
Need to be in API then , not in App only. Then it's clearly set it can be used without issue since API version are not updated. |
|
Hm, yes, correct. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2022-06-21 13:10 | ollehar | New Issue | |
2022-06-21 13:10 | ollehar | Status | new => assigned |
2022-06-21 13:10 | ollehar | Assigned To | => ollehar |
2022-06-21 13:11 | ollehar | Note Added: 70423 | |
2022-06-21 13:11 | ollehar | Bug heat | 0 => 2 |
2022-06-21 13:12 | ollehar | Note Edited: 70423 | |
2022-06-21 14:20 | DenisChenu | Note Added: 70424 | |
2022-06-21 14:20 | DenisChenu | Bug heat | 2 => 4 |
2022-06-21 14:30 | ollehar | Note Added: 70425 | |
2022-06-21 14:36 | DenisChenu | Note Added: 70426 | |
2022-06-21 14:37 | ollehar | Note Added: 70427 | |
2022-06-21 14:39 | ollehar | Note Added: 70428 | |
2022-06-21 14:39 | ollehar | Note Edited: 70428 | |
2022-06-21 14:39 | ollehar | Note Edited: 70428 | |
2022-06-21 14:44 | DenisChenu | Note Added: 70429 | |
2022-06-21 14:52 | ollehar | Note Added: 70430 | |
2022-06-21 14:52 | ollehar | Note Added: 70431 | |
2022-06-21 14:54 | DenisChenu | Note Added: 70432 | |
2022-06-21 15:07 | ollehar | Note Added: 70433 | |
2022-06-21 15:10 | ollehar | Note Added: 70434 | |
2022-06-21 15:12 | DenisChenu | Note Added: 70435 | |
2022-06-21 15:12 | ollehar | Note Added: 70436 | |
2022-06-21 15:12 | ollehar | Note Edited: 70436 | |
2022-06-21 15:13 | ollehar | Note Edited: 70436 | |
2022-06-21 15:15 | DenisChenu | Note Added: 70437 | |
2022-06-21 15:18 | ollehar | Note Added: 70438 | |
2022-06-21 15:24 | DenisChenu | Note Added: 70439 | |
2022-06-21 15:25 | ollehar | Note Added: 70440 | |
2022-06-21 15:28 | DenisChenu | Note Added: 70441 | |
2022-06-21 15:30 | ollehar | Note Added: 70442 | |
2022-06-21 15:32 | ollehar | Note Added: 70443 | |
2022-06-21 15:34 | DenisChenu | Note Added: 70444 | |
2022-06-21 15:34 | DenisChenu | Note Added: 70445 | |
2022-06-21 15:35 | ollehar | Note Added: 70446 | |
2022-06-21 15:37 | DenisChenu | Note Added: 70447 | |
2022-06-21 15:37 | ollehar | Note Added: 70448 | |
2022-06-21 15:38 | DenisChenu | Note Added: 70450 | |
2022-06-21 15:41 | ollehar | Note Added: 70451 | |
2022-06-21 15:49 | DenisChenu | Note Added: 70452 | |
2022-06-22 10:17 | ollehar | Note Added: 70477 | |
2022-06-22 10:25 | ollehar | Note Edited: 70477 | |
2022-06-22 10:25 | ollehar | Note Edited: 70477 | |
2022-06-22 10:35 | DenisChenu | Note Added: 70478 | |
2022-06-22 10:37 | ollehar | Note Added: 70479 |