View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
18196Bug reportsData Entry (non public)public2022-08-01 10:26
Reporterzufolo441 Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18196: Property "Question.same_script" is not defined.
Description

Property "Question.same_script" is not defined.

Steps To Reproduce

after the upgrade to 5.3.20, when I reopen a survey I obtain this error.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)5.3.20
I will donate to the project if issue is resolvedYes
BrowserFirefox 101
Database type & versionPostgresql 13
Server OS (if known)FreeBSD 13.1
Webserver software & version (if known)
PHP VersionPHP 7.4.27

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-06-16 10:20

developer   ~70386

?
Update of database is done here : https://github.com/LimeSurvey/LimeSurvey/commit/d32eb5e4c21cde50c3efa57bebecc264cc676135#diff-37a3b62a7a21f84f94b9d867c7d61607d12581c551e7b3c30cac6c6ca57cdb21R10

What is your database version ?

DenisChenu

DenisChenu

2022-06-16 10:21

developer   ~70387

ping @gabrieljenik

zufolo441

zufolo441

2022-06-16 10:27

reporter   ~70388

488

zufolo441

zufolo441

2022-06-16 10:44

reporter   ~70389

Solved: in this particular installation I never logged in,so the upgrade script never executed. Thank you to address me to right direction!

DenisChenu

DenisChenu

2022-06-16 10:49

developer   ~70390

How do you update ?
If you update via CLI : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/commands/UpdateDbCommand.php

Else : we must avoid such situation i think.
I look at a potential solution

zufolo441

zufolo441

2022-06-16 11:03

reporter   ~70391

No, i let the upgrade runs during the first login as admin.
I think it is a reasonable behavior: the admin must check everything is working after upgrade.
But we have 5 installations in production, sometimes I forget to check them. My mistake.

DenisChenu

DenisChenu

2022-06-16 15:07

developer   ~70394

There are potential solution, if we can avoid public issue it's better :)

gabrieljenik

gabrieljenik

2022-06-16 19:13

manager   ~70397

As per the comments, will be closing the ticket.
Please add any comments in case it should be reopened.
Thanks

DenisChenu

DenisChenu

2022-06-17 09:12

developer   ~70399

Reopen
Way to reproduce.

Create a multilingual survey with script
Activate
Unlog
As FTP : upgrade from 5.3.19 to 5.3.20
launch your survey : public broke.

There are an easy fix for this ,
I already assign to me … (« I look at a potential solution»).

DenisChenu

DenisChenu

2022-06-17 09:22

developer   ~70400

I really think there are no need to test … more.
It's the way to do

DenisChenu

DenisChenu

2022-06-17 09:23

developer   ~70401

https://github.com/LimeSurvey/LimeSurvey/pull/2469

gabrieljenik

gabrieljenik

2022-06-17 17:14

manager   ~70406

Way to reproduce.

Nice. Congrats

gabrieljenik

gabrieljenik

2022-07-05 13:49

manager   ~70713

Maybe we should add some kind of lock that enforces users to login if the DB and the code version doesn't match?

DenisChenu

DenisChenu

2022-07-05 14:08

developer   ~70714

Maybe we should add some kind of lock that enforces users to login if the DB and the code version doesn't match?

You can not … without disable public access.

For major issue : we must disable public access (example 3 to 5) clearly.
For some other : maybe we must prevent potential issue.

DenisChenu

DenisChenu

2022-07-29 18:30

developer   ~71245

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33688

LimeBot

LimeBot

2022-08-01 10:23

administrator   ~71256

Fixed in Release 5.3.29+220801

LimeBot

LimeBot

2022-08-01 10:26

administrator   ~71259

Fixed in Release 5.3.29+220801

Related Changesets

LimeSurvey: master 2d311b12

2022-07-29 18:30:54

DenisChenu


Committer: GitHub Details Diff
Fixed issue 18196: Property "Question.same_script" is not defined. (#2469)

DeV: set default when load, then set by php before updated by DB
Dev: better to do it each time we add a column.
Affected Issues
18196
mod - application/models/Question.php Diff File

Issue History

Date Modified Username Field Change
2022-06-16 09:57 zufolo441 New Issue
2022-06-16 10:20 DenisChenu Note Added: 70386
2022-06-16 10:20 DenisChenu Bug heat 0 => 2
2022-06-16 10:21 DenisChenu Assigned To => gabrieljenik
2022-06-16 10:21 DenisChenu Status new => feedback
2022-06-16 10:21 DenisChenu Assigned To gabrieljenik =>
2022-06-16 10:21 DenisChenu Note Added: 70387
2022-06-16 10:27 zufolo441 Note Added: 70388
2022-06-16 10:27 zufolo441 Bug heat 2 => 4
2022-06-16 10:27 zufolo441 Status feedback => new
2022-06-16 10:44 zufolo441 Note Added: 70389
2022-06-16 10:49 DenisChenu Note Added: 70390
2022-06-16 10:49 DenisChenu Assigned To => DenisChenu
2022-06-16 10:49 DenisChenu Status new => assigned
2022-06-16 11:03 zufolo441 Note Added: 70391
2022-06-16 15:07 DenisChenu Note Added: 70394
2022-06-16 19:13 gabrieljenik Status assigned => closed
2022-06-16 19:13 gabrieljenik Resolution open => no change required
2022-06-16 19:13 gabrieljenik Note Added: 70397
2022-06-16 19:13 gabrieljenik Bug heat 4 => 6
2022-06-17 09:12 DenisChenu Status closed => confirmed
2022-06-17 09:12 DenisChenu Note Added: 70399
2022-06-17 09:22 DenisChenu Assigned To DenisChenu =>
2022-06-17 09:22 DenisChenu Status confirmed => ready for code review
2022-06-17 09:22 DenisChenu Note Added: 70400
2022-06-17 09:23 DenisChenu Note Added: 70401
2022-06-17 17:14 gabrieljenik Note Added: 70406
2022-07-05 13:49 gabrieljenik Note Added: 70713
2022-07-05 14:08 DenisChenu Note Added: 70714
2022-07-29 18:30 DenisChenu Changeset attached => LimeSurvey master 2d311b12
2022-07-29 18:30 DenisChenu Note Added: 71245
2022-07-29 18:30 DenisChenu Assigned To => DenisChenu
2022-07-29 18:30 DenisChenu Resolution no change required => fixed
2022-08-01 10:23 LimeBot Note Added: 71256
2022-08-01 10:23 guest Bug heat 6 => 8
2022-08-01 10:26 LimeBot Note Added: 71259
2022-08-01 10:26 LimeBot Status ready for code review => closed