View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 14
IDProjectCategoryView StatusDate SubmittedLast Update
18180Bug reportsRemoteControlpublic2022-06-07 11:192023-04-03 10:58
ReporterH1441H Assigned Toollehar  
PrioritynoneSeveritycrash 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18180: Calling set_participant_properties with an invalid token id throws an internal server error
Description

https://api.limesurvey.org/classes/remotecontrol_handle.html#method_set_participant_properties

When you call set_participant_properties with an invalid token id passed as an integer 9999999 to $aTokenQueryProperties, the api throws a 500 Internal Server Error.

When you call set_participant_properties with an invalid token id passed as an array (tid=>9999999) to $aTokenQueryProperties, the api returns the expected status message 'Error: No results were found based on your attributes.'

This behaviour is inconsistent.

Steps To Reproduce

Steps to reproduce

This fails on any survey.
Call the RemoteControl procedure 'set_participant_properties'.
Pass an invalid token id (eg 99999999) as an integer to $aTokenQueryProperties.

Expected result

The RPC should respond with the status message Error: Invalid tokenid.

Actual result

The RPC throws a 500 Internal Server Error.

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)5.3.18+220530
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & version5.5.5-10.2.40-MariaDB-10.2.40+maria~stretch
Server OS (if known)Linux
Webserver software & version (if known)Apache
PHP Version 7.3.33

Relationships

Relationship GraphDependency Graph
has duplicate 18179 closedgabrieljenik Feature requests Calling set_participant_properties with an invalid token id throws an internal server error 

Users monitoring this issue

H1441H

Activities

gabrieljenik

gabrieljenik

2022-06-13 18:59

manager   ~70349

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2465/
guest

guest

2023-03-31 09:51

viewer   ~74327

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34407
LimeBot

LimeBot

2023-04-03 10:58

administrator   ~74344

Fixed in Release 5.6.14+230403

Related Changesets

LimeSurvey: master 6875b227

2023-03-31 11:51

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 18180: Calling set_participant_properties with an invalid token id throws an internal server error (#2465)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18180
mod - application/helpers/remotecontrol/remotecontrol_handle.php Diff File
add - tests/data/surveys/limesurvey_survey_get_participant_properties.lsa Diff File
add - tests/unit/helpers/remotecontrol/EncryptedCoreParticipantPropertiesTest.php Diff File
mod - tests/unit/helpers/remotecontrol/GetParticipantPropertiesTest.php Diff File

Issue History

Date Modified Username Field Change
2022-06-07 11:19 H1441H New Issue
2022-06-08 23:46 gabrieljenik Status new => acknowledged
2022-06-09 18:22 gabrieljenik Relationship added has duplicate 18179
2022-06-09 18:22 gabrieljenik Issue Monitored: H1441H
2022-06-09 18:22 gabrieljenik Bug heat 0 => 8
2022-06-09 18:23 gabrieljenik Assigned To => gabrieljenik
2022-06-09 18:23 gabrieljenik Status acknowledged => assigned
2022-06-13 18:59 gabrieljenik Summary 18179: Calling set_participant_properties with an invalid token id throws an internal server error => Calling set_participant_properties with an invalid token id throws an internal server error
2022-06-13 18:59 gabrieljenik Status assigned => ready for code review
2022-06-13 18:59 gabrieljenik Note Added: 70349
2022-06-13 18:59 gabrieljenik Bug heat 8 => 10
2022-07-05 15:18 gabrieljenik Assigned To gabrieljenik =>
2022-07-05 15:18 gabrieljenik Status ready for code review => ready for testing
2023-03-14 22:25 gabrieljenik Assigned To => ollehar
2023-03-14 22:25 gabrieljenik Status ready for testing => ready for merge
2023-03-31 09:51 Changeset attached => LimeSurvey master 6875b227
2023-03-31 09:51 guest Note Added: 74327
2023-03-31 09:51 guest Bug heat 10 => 12
2023-03-31 09:52 ollehar Status ready for merge => resolved
2023-03-31 09:52 ollehar Resolution open => fixed
2023-04-03 10:58 LimeBot Note Added: 74344
2023-04-03 10:58 LimeBot Status resolved => closed
2023-04-03 10:58 LimeBot Bug heat 12 => 14