View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
18032Bug reportsSurvey editingpublic2023-09-08 21:13
Reportergabrieljenik Assigned To 
PrioritynoneSeverityminor 
Status confirmedResolutionopen 
Product Version5.2.x 
Summary18032: LSJsonExceptions handling and rendering
Description

LSJsonExceptions are supposed to be handled by the SurveysController in the actionError() method, only when it's an AJAX request. But when it's AJAX it never gets there, because it gets caught before LSYii_Application::onException() (line 403). It would be necessary to add one more condition to that IF, excluding the LSJsonException.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)5.x
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Versionphp

Relationships

related to 18019 closedgabrieljenik 500 error in question edition (bad code on question) 
related to 18033 closedgabrieljenik Model errors need friendlier messages. 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-04-13 09:52

developer   ~69037

Else : a die broke all other action : https://github.com/LimeSurvey/LimeSurvey/blob/cd03fc7ed0d2840b4462994e5e4dc1a340b63796/application/core/LSYii_Application.php#L407
We need App()->end();

DenisChenu

DenisChenu

2022-04-14 13:30

developer   ~69071

@gabrieljenik : can you give me the way to check the error ?
I mean

  • Action to do
  • Must show "this"
  • show other.
gabrieljenik

gabrieljenik

2022-04-14 14:25

manager   ~69076

Well, this poped up while reviewing the issue 18019
https://bugs.limesurvey.org/view.php?id=18019#c68937

Then we handled the exception and the LSJsonException is not shown there anymore.
Still the underlying problem exists.
Maybe you could go back to the previous coommit and review?

DenisChenu

DenisChenu

2022-04-15 08:03

developer   ~69092

@gabrieljenik : you already have a solution for this one ? You want to fix it ?

gabrieljenik

gabrieljenik

2022-04-18 15:51

manager   ~69103

Don't have a fix, but we were digging a bit when reviewing 18019
We can take it if you want.

DenisChenu

DenisChenu

2022-04-21 08:04

developer   ~69146

If you're OK, yes please :)
I don't have idea here …

Issue History

Date Modified Username Field Change
2022-04-12 23:53 gabrieljenik New Issue
2022-04-12 23:53 gabrieljenik Relationship added related to 18019
2022-04-12 23:58 gabrieljenik Issue cloned: 18033
2022-04-12 23:58 gabrieljenik Relationship added related to 18033
2022-04-13 09:19 galads Assigned To => DenisChenu
2022-04-13 09:19 galads Status new => assigned
2022-04-13 09:52 DenisChenu Note Added: 69037
2022-04-13 09:52 DenisChenu Bug heat 0 => 2
2022-04-14 13:30 DenisChenu Note Added: 69071
2022-04-14 14:25 gabrieljenik Note Added: 69076
2022-04-14 14:25 gabrieljenik Bug heat 2 => 4
2022-04-15 08:03 DenisChenu Note Added: 69092
2022-04-18 15:51 gabrieljenik Note Added: 69103
2022-04-21 08:04 DenisChenu Note Added: 69146
2022-04-21 08:05 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-05-17 23:59 gabrieljenik Status assigned => confirmed
2023-09-08 21:13 gabrieljenik Assigned To gabrieljenik =>