View Issue Details

Jump to NotesJump to History
This issue affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
18033Bug reportsSurvey editingpublic2022-04-12 23:582022-07-05 19:49
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.2.x 
Summary18033: Model errors need friendlier messages.
Description

Related to 18019
Now shows the error in an alert, its content is still ugly (the print_r is still there).

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)5.x
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Versionphp

Relationships

Relationship GraphDependency Graph
related to 18032 confirmed LSJsonExceptions handling and rendering 
related to 18116 closedgabrieljenik Ability to disable animation layer regarding saving in header section 
related to 18152 closedgabrieljenik Unable to manage theme with debug set 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-04-12 23:58

manager   ~69027

image.png (81,940 bytes)   
image.png (81,940 bytes)   
DenisChenu

DenisChenu

2022-05-24 15:25

developer   ~70005

Maybe we can use same "html look and class" for error when Save and error when save and cllose

See related issue.
gabrieljenik

gabrieljenik

2022-05-24 15:39

manager   ~70008

This is more like an internal enhancement.
I believe 18116 is related to how errors are displayed.

Still, could be linked to a better rendering, yes
gabrieljenik

gabrieljenik

2022-05-24 15:40

manager   ~70009

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2439

Created a UserException class which can be friednly shown as a flash message or rendered as json message.
This is good for triggering exceptions directly from the model, for example, and ease its handling by the controller.
DenisChenu

DenisChenu

2022-05-24 16:09

developer   ~70012

I believe 18116 is related to how errors are displayed.

Only for JSON error currently. See https://bugs.limesurvey.org/view.php?id=18116#c69778
When use save and close.

Save and close allow multiple message: error + warning + success in same action

I have a report to do to show plugin FlashMessage when save .
gabrieljenik

gabrieljenik

2022-07-05 19:49

manager   ~70755

Has been merged

Issue History

Date Modified Username Field Change
2022-04-12 23:58 gabrieljenik New Issue
2022-04-12 23:58 gabrieljenik Issue generated from: 18032
2022-04-12 23:58 gabrieljenik Relationship added related to 18032
2022-04-12 23:58 gabrieljenik Note Added: 69027
2022-04-12 23:58 gabrieljenik File Added: image.png
2022-04-12 23:58 gabrieljenik Bug heat 0 => 2
2022-04-13 09:19 galads Assigned To => gabrieljenik
2022-04-13 09:19 galads Status new => assigned
2022-05-24 15:24 DenisChenu Relationship added related to 18116
2022-05-24 15:25 DenisChenu Note Added: 70005
2022-05-24 15:25 DenisChenu Bug heat 2 => 4
2022-05-24 15:39 gabrieljenik Note Added: 70008
2022-05-24 15:40 gabrieljenik Note Added: 70009
2022-05-24 16:09 DenisChenu Note Added: 70012
2022-05-27 22:36 gabrieljenik Relationship added related to 18152
2022-07-05 19:49 gabrieljenik Status assigned => closed
2022-07-05 19:49 gabrieljenik Resolution open => fixed
2022-07-05 19:49 gabrieljenik Note Added: 70755